Page MenuHomePhabricator

Remove repository prefixes from RdfBuilderTest data
Closed, ResolvedPublic

Description

RdfBuilderTest contains tests dealing with non-local entities. At least some of these tests are useful for the structured data for Commons functionality, but a lot of it still uses the unused repository prefixes in entity IDs in the test data.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/929366/2 "blindly" removes some of the prefixes to unblock shipping the patch that disallows repository prefixes in entity IDs, but there are still a lot of other tests and fixture files that should be cleaned up. This work could benefit from someone who knows their way around these RdfBuilder tests to help with the cleanup.

Related Objects

Event Timeline

Change 929366 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Remove tests relying on entity ID prefixes

https://gerrit.wikimedia.org/r/929366

Change 929366 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove tests relying on entity ID prefixes

https://gerrit.wikimedia.org/r/929366

Change 930872 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] Removed references to getLocalPart in TermsRdfBuilderTest

https://gerrit.wikimedia.org/r/930872

Change 930873 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] Removed EntityId "local part" from RdfVocabulary

https://gerrit.wikimedia.org/r/930873

Change 930874 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] Removed invalid "prefixed" property IDs from RdfBuilderTestData

https://gerrit.wikimedia.org/r/930874

Change 930875 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] Removed RdfBuilderTestData::getTestProperties_noPrefixedIds

https://gerrit.wikimedia.org/r/930875

Change 930876 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] WIP Removed no longer needed RDF test data

https://gerrit.wikimedia.org/r/930876

Change 931323 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] (Re-)added RDF tests for properties that are from the "local" Wikibase

https://gerrit.wikimedia.org/r/931323

Change 930872 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed references to getLocalPart in TermsRdfBuilderTest

https://gerrit.wikimedia.org/r/930872

Change 930873 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed EntityId "local part" from RdfVocabulary

https://gerrit.wikimedia.org/r/930873

Change 930875 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed RdfBuilderTestData::getTestProperties_noPrefixedIds

https://gerrit.wikimedia.org/r/930875

Change 930876 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed no longer needed RDF test data

https://gerrit.wikimedia.org/r/930876

Change 930874 abandoned by WMDE-leszek:

[mediawiki/extensions/Wikibase@master] Removed invalid "prefixed" property IDs from RdfBuilderTestData

Reason:

change happened in I46b7eff7cfe3b472b58e9a45f2f217dc70fafbe7

https://gerrit.wikimedia.org/r/930874

Change 931323 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] (Re-)added RDF tests for properties that are from the "local" Wikibase

https://gerrit.wikimedia.org/r/931323

Seems like it has been cleaned up sufficiently.