Remove popup indicator on page load and associated configuration
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	May 8 2023, 6:56 PM

Description

Per T335307 this should be removed 2 weeks after usage.
Since T335307 was deployed on Monday 8th May, this should be removed on Monday 22nd May.
We can use a train deployment to make this happen. Doesn't matter if we have a few more days.

TODO

Remove the config $wgVectorLimitedWidthIndicator
Remove the indicators that show on page load
Retain indicators that show when the button is clicked

QA steps

Clicking the button should show a popup.
A popup should never shown on page load to anonymous users.

Sign off steps

Notify Jennifer that the experiment has been run and we need to record any changes in behaviour we noticed.
Update https://www.mediawiki.org/wiki/Reading/Web/Release_timeline with details on when this was disabled.
Create a patch to remove VectorLimitedWidthIndicator from mediawiki-config and either deploy it or create a follow up ticket to make sure that happens in a future sprint.

Details

Subject	Repo	Branch	Lines +/-
Remove VectorLimitedWidthIndicator	operations/mediawiki-config	master	+0 -9
Remove limited toggle notification on page load	mediawiki/skins/Vector	master	+2 -153
Remove limited width popup that shows on page load	mediawiki/skins/Vector	master	+3 -133

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	BUG REPORT	KSarabia-WMF	T336197 Remove popup indicator on page load and associated configuration
		Declined		jwang	T336295 Repeat analysis of fixed width toggle

Event Timeline

Jdlrobson created this task.May 8 2023, 6:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 8 2023, 6:56 PM

Change 917398 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Remove limited width popup that shows on page load

https://gerrit.wikimedia.org/r/917398

gerritbot added a project: Patch-For-Review.May 8 2023, 6:57 PM

Jdlrobson mentioned this in T335307: Deploy fixed width indicator to English Wikipedia.May 8 2023, 6:57 PM

Jdlrobson triaged this task as High priority.May 8 2023, 8:17 PM

ovasileva mentioned this in T336295: Repeat analysis of fixed width toggle.May 9 2023, 6:45 PM

LGoto set the point value for this task to 2.May 11 2023, 5:54 PM

Jdlrobson merged a task: T336475: Limited toggle indicator keeps reappearing.May 15 2023, 5:29 PM

Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 4) board.

Jdlrobson added a subscriber: jhsoby.

matmarex subscribed.May 17 2023, 11:21 AM

bwang claimed this task.May 22 2023, 6:27 PM

bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 4) board.

Change 922160 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Remove limited toggle notification on page load and VectorLimitedWidthIndicator config

https://gerrit.wikimedia.org/r/922160

bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 4) board.May 22 2023, 8:40 PM

bwang removed bwang as the assignee of this task.May 23 2023, 4:42 PM

bwang subscribed.

Jdlrobson claimed this task.May 25 2023, 4:40 PM

Change 917398 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Remove limited width popup that shows on page load

Reason:

See https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/922160

https://gerrit.wikimedia.org/r/917398

Jdlrobson reassigned this task from Jdlrobson to Edtadros.May 25 2023, 7:28 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 4) board.

Change 922160 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove limited toggle notification on page load

https://gerrit.wikimedia.org/r/922160

Maintenance_bot removed a project: Patch-For-Review.May 26 2023, 10:30 AM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.11; 2023-05-30).May 26 2023, 11:00 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Clicking the button should show a popup.

✅ AC2: A popup should never shown on page load to anonymous users.

Screen Recording 2023-05-30 at 4.43.10 PM.mov.gif (748×1 px, 1 MB)

Jdrewniak assigned this task to KSarabia-WMF.Jun 1 2023, 4:38 PM

Change 926626 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[operations/mediawiki-config@master] Remove VectorLimitedWidthIndicator

https://gerrit.wikimedia.org/r/926626

gerritbot added a project: Patch-For-Review.Jun 2 2023, 8:42 PM

KSarabia-WMF closed this task as Resolved.Jun 2 2023, 8:42 PM

KSarabia-WMF updated the task description. (Show Details)

Jdrewniak moved this task from Ready for Signoff to QA in Production on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 4) board.Jun 6 2023, 4:43 PM

Change 926626 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove VectorLimitedWidthIndicator

https://gerrit.wikimedia.org/r/926626

Mentioned in SAL (#wikimedia-operations) [2023-06-08T20:05:23Z] <ladsgroup@deploy1002> Started scap: Backport for [[gerrit:926626|Remove VectorLimitedWidthIndicator (T336197)]]

Mentioned in SAL (#wikimedia-operations) [2023-06-08T20:06:49Z] <ladsgroup@deploy1002> ladsgroup and ksarabia: Backport for [[gerrit:926626|Remove VectorLimitedWidthIndicator (T336197)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet

Maintenance_bot removed a project: Patch-For-Review.Jun 8 2023, 8:10 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-08T20:12:55Z] <ladsgroup@deploy1002> Finished scap: Backport for [[gerrit:926626|Remove VectorLimitedWidthIndicator (T336197)]] (duration: 07m 32s)

Jdlrobson closed subtask T336295: Repeat analysis of fixed width toggle as Declined.Aug 8 2024, 2:17 PM

	F37085051: Screen Recording 2023-05-30 at 4.43.10 PM.mov.gif
	May 30 2023, 11:45 PM

Remove popup indicator on page load and associated configurationClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions