Remove VectorTableOfContentsBeginning configuration flag
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Apr 18 2023, 5:24 PM

Description

Per the playbook "Triage post-deployment remaining tickets and clean up feature flags or incomplete code"

We should remove the temporary feature flag VectorTableOfContentsBeginning.
It's always true.

QA steps

Find a page with table of contents and confirm there is a "Beginning" ("Top") link at the top of it.

Details

	Subject	Repo	Branch	Lines +/-
	Remove VectorTableOfContentsBeginning flag	mediawiki/skins/Vector	master	+3 -28

Customize query in gerrit

Event Timeline

Jdlrobson created this task.Apr 18 2023, 5:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 18 2023, 5:24 PM

Jdlrobson triaged this task as High priority.Apr 18 2023, 5:24 PM

Jdlrobson lowered the priority of this task from High to Medium.Apr 20 2023, 5:05 PM

Jdlrobson updated the task description. (Show Details)Apr 20 2023, 5:39 PM

ovasileva set the point value for this task to 2.Apr 20 2023, 5:42 PM

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.Apr 24 2023, 4:14 PM

Jdlrobson moved this task from Ready for Development to Incoming on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.Apr 24 2023, 5:42 PM

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3); removed Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2).Apr 24 2023, 5:45 PM

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.May 8 2023, 4:57 PM

ovasileva moved this task from Ready for Development to Incoming on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.May 8 2023, 5:00 PM

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.

bwang claimed this task.May 8 2023, 5:53 PM

bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.

Change 917410 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@master] Remove VectorTableOfContentsBeginning flag

https://gerrit.wikimedia.org/r/917410

gerritbot added a project: Patch-For-Review.May 8 2023, 10:25 PM

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.May 8 2023, 10:25 PM

Change 917410 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove VectorTableOfContentsBeginning flag

https://gerrit.wikimedia.org/r/917410

Maintenance_bot removed a project: Patch-For-Review.May 8 2023, 11:11 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.May 9 2023, 4:35 PM

Jdlrobson reassigned this task from bwang to Edtadros.May 9 2023, 4:36 PM

Jdlrobson added a subscriber: bwang.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 3:02 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Find a page with table of contents and confirm there is a "Beginning" ("Top") link at the top of it.

Screenshot 2023-05-16 at 2.42.02 PM.png (636×744 px, 150 KB)

Screenshot 2023-05-16 at 2.41.27 PM.png (658×732 px, 116 KB)

Screenshot 2023-05-16 at 2.41.18 PM.png (648×789 px, 93 KB)

Screenshot 2023-05-16 at 2.41.39 PM.png (648×705 px, 156 KB)

LGTM
https://codesearch.wmcloud.org/search/?q=VectorTableOfContentsBeginning&files=&excludeFiles=&repos=

	F37001731: Screenshot 2023-05-16 at 2.41.39 PM.png
	May 16 2023, 9:43 PM

	F37001730: Screenshot 2023-05-16 at 2.41.18 PM.png
	May 16 2023, 9:43 PM

	F37001729: Screenshot 2023-05-16 at 2.41.27 PM.png
	May 16 2023, 9:43 PM

	F37001728: Screenshot 2023-05-16 at 2.42.02 PM.png
	May 16 2023, 9:43 PM

Remove VectorTableOfContentsBeginning configuration flagClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions