Page MenuHomePhabricator

IP Info: Remove period from possible values of "Active blocks"
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

AC

Remove the ending period (.) from the end of the possible values under the Active blocks heading.

  • ipinfo-value-active-blocks
  • History and Log Page IP Information pop-ups
Testing

1.Visit the Special:Contributions page, ViewHistory and Logs Page.
2.Verify the ending period (.) from the end of the possible values under the Active blocks heading is non-existent.

Event Timeline

Prtksxna changed the subtype of this task from "Task" to "Bug Report".
Tchanders set the point value for this task to 1.

Change 855481 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/IPInfo@master] IP Info: Remove period from possible values of "Active blocks"

https://gerrit.wikimedia.org/r/855481

Change 855481 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] IP Info: Remove period from possible values of "Active blocks"

https://gerrit.wikimedia.org/r/855481

@Cyndymediawiksim @Prtksxna Period does not appear on Special:Contributions page, ViewHistory, and Logs Page for Active Blocks as seen in the screenshots below. I did check in a different language (ES) and it does have a period though. I'm not sure if you wanted me to test in other languages or just in English. If English only, then we can mark this as Done. Thanks!

Test environment: Beta

Chrome- Contributions in ES: FAIL

T322503_IPInfo_Contributions_Chrome_ES_Fail.png (701×1 px, 195 KB)

Chrome- Contributions in EN: PASS

T322503_IPInfo_Contributions_Chrome_Pass.png (687×1 px, 167 KB)

Chrome- Log: PASS

T322503_IPInfo_Log_Chrome_Pass.png (949×1 px, 177 KB)

Chrome- ViewHistory: PASS

T322503_IPInfo_ViewHistory_Chrome_Pass.png (912×1 px, 240 KB)

@GMikesell-WMF thank you! English only is fine for this one - it may take some time for the translators to update the other languages.

@Tchanders Got it with the other languages. Since English has passed, I will move this to Done. Thanks!