Page MenuHomePhabricator
Create Task
Maniphest T322497

Remove config settings for individual DiscussionTools features
Open, Needs TriagePublic
Actions

Description

Once we don't need the BetaFeatures integration (T322496), we should remove the config settings that we used to control the availability of each feature (reply tool, new topic tool etc.) on each wiki, to simplify future maintenance.

This applies to wgDiscussionTools_replytool, wgDiscussionTools_newtopictool, wgDiscussionTools_sourcemodetoolbar, wgDiscussionTools_topicsubscription, wgDiscussionTools_autotopicsub, wgDiscussionTools_visualenhancements.

With BetaFeatures out of the picture, the availability can be controlled more simply using wgHiddenPrefs.

Details

SubjectRepoBranchLines +/-
Remove most DiscussionTools feature configsoperations/mediawiki-configmaster+0 -30
Remove wgDiscussionToolsEnable configoperations/mediawiki-configmaster+0 -4
Remove DiscussionToolsEnableMobilemediawiki/extensions/DiscussionToolsmaster+3 -13
Remove most DiscussionTools feature configsmediawiki/extensions/DiscussionToolsmaster+17 -30
Drop the DiscussionToolsEnable feature flagmediawiki/extensions/DiscussionToolsmaster+2 -17
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Nov 6 2022, 9:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 6 2022, 9:04 PM
matmarex added a subtask: T322496: Remove the BetaFeatures integration in DiscussionTools.Nov 6 2022, 9:06 PM
matmarex added a subtask: T322493: Remove wgDiscussionTools_visualenhancements sub-features.Nov 6 2022, 9:09 PM
ppelberg added a parent task: T294592: [EPIC] Ensure Talk Pages Project "Phase 1" work is easy to maintain, build upon, and learn from.Nov 17 2022, 4:15 PM
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.
HouseBlaster moved this task from Unsorted to Needs removal on the Technical-Debt board.Dec 3 2022, 7:39 PM
gerritbot added a comment.Jun 6 2023, 12:16 PM

Change 927630 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Drop the DiscussionToolsEnable feature flag

https://gerrit.wikimedia.org/r/927630

gerritbot added a project: Patch-For-Review.Jun 6 2023, 12:16 PM

Change 927632 had a related patch set uploaded (by Esanders; author: Esanders):

[operations/mediawiki-config@master] Remove wgDiscussionToolsEnable config

https://gerrit.wikimedia.org/r/927632

gerritbot added a comment.Jun 6 2023, 12:25 PM

Change 927631 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Remove most DiscussionTools feature configs

https://gerrit.wikimedia.org/r/927631

gerritbot added a comment.Jun 6 2023, 12:25 PM

Change 927633 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Remove DiscussionToolsEnableMobile

https://gerrit.wikimedia.org/r/927633

gerritbot added a comment.Jun 6 2023, 12:46 PM

Change 927653 had a related patch set uploaded (by Esanders; author: Esanders):

[operations/mediawiki-config@master] Remove most DiscussionTools feature configs

https://gerrit.wikimedia.org/r/927653

gerritbot added a comment.Jun 6 2023, 9:27 PM

Change 927630 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Drop the DiscussionToolsEnable feature flag

https://gerrit.wikimedia.org/r/927630

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.13; 2023-06-13).Jun 6 2023, 10:00 PM
gerritbot added a comment.Jun 6 2023, 11:04 PM

Change 927631 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Remove most DiscussionTools feature configs

https://gerrit.wikimedia.org/r/927631

gerritbot added a comment.Jun 6 2023, 11:07 PM

Change 927633 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Remove DiscussionToolsEnableMobile

https://gerrit.wikimedia.org/r/927633

matmarex assigned this task to Esanders.Jun 6 2023, 11:15 PM
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from Incoming to Doing on the Editing-team (Kanban Board) board.
gerritbot added a comment.Jun 27 2023, 8:02 PM

Change 927632 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove wgDiscussionToolsEnable config

https://gerrit.wikimedia.org/r/927632

Stashbot mentioned this in T339871: Remove reference to $wgVisualEditorAllowLossySwitching.Jun 27 2023, 8:03 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-27T20:03:09Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:933460|Remove unused config $wgVisualEditorAllowLossySwitching (T339871)]], [[gerrit:927632|Remove wgDiscussionToolsEnable config (T322497)]]

Stashbot added a comment.Jun 27 2023, 8:04 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-27T20:04:54Z] <samtar@deploy1002> esanders and samtar and matmarex: Backport for [[gerrit:933460|Remove unused config $wgVisualEditorAllowLossySwitching (T339871)]], [[gerrit:927632|Remove wgDiscussionToolsEnable config (T322497)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet

Stashbot added a comment.Jun 27 2023, 8:10 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-27T20:10:45Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:933460|Remove unused config $wgVisualEditorAllowLossySwitching (T339871)]], [[gerrit:927632|Remove wgDiscussionToolsEnable config (T322497)]] (duration: 07m 35s)

gerritbot added a comment.Jun 27 2023, 8:12 PM

Change 927653 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove most DiscussionTools feature configs

https://gerrit.wikimedia.org/r/927653

Stashbot mentioned this in T204193: SecurePoll auth-api.php needs to be rewritten to be a normal api module.Jun 27 2023, 8:13 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-27T20:13:41Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:927653|Remove most DiscussionTools feature configs (T322497)]], [[gerrit:932270|Remove references to auth-api.php (T204193)]]

Stashbot added a comment.Jun 27 2023, 8:15 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-27T20:15:10Z] <samtar@deploy1002> reedy and esanders and samtar: Backport for [[gerrit:927653|Remove most DiscussionTools feature configs (T322497)]], [[gerrit:932270|Remove references to auth-api.php (T204193)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Jun 27 2023, 8:20 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-27T20:20:35Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:927653|Remove most DiscussionTools feature configs (T322497)]], [[gerrit:932270|Remove references to auth-api.php (T204193)]] (duration: 06m 53s)

Maintenance_bot removed a project: Patch-For-Review.Jun 27 2023, 8:31 PM
matmarex removed a project: Editing-team (Kanban Board).Jun 27 2023, 10:22 PM

(Not completed, but further work will have to wait for further deployments)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits