Maniphest T320874

Gallery image count is wrong
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Whatamidoing-WMF
	Oct 15 2022, 7:46 PM

Description

What I did:

Insert > Gallery in 2017WTE
Add two copies of the same image (double-clicked?)
Delete the first.
Insert the gallery. The gallery now contains one image.
Cut, paste, and fix the wikitext for two other images. The gallery now contains three images.
Switch from 2017WTE to the visual editor. The gallery displays the three images correctly.
Click on the gallery
Be surprised to see that the box says "4 images".

Screen Shot 2022-10-15 at 12.40.27 PM.png (828×1 px, 668 KB)

Details

Subject	Repo	Branch	Lines +/-
Use getImageNodes instead of custom filter	mediawiki/extensions/VisualEditor	master	+1 -3
GalleryContextItem: Only count image node children	mediawiki/extensions/VisualEditor	REL1_38	+1 -1
GalleryContextItem: Only count image node children	mediawiki/extensions/VisualEditor	REL1_39	+1 -1
GalleryContextItem: Only count image node children	mediawiki/extensions/VisualEditor	master	+3 -1
GalleryContextItem: Only count image node children	mediawiki/extensions/VisualEditor	REL1_35	+1 -1

Customize query in gerrit

Event Timeline

• Whatamidoing-WMF created this task.Oct 15 2022, 7:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 15 2022, 7:46 PM

Maintenance_bot added a project: VisualEditor.Oct 15 2022, 8:29 PM

Actually, the "steps to reproduce" are probably just:

Open the page in the visual editor.
Click on the gallery.

https://en.wikivoyage.org/wiki/Switzerland has the count wrong:

Screen Shot 2022-10-15 at 12.54.15 PM.png (618×2 px, 674 KB)

This does not appear in most pages, including https://en.wikivoyage.org/wiki/Warsaw or https://en.wikivoyage.org/wiki/Kyushu#Eat

The problem is we are including the caption node in the count.

Change 842945 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] GalleryContextItem: Only count image node children

https://gerrit.wikimedia.org/r/842945

gerritbot added a project: Patch-For-Review.Oct 15 2022, 11:05 PM

Esanders claimed this task.Oct 16 2022, 11:27 AM

Esanders moved this task from To Triage to Triaged on the VisualEditor board.

Esanders added a project: Editing-team (Kanban Board).

Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

Change 842945 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] GalleryContextItem: Only count image node children

https://gerrit.wikimedia.org/r/842945

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.6; 2022-10-17).Oct 17 2022, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 17 2022, 3:30 PM

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Oct 17 2022, 4:15 PM

matmarex added a project: Editing QA.

EAkinloose edited projects, added Verified; removed Editing QA.Oct 20 2022, 4:21 AM

EAkinloose moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.

EAkinloose moved this task from Blocked / Needs More Work to Ready for Sign Off on the Editing-team (Kanban Board) board.Oct 20 2022, 5:29 AM

ppelberg closed this task as Resolved.Oct 20 2022, 5:09 PM

Change 880436 had a related patch set uploaded (by WgevaertWikiBase; author: WgevaertWikiBase):

[mediawiki/extensions/VisualEditor@REL1_35] GalleryContextItem: Only count image node children

https://gerrit.wikimedia.org/r/880436

gerritbot added a project: Patch-For-Review.Jan 16 2023, 10:52 AM

Change 880436 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@REL1_35] GalleryContextItem: Only count image node children

https://gerrit.wikimedia.org/r/880436

Maintenance_bot removed a project: Patch-For-Review.Jan 16 2023, 8:30 PM

Change 881395 had a related patch set uploaded (by WgevaertWikiBase; author: WgevaertWikiBase):

[mediawiki/extensions/VisualEditor@master] Use getImageNodes instead of custom filter

https://gerrit.wikimedia.org/r/881395

gerritbot added a project: Patch-For-Review.Jan 18 2023, 12:43 PM

Change 881397 had a related patch set uploaded (by WgevaertWikiBase; author: WgevaertWikiBase):

[mediawiki/extensions/VisualEditor@REL1_38] GalleryContextItem: Only count image node children

https://gerrit.wikimedia.org/r/881397

Change 881398 had a related patch set uploaded (by WgevaertWikiBase; author: WgevaertWikiBase):

[mediawiki/extensions/VisualEditor@REL1_39] GalleryContextItem: Only count image node children

https://gerrit.wikimedia.org/r/881398

Change 881398 merged by jenkins-bot: