Page MenuHomePhabricator
Create Task
Maniphest T286992

Deploy VE template dialog improvements to small set of wikis
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Deploy all changes implemented behind a feature flag together with:

Deploy to small default wikis:

Deployment date: November 24 2021

Details

SubjectRepoBranchLines +/-
VisualEditor template dialog: new sidebar and inline descriptionsoperations/mediawiki-configmaster+28 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedWMDE-FischT306967 Deploy VE template dialog improvements to enwiki
 ResolvedLena_WMDET296759 Deploy VE template dialog improvements to more wikis
 ResolvedLena_WMDET286992 Deploy VE template dialog improvements to small set of wikis
 ResolvedWMDE-FischT272487 New input for undocumented parameters
 ResolvedWMDE-FischT272482 Show/hide advanced toolbar when multi-part content is present
 ResolvedECohen_WMDET272368 Add checkboxes to param list sidebar in VE TemplateDialog
 ResolvedWMDE-FischT274542 Fork / subclass / include variations in BookletLayout for new VisualEditor template dialog
 ResolvedawightT274539 Implement new VisualEditor template dialog enhanced sidebar feature flag
 DeclinedNoneT274541 Adapt VisualEditor template dialog code to reduce duplication after fork
 ResolvedNoneT274548 VisualEditor template "required" parameter handling
 InvalidNoneT274549 Handle "no parameter" templates
 ResolvedthiemowmdeT274551 "deprecated" parameter handling
 Resolvedlilients_WMDET274552 Synchronize scroll and focus between content and outline panes
 InvalidNoneT274546 Maintain order of checkboxes and content
 ResolvedthiemowmdeT288202 Parameter search also filters main content area
 ResolvedAndrew-WMDET274554 Make sidebar responsive
 ResolvedAndrew-WMDET275761 Remove the trash icons which show next to the parameter name when it's "in focus"
 ResolvedNoneT274547 Handle checkbox clicks in VisualEditor template dialog sidebar
 ResolvedNoneT272481 Add parameter search to sidebar of VE TemplateDialog
 ResolvedthiemowmdeT274544 Support multiple transclusions (i.e. templates) in the new template dialog sidebar
 ResolvedAndrew-WMDET274550 Handle undocumented template parameters
 ResolvedWMDE-FischT274545 Wire template parameters into the checkbox list view
 ResolvedLena_WMDET274538 Design new VisualEditor template dialog data model and data propagation
 ResolvedNoneT276325 Review proof-of-concept VE template dialog sidebar code
 ResolvedawightT274543 Create a new checkbox list view for the VisualEditor template dialog
 ResolvedAndrew-WMDET285044 Fix parameter sidebar overflowing text ellipsis
 InvalidNoneT285289 Sidebar containers should receive initial parameters through regular add events
 ResolvedthiemowmdeT285382 Preserve parameter serialization order
 ResolvedawightT216808 VE shuffles the order of template parameters in template dialog
 ResolvedBUG REPORTWMDE-FischT285843 Search input field contains parameter with alias twice after deleting it
ResolvedBUG REPORTthiemowmdeT285940 Template parameter search: partial match blocks adding undocumented parameter
 ResolvedBUG REPORTthiemowmdeT286715 Sidebars overlap after adding undocumented parameters
 ResolvedWMDE-FischT286765 Prepare sidebar feature for deploy on beta and deploy on beta
 DuplicateBUG REPORTNoneT287384 Pathological duplicate aliases could be displayed in sidebar menu
 ResolvedECohen_WMDET285869 Add error handling for the undocumented parameter input
 InvalidNoneT291059 [DRAFT] Adjust messages for special alias edge cases
 ResolvedWMDE-FischT291061 Manual testing on mobile & desktop
 ResolvedWMDE-FischT291241 Ensure changes to VE template dialog are working in VE citation dialog

Event Timeline

Lena_WMDE created this task.Jul 20 2021, 9:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 20 2021, 9:19 AM
Lena_WMDE added subtasks: T272368: Add checkboxes to param list sidebar in VE TemplateDialog, T272487: New input for undocumented parameters, T272482: Show/hide advanced toolbar when multi-part content is present, T272481: Add parameter search to sidebar of VE TemplateDialog.Jul 20 2021, 9:22 AM
Lena_WMDE moved this task from Backlog to In preparation on the WMDE-Templates-FocusArea board.
• matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jul 29 2021, 2:59 PM
thiemowmde closed subtask T272482: Show/hide advanced toolbar when multi-part content is present as Resolved.Aug 31 2021, 8:44 AM
thiemowmde closed subtask T272487: New input for undocumented parameters as Resolved.Aug 31 2021, 8:52 AM
ECohen_WMDE reopened subtask T272487: New input for undocumented parameters as Open.Aug 31 2021, 8:53 AM
• Timur_Vorkul_WMDE updated the task description. (Show Details)Sep 1 2021, 1:08 PM
Masssly added a project: Dagbani-Sites.Sep 6 2021, 4:50 PM
thiemowmde closed subtask T272487: New input for undocumented parameters as Resolved.Sep 14 2021, 9:06 AM
Lena_WMDE added a subtask: T291061: Manual testing on mobile & desktop.Sep 15 2021, 8:38 AM
Lena_WMDE added a subtask: T291241: Ensure changes to VE template dialog are working in VE citation dialog.Sep 17 2021, 8:44 AM
WMDE-Fisch closed subtask T291241: Ensure changes to VE template dialog are working in VE citation dialog as Resolved.Oct 12 2021, 8:15 AM
awight closed subtask T291061: Manual testing on mobile & desktop as Resolved.Oct 13 2021, 10:14 AM
Lena_WMDE updated the task description. (Show Details)Nov 5 2021, 9:40 AM
Lena_WMDE updated the task description. (Show Details)Nov 10 2021, 10:54 AM
Lena_WMDE moved this task from In preparation to Ready for pickup on the WMDE-Templates-FocusArea board.
Lena_WMDE added a project: WMDE-TechWish-Sprint-2021-11-10.
Lena_WMDE moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.Nov 10 2021, 11:01 AM
thiemowmde set the point value for this task to 2.Nov 10 2021, 11:20 AM
Quiddity added a project: User-notice.Nov 18 2021, 7:44 PM
Quiddity subscribed.

Hi, regarding the entry in Tech News -

  1. I just wanted to confirm that this will definitely be released on November 24? I know that the deployment-train is not running that/next week, but perhaps this change is being rolled out separately?
  2. Regarding the wording, I've rewritten it to embed the links within the content, and hopefully clarified it appropriately. Please edit that if needed, before this time tomorrow. Thanks!
Quiddity moved this task from To Triage to In current Tech/News draft on the User-notice board.Nov 18 2021, 7:49 PM
JStrodt_WMDE subscribed.Nov 19 2021, 10:52 AM

Thanks, @Quiddity!

  1. Yes, the deployment will happen via config change, independently of the train.
  2. Thanks for the rewrite. Looks good.
ECohen_WMDE closed subtask T272368: Add checkboxes to param list sidebar in VE TemplateDialog as Resolved.Nov 19 2021, 4:09 PM
Tacsipacsi updated the task description. (Show Details)Nov 20 2021, 6:33 PM
Tacsipacsi subscribed.
awight subscribed.Nov 22 2021, 12:23 PM

@JStrodt_WMDE @Lena_WMDE @Quiddity Wednesday's deployment is in jeopardy due to a production bug T296098, which caused the train to be rolled back last week. We can either wait to see whether the bug is fixed and the train released, or we can postpone until next week.

awight changed the task status from Open to Stalled.Nov 22 2021, 12:24 PM
awight moved this task from Sprint Backlog to Watching (Stalled / Epic) on the WMDE-TechWish-Sprint-2021-11-10 board.
Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Nov 22 2021, 2:02 PM
Johan moved this task from Already announced/Archive to In current Tech/News draft on the User-notice board.
Johan subscribed.

@awight For Tech News purposes, it would be good to know today – @Quiddity will deliver the newsletter in a few hours.

awight changed the task status from Stalled to Open.Nov 22 2021, 7:17 PM
awight moved this task from Watching (Stalled / Epic) to UX/PM Review on the WMDE-TechWish-Sprint-2021-11-10 board.
awight moved this task from UX/PM Review to Doing on the WMDE-TechWish-Sprint-2021-11-10 board.
awight moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Sprint-2021-11-10 board.
In T286992#7520249, @Johan wrote:

@awight For Tech News purposes, it would be good to know today – @Quiddity will deliver the newsletter in a few hours.

We're back on track to deploy this week!

gerritbot added a comment.Nov 23 2021, 7:44 AM

Change 740766 had a related patch set uploaded (by Awight; author: Awight):

[operations/mediawiki-config@master] VisualEditor template dialog: new sidebar and inline descriptions

https://gerrit.wikimedia.org/r/740766

gerritbot added a project: Patch-For-Review.Nov 23 2021, 7:44 AM
Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Nov 23 2021, 11:14 AM
gerritbot added a comment.Nov 24 2021, 12:03 PM

Change 740766 merged by jenkins-bot:

[operations/mediawiki-config@master] VisualEditor template dialog: new sidebar and inline descriptions

https://gerrit.wikimedia.org/r/740766

Stashbot added a comment.Nov 24 2021, 12:10 PM

Mentioned in SAL (#wikimedia-operations) [2021-11-24T12:10:05Z] <awight@deploy1002> Synchronized wmf-config: Config: [[gerrit:740766|VisualEditor template dialog: new sidebar and inline descriptions (T284203, T286992)]] (duration: 00m 57s)

Stashbot mentioned this in T284203: Deploy inline descriptions, extended sidebar and bigger dialog to small set of wikis.Nov 24 2021, 12:10 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 24 2021, 12:10 PM
awight moved this task from Sprint Backlog to Done on the WMDE-TechWish-Sprint-2021-11-10 board.Nov 24 2021, 12:11 PM
Lena_WMDE mentioned this in T292980: VE template dialog improvements: Cursor focus.Nov 30 2021, 5:02 PM
Lena_WMDE added a parent task: T296759: Deploy VE template dialog improvements to more wikis.Nov 30 2021, 5:04 PM
FriedrickMILBarbarossa added a project: Turkish-Sites.Dec 30 2021, 2:56 PM
awight updated the task description. (Show Details)Jan 4 2022, 1:58 PM
Lena_WMDE closed this task as Resolved.Jan 7 2022, 11:54 AM
Lena_WMDE claimed this task.
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits