Seen on 1.37.0-wmf.6, currently at group0:
Still fine on en.wikipedia.org and test2.wikipedia.org (1.37.0-wmf.5),
e.g. https://test2.wikipedia.org/wiki/Main_Page
Krinkle | |
May 19 2021, 10:38 PM |
F34462818: Screen Shot 2021-05-21 at 9.40.46 AM.png | |
May 21 2021, 1:45 PM |
F34462238: image.png | |
May 20 2021, 8:44 PM |
F34460536: Screenshot 2021-05-19 at 23.38.44.png | |
May 19 2021, 10:38 PM |
Seen on 1.37.0-wmf.6, currently at group0:
Still fine on en.wikipedia.org and test2.wikipedia.org (1.37.0-wmf.5),
e.g. https://test2.wikipedia.org/wiki/Main_Page
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Introduce the vector-body class | mediawiki/skins/Vector | wmf/1.37.0-wmf.6 | +15 -16 | |
Introduce the vector-body class | mediawiki/skins/Vector | master | +15 -16 |
Hi @Iniquity, Many thanks for merging and tbh thank you for restoring my faith in Phab!. Good to know I'm not going mad (although trying to convince people I actually had a problem was beginning to drive me clinically insane!)
FWIW, I am seeing large category text in "Legacy Vector", in case the above description is ambiguous.
Change 693237 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/Vector@master] Introduce the vector-body class
https://gerrit.wikimedia.org/r/693237
Yep. Facepalm. Easily explained and fixed: https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/693237
Will make sure this goes out ASAP.
Hotfix for the coordinates issue reported in T283286 (to be put in MediaWiki:Vector.css):
#bodyContent { position: relative; z-index: 0; } .mw-body-content { position: initial; }
Please note that this is not intended to be future-proof and should be removed as soon as the Gerrit patch is deployed.
I'm assuming the attached screenshot from https://en.wikipedia.org/wiki/Wikipedia:Deletion_review/Log/2021_May_10#Category:CS1_maint:_discouraged_parameter is another example of the same issue.
BTW: this is unaffected by the "Use Legacy Vector" option in Preferences/Appearance.
We noticed also the large category size (16px) on the French Wikisource, and another (more important) problem seems related, hence I report it here: the transcluded text (example) is now 576px large and not 504px any more (it still is 504px in other skins). The reason is apparently that the 36em width is set at the #text-container div, where the font size is 16px, then this font size is reduced to 14px at a lower level (mw-body-content class, which is located on the #mw-context div).
In other modes (e.g. Previsualization), the mw-body-content `class is set at a higher level, so that the 36em width is computed when the font size is already 14px (hence the width is 504px and not 576px).
I hope that this problem will be fixed by the patch mentioned here.
EDIT: this problem has been fixed by the patch. Thank you!
Change 693237 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Introduce the vector-body class
https://gerrit.wikimedia.org/r/693237
Change 693653 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/Vector@wmf/1.37.0-wmf.6] Introduce the vector-body class
https://gerrit.wikimedia.org/r/693653
Change 693653 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.37.0-wmf.6] Introduce the vector-body class
https://gerrit.wikimedia.org/r/693653
Mentioned in SAL (#wikimedia-operations) [2021-05-24T18:29:35Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.6/skins/Vector/: 1742532687b: Introduce the vector-body class (T283206) (duration: 00m 57s)
This patch looks like it has been ready to deploy for two days. What is the holdup?
There are no deploys on Friday, Saturdays, and Sundays.
If we had more group 1 wikis in the Wednesday deployment (especially larger ones in terms of page views) it would help prioritize these sorts of problems earlier before and get them more likely to be fixed before the weekend begins. If your project is interested, please let me know here.
Thanks for the explanation. When I worked in IT, we never deployed any changes on days prior to days when changes could not be made, i.e. we never deployed on Friday because we didn't want to come in on the weekend. If the normal deployment schedule was Mon/Tues/Wed, then rollbacks and urgent patches like this one could be addressed on Thu/Fri.