Page MenuHomePhabricator
Create Task
Maniphest T255319

Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal
Closed, ResolvedPublic
Actions

Assigned To
• Mabualruz
Authored By
Jdlrobson
Jun 12 2020, 9:35 PM
Tags
Referenced Files
None
Subscribers
Aklapper
Ammarpad
AndyRussG
Jdlrobson
Krinkle
Ladsgroup
• Mabualruz
View All 11 Subscribers
Tokens
"Like" token, awarded by Jdlrobson.

Description

The web team would like to simplify the code for menu generation in MediaWiki core. To make this easier we would like to reduce the number of hooks that can modify menus to one single hook: SkinTemplateNavigation::Universal.

Background

Every time the SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks are run we also run the SkinTemplateNavigation::Universal hook. The latter is always run based on the current page. We could just run the latter and get rid of 2 needless hooks.

Proposal:

Having 3 hooks doing pretty much the same thing seems gratutious. I would suggest standardizing on SkinTemplateNavigation::Universal and for the hooks themselves to do the required checks they need. I am however open to keeping all three after hearing from the current extensions using these hooks (tagged) and benefits they see in having three of them.

The SkinTemplateNavigation hook is deprecated in favor of SkinTemplateNavigation::Universal . It's up to callers to check whether the title exists if they care.
The SkinTemplateNavigation::SpecialPage is deprecated in favor of SkinTemplateNavigation::Universal. Callers must use $skin->getTitle() to check whether the page is a special page

TODO

  • Update Extension:CentralNotice to use SkinTemplateNavigation::Universal instead of SkinTemplateNavigation::SpecialPage
  • Update Extension:VisualEditor to use SkinTemplateNavigation::Universal instead of SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation::Universal instead of SkinTemplateNavigation
  • Update Extension:Translate to use SkinTemplateNavigation::Universal instead of SkinTemplateNavigation::SpecialPage
  • Update Extension:GrowthExperiments to use SkinTemplateNavigation::Universal instead of SkinTemplateNavigation
  • Update Extension:LiquidThreads to use SkinTemplateNavigation::Universal instead of SkinTemplateNavigation
  • Update Extension:MassMessage to use SkinTemplateNavigation::Universal instead of SkinTemplateNavigation
  • Update Extension:Wikilove to use SkinTemplateNavigation::Universal instead of SkinTemplateNavigation
  • SkinTemplateNavigation::SpecialPage in core is marked as deprecated
  • SkinTemplateNavigation in core is marked as deprecated

QA

Sign off steps

  • Removal of this code impacts 3rd parties, however for now we are only concerned with fixing deployed Wikimedia code. Removing code will be created in a separate ticket.

https://codesearch.wmcloud.org/search/?q=SkinTemplateNavigation%3A%3ASpecialPage&i=nope&files=&excludeFiles=&repos=
https://codesearch.wmcloud.org/search/?q=SkinTemplateNavigation%22%3A&i=nope&files=&excludeFiles=&repos=

Fixed

Extensions/skins that are fixed are listed here and have been untagged.

Details

SubjectRepoBranchLines +/-
Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universalmediawiki/coremaster+20 -1
Deprecate SkinTemplateNavigation hook in favour of SkinTemplateNavigation::Universalmediawiki/extensions/PageFormsmaster+1 -1
Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universalmediawiki/extensions/Translatemaster+11 -5
Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universalmediawiki/extensions/CentralNoticemaster+2 -2
Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universalmediawiki/extensions/Cargomaster+1 -1
Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universalmediawiki/extensions/WikiLovemaster+1 -1
Use SkinTemplateNavigation::Universalmediawiki/extensions/VisualEditormaster+5 -3
Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universalmediawiki/extensions/GrowthExperimentsmaster+7 -6
Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universalmediawiki/extensions/LiquidThreadsmaster+1 -1
Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universalmediawiki/extensions/VisualEditormaster+5 -3
Use SkinTemplateNavigation::Universal instead of SkinTemplateNavigationmediawiki/extensions/EntitySchemamaster+2 -2
Use the SkinTemplateNavigation::Universal hookmediawiki/extensions/ProofreadPagemaster+3 -3
Replace usage of deprecated SkinTemplateNavigation hookmediawiki/extensions/Newslettermaster+2 -2
Replace usage of deprecated SkinTemplateNavigation hookmediawiki/extensions/BlueSpicePageAssignmentsmaster+5 -5
Replace usage of deprecated SkinTemplateNavigation hookmediawiki/extensions/BlueSpicePageAssignmentsREL1_35+5 -5
Use SkinTemplateNavigation::UniversalHookmediawiki/extensions/TimedMediaHandlermaster+1 -1
Replace usage of deprecated SkinTemplateNavigation hookmediawiki/extensions/AdvancedMetamaster+9 -9
Replace usage of deprecated SkinTemplateNavigation hookmediawiki/extensions/AdvancedMetaREL1_35+9 -9
Replace usage of deprecated SkinTemplateNavigation hookmediawiki/extensions/FlaggedRevsREL1_35+2 -2
Replace usage of deprecated SkinTemplateNavigation hookmediawiki/extensions/BlueSpiceRemindermaster+5 -5
Replace usage of deprecated SkinTemplateNavigation hookmediawiki/extensions/BlueSpiceExpirymaster+6 -13
Replace usage of deprecated SkinTemplateNavigation hookmediawiki/extensions/FlaggedRevsmaster+2 -2
Replace usage of deprecated SkinTemplateNavigation hookmediawiki/extensions/NSFileRepoREL1_35+2 -2
Replace usage of deprecated SkinTemplateNavigation hookmediawiki/extensions/NSFileRepomaster+2 -2
Replace usage of deprecated SkinTemplateNavigation hookmediawiki/extensions/BlueSpiceReadersmaster+8 -5
Replace usage of deprecated SkinTemplateNavigation hookmediawiki/extensions/BlueSpiceInsertCategorymaster+7 -6
Replace usage of deprecated SkinTemplateNavigation hookmediawiki/extensions/BlueSpiceBookshelfmaster+5 -5
Replace usage of deprecated SkinTemplateNavigation hookmediawiki/extensions/BlueSpiceReadersREL1_35+8 -5
Replace usage of deprecated SkinTemplateNavigation hookmediawiki/extensions/BlueSpiceExpiryREL1_35+6 -13
Replace usage of deprecated SkinTemplateNavigation hookmediawiki/extensions/BlueSpiceInsertCategoryREL1_35+7 -6
Replace usage of deprecated SkinTemplateNavigation hookmediawiki/extensions/BlueSpiceBookshelfREL1_35+5 -5
Replace usage of deprecated SkinTemplateNavigation hookmediawiki/extensions/BlueSpiceReminderREL1_35+5 -5
Favor SkinTemplateNavigation::Universalmediawiki/skins/Vectormaster+5 -2
Stop using the SkinTemplateNavigation::SpecialPage hook in favor of the SkinTemplateNavigation::Universal hookmediawiki/extensions/FileExportermaster+62 -45
Stop using the SkinTemplateNavigation::SpecialPage hook in favor of the SkinTemplateNavigation::Universal hookmediawiki/extensions/QuizGamemaster+6 -4
Stop using the SkinTemplateNavigation::SpecialPage hook in favor of the SkinTemplateNavigation::Universal hookmediawiki/extensions/PictureGamemaster+3 -3
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
aoxomoxoa updated the task description. (Show Details)Nov 19 2020, 4:45 PM
• Rileych added a project: Technical-Debt.Dec 21 2020, 3:36 PM
Jdlrobson updated the task description. (Show Details)Jan 16 2021, 12:19 AM
ashley removed a project: Social-Tools.Apr 13 2021, 9:05 AM
Restricted Application added a project: [DEPRECATED] wdwb-tech. · View Herald TranscriptApr 13 2021, 9:05 AM
Addshore mentioned this in T280164: Stop using SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal.Apr 14 2021, 4:39 PM
Addshore moved this task from Inbox to External Realm on the [DEPRECATED] wdwb-tech board.
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:48 PM
Ladsgroup removed a project: Jade.Apr 29 2021, 11:58 AM
Ladsgroup subscribed.

Jade is undeployed: T281418: Undeploy JADE extension from beta cluster

Addshore closed subtask T280164: Stop using SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal as Resolved.May 12 2021, 10:07 AM
Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.May 24 2021, 11:21 AM
Soda mentioned this in T274350: ProofreadPage source tab not shown in the Minerva skin.Jun 8 2021, 6:54 AM
Jdlrobson moved this task from It's complicated to 1.37 release on the MediaWiki-Core-Skin-Architecture board.Jul 13 2021, 11:47 PM
Jdlrobson moved this task from 1.37 release to 1.38 deprecations on the MediaWiki-Core-Skin-Architecture board.Aug 2 2021, 11:51 PM
gerritbot added a comment.Aug 20 2021, 10:35 PM

Change 714139 had a related patch set uploaded (by Inductiveload; author: Inductiveload):

[mediawiki/extensions/ProofreadPage@master] Use the SkinTemplateNavigation::Universal hook

https://gerrit.wikimedia.org/r/714139

gerritbot added a comment.Aug 21 2021, 6:22 AM

Change 714139 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Use the SkinTemplateNavigation::Universal hook

https://gerrit.wikimedia.org/r/714139

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Aug 21 2021, 7:00 AM
Jdlrobson removed a project: ProofreadPage.Aug 23 2021, 6:28 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from 1.38 deprecations to Deprecations and removals on the MediaWiki-Core-Skin-Architecture board.Oct 8 2021, 2:47 PM
Nikerabbit moved this task from Backlog to Maintenance on the MassMessage board.Jan 26 2022, 9:21 AM
Jdlrobson renamed this task from Eventually deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal to Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal .May 24 2022, 10:14 PM
Jdlrobson raised the priority of this task from Low to Medium.
Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2021-22).
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.May 24 2022, 10:18 PM
gerritbot added a comment.May 24 2022, 10:21 PM

Change 799000 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/VisualEditor@master] Use SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/799000

Jdlrobson added projects: patch-welcome, good first task.May 24 2022, 10:22 PM
Jdlrobson added a subscriber: Esanders.

@Esanders - requesting editing team review on https://gerrit.wikimedia.org/r/799000. No urgency, but aiming to complete this work during the 1.39 release. Let me know if you have any concerns.

• Mabualruz claimed this task.Jun 7 2022, 2:15 PM
• Mabualruz moved this task from Upcoming to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 7 2022, 2:18 PM
Jdlrobson added a comment.EditedJun 7 2022, 5:58 PM

Chatted to @Mabualruz today I advised as a starting point that he focus on SkinTemplateNavigation::SpecialPages.

Work on these bullet points and move this task to "blocked on others":

  • Update Extension:CentralNotice to use SkinTemplateNavigation::Universal instead of SkinTemplateNavigation::SpecialPage
  • Update Extension:VisualEditor to use SkinTemplateNavigation::Universal instead of SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation::Universal instead of SkinTemplateNavigation
  • Update Extension:Translate to use SkinTemplateNavigation::Universal instead of SkinTemplateNavigation::SpecialPage
  • SkinTemplateNavigation::SpecialPage in core is marked as deprecated - add Depends-On in commit message to all 3 patches above.

@Nikerabbit, @AndyRussG , @Esanders as a heads up we'll need support from you over the next 2 weeks.

I've reached out to identify helpers for Wikilove, EntitySchema, GrowthExperiments,MassMessage and LiquidThreads.

Jdlrobson added subscribers: AndyRussG, Nikerabbit.Jun 7 2022, 6:04 PM
gerritbot added a comment.Jun 8 2022, 10:06 AM

Change 803880 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/EntitySchema@master] Use SkinTemplateNavigation::Universal instead of SkinTemplateNavigation

https://gerrit.wikimedia.org/r/803880

gerritbot added a comment.Jun 8 2022, 11:18 AM

Change 803880 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Use SkinTemplateNavigation::Universal instead of SkinTemplateNavigation

https://gerrit.wikimedia.org/r/803880

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jun 8 2022, 11:36 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.16; 2022-06-13).Jun 8 2022, 12:00 PM
gerritbot added a comment.Jun 22 2022, 3:13 PM

Change 807568 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/core@master] Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/807568

gerritbot added a comment.Jun 22 2022, 3:18 PM

Change 807570 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/extensions/Cargo@master] Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/807570

gerritbot added a comment.Jun 22 2022, 3:20 PM

Change 807571 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/extensions/CentralNotice@master] Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/807571

gerritbot added a comment.Jun 22 2022, 3:21 PM

Change 807572 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/extensions/GrowthExperiments@master] Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/807572

gerritbot added a comment.Jun 22 2022, 3:23 PM

Change 807573 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/extensions/LiquidThreads@master] Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/807573

gerritbot added a comment.Jun 22 2022, 3:24 PM

Change 807574 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/extensions/MassMessage@master] Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/807574

gerritbot added a comment.Jun 22 2022, 3:26 PM

Change 807575 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/extensions/Translate@master] Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/807575

gerritbot added a comment.Jun 22 2022, 3:27 PM

Change 807577 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/extensions/WikiLove@master] Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/807577

gerritbot added a comment.Jun 22 2022, 3:29 PM

Change 807578 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/extensions/VisualEditor@master] Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/807578

kostajh updated the task description. (Show Details)Jun 22 2022, 3:49 PM
gerritbot added a comment.Jun 22 2022, 4:00 PM

Change 807578 abandoned by Mabualruz:

[mediawiki/extensions/VisualEditor@master] Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal

Reason:

https://gerrit.wikimedia.org/r/807578

Jdlrobson removed • Mabualruz as the assignee of this task.Jun 22 2022, 4:06 PM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson added a subscriber: • Mabualruz.
Jdlrobson claimed this task.Jun 22 2022, 4:37 PM
gerritbot added a comment.Jun 22 2022, 8:11 PM

Change 807573 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/807573

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.18; 2022-06-27); removed MW-1.39-notes (1.39.0-wmf.16; 2022-06-13).Jun 22 2022, 9:00 PM
gerritbot added a comment.Jun 22 2022, 10:28 PM

Change 807572 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/807572

gerritbot added a comment.Jun 22 2022, 10:57 PM

Change 799000 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Use SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/799000

gerritbot added a comment.Jun 22 2022, 11:06 PM

Change 807577 merged by jenkins-bot:

[mediawiki/extensions/WikiLove@master] Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/807577

Jdlrobson reassigned this task from Jdlrobson to AndyRussG.EditedJun 23 2022, 12:10 AM
Jdlrobson moved this task from Code Review to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

This is blocked on several patches now. I've listed them here with who I think might be able to help us:

If any of you would prefer web team to review these (with a little added risk due to unfamiliarity with the code) please let me know.

Please

gerritbot added a comment.Jun 23 2022, 5:55 PM

Change 807570 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/807570

gerritbot added a comment.Jun 24 2022, 3:45 AM

Change 807571 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/807571

Jdlrobson removed AndyRussG as the assignee of this task.Jun 24 2022, 2:36 PM
Jdlrobson moved this task from Blocked on Others to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
• Mabualruz moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 26 2022, 9:19 AM
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 27 2022, 3:42 PM
• Mabualruz claimed this task.Jun 28 2022, 3:17 PM
• Mabualruz moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Esanders unsubscribed.Jun 28 2022, 3:53 PM
• Mabualruz removed • Mabualruz as the assignee of this task.Jun 28 2022, 5:18 PM
Jdlrobson claimed this task.Jun 28 2022, 5:18 PM

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/807575

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 28 2022, 10:37 PM
Jdlrobson moved this task from Needs More Work to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 30 2022, 9:14 PM
Jdlrobson moved this task from Blocked on Others to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/807568 needs more work (isn't working as expected). Would be great to wrap this up tomorrow so it doesn't get carried over to next quarter.
I've reached out to language team for review on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/807575

gerritbot added a comment.Jul 1 2022, 9:20 AM

Change 807575 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/807575

Jdlrobson reassigned this task from Jdlrobson to • Mabualruz.Jul 1 2022, 2:53 PM

Almost there: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/807568

Jdlrobson mentioned this in T311944: Meta talkpages for Central Notice banners turned into banner overview pages from the admin interface.Jul 5 2022, 4:06 PM
Jdlrobson updated the task description. (Show Details)Jul 5 2022, 4:16 PM
gerritbot added a comment.Jul 5 2022, 4:47 PM

Change 811339 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable title above tabs everywhere

https://gerrit.wikimedia.org/r/811339

Jdlrobson moved this task from Needs More Work to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jul 5 2022, 5:02 PM
gerritbot added a comment.Jul 5 2022, 5:15 PM

Change 807568 merged by jenkins-bot:

[mediawiki/core@master] Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/807568

gerritbot added a comment.Jul 5 2022, 5:34 PM

Change 811345 had a related patch set uploaded (by Techwizzie; author: Techwizzie):

[mediawiki/extensions/PageForms@master] Deprecate SkinTemplateNavigation hook in favour of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/811345

gerritbot added a comment.Jul 5 2022, 5:40 PM

Change 811345 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Deprecate SkinTemplateNavigation hook in favour of SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/811345

Jdlrobson closed this task as Resolved.Jul 5 2022, 5:52 PM
Jdlrobson added a comment.Jul 5 2022, 5:58 PM

Thanks, everyone for your assistance with this one! It's much appreciated!

Jdlrobson mentioned this in T312145: MassMessage using deprecated hook to add link to EditMassMessageList in sidebar.Jul 5 2022, 6:01 PM
Jdlrobson mentioned this in T312149: [1.40 release] Remove SkinTemplateNavigation and SkinTemplateNavigation::SpecialPage hooks.Jul 5 2022, 6:11 PM
Jdlrobson updated the task description. (Show Details)

(Follow up tasks created)

Tacsipacsi removed a project: Patch-For-Review.Jul 6 2022, 4:25 PM
Tacsipacsi subscribed.
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.21; 2022-07-18); removed MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jul 11 2022, 11:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits