Maniphest T252094

ApiQueryContentTranslation: Call to a member function getName() on null
Closed, ResolvedPublic
Actions

Description

Observed in a logstash:

Branch: php-1.35.0-wmf.31 (testwiki)

User impact: unknown

Log messages:

[670f6482-b077-4e84-9801-1c96d03e57f5] /w/api.php?action=query&format=json&list=contenttranslation&sourcetitle=Lockdown&from=en&to=pt   Error from line 165 of /srv/mediawiki/php-1.35.0-wmf.31/extensions/ContentTranslation/api/ApiQueryContentTranslation.php: Call to a member function getName() on null

/srv/mediawiki/php-1.35.0-wmf.31/extensions/ContentTranslation/api/ApiQueryContentTranslation.php(69): ApiQueryContentTranslation->find(ContentTranslation\TranslationWork, ContentTranslation\Translator)
#1 /srv/mediawiki/php-1.35.0-wmf.31/extensions/ContentTranslation/api/ApiQueryContentTranslation.php(25): ApiQueryContentTranslation->run()
#2 /srv/mediawiki/php-1.35.0-wmf.31/includes/api/ApiQuery.php(263): ApiQueryContentTranslation->execute()
#3 /srv/mediawiki/php-1.35.0-wmf.31/includes/api/ApiMain.php(1580): ApiQuery->execute()
#4 /srv/mediawiki/php-1.35.0-wmf.31/includes/api/ApiMain.php(523): ApiMain->executeAction()
#5 /srv/mediawiki/php-1.35.0-wmf.31/includes/api/ApiMain.php(494): ApiMain->executeActionWithErrorHandling()
#6 /srv/mediawiki/php-1.35.0-wmf.31/api.php(84): ApiMain->execute()
#7 /srv/mediawiki/w/api.php(3): require(string)
#8 {main}

Summary: Fixed CX to handle the case when another user tried to translate an article which is being translated by an unknown user

QA plan

Affected project: test.wikipedia.org
Pre-deployment testing: skip
Post-deployment testing:

Try to translate article Lockdown from en to pt on test.wikipedia.org
Monitor Logstash for 7 days after deployment to confirm error is gone

Outcome

Content Translation gracefully handles an edge case when trying to translate a page which is already being translated by another, unknown user

Details

	Subject	Repo	Branch	Lines +/-
	ApiQueryContentTranslation: avoid fatals on getName	mediawiki/extensions/ContentTranslation	master	+29 -16

Customize query in gerrit

Related Objects

Duplicates Merged Here: T204886: ContentTranslation API some queries fail (Call to getName() on a non-object in ApiQueryContentTranslation.php)

Event Timeline

KartikMistry created this task.May 7 2020, 4:45 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2020, 4:45 AM

This is in the code path that is showing "this translation is work in progress by user X", where we cannot identify who is X, likely due to earlier database corruption (due to code issue, not data reliability issue).

// Add name and gender information to the returned result. The UI can use this
// to display the conflict message.
$globalUserId = $translation->getData()['lastUpdatedTranslator'];
$centralIdLookup = CentralIdLookup::factory();
// $user can be null, but should never happen in our case because
// we redirect translators to the target wiki, and they cannot do
// translations without logging in.
$user = $centralIdLookup->localUserFromCentralId( $globalUserId );
$gender = $services->getGenderCache()->getGenderOf( $user, __METHOD__ );

$translation->translation['translatorName'] = $user->getName(); // Fails on this line
$translation->translation['translatorGender'] = $gender;

• Nikerabbit added a project: Wikimedia-production-error.May 7 2020, 7:33 AM

localUserFromCentralId() can return null if the context user does not have permission to see the user returned by the method.
The doc here seems to not consider this case and just assume since the 'lastUpdatedTranslator' must have done some translations then they'll always be returned by localUserFromCentralId() for everybody. In this case, probably the username of the translator is hidden and so, even though they satisfy the doc assumption here (by being registered+done some trans), null is still returned due to the restriction on viewing the user.

// $user can be null, but should never happen in our case because
// we redirect translators to the target wiki, and they cannot do
// translations without logging in.

Krinkle moved this task from Untriaged to May 2020 on the Wikimedia-production-error board.May 11 2020, 6:52 PM

Krinkle added a project: Language-Team.

• Nikerabbit moved this task from May 2020 to Older on the Wikimedia-production-error board.May 12 2020, 11:37 AM

• Nikerabbit merged a task: T204886: ContentTranslation API some queries fail (Call to getName() on a non-object in ApiQueryContentTranslation.php).

• Nikerabbit added a subscriber: Krinkle.

Change 595912 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/ContentTranslation@master] ApiQueryContentTranslation: avoid fatals on getName

https://gerrit.wikimedia.org/r/595912

gerritbot added a project: Patch-For-Review.May 12 2020, 12:08 PM

• Nikerabbit claimed this task.May 12 2020, 12:08 PM

Change 595912 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] ApiQueryContentTranslation: avoid fatals on getName

https://gerrit.wikimedia.org/r/595912

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 13 2020, 7:01 AM

Maintenance_bot removed a project: Patch-For-Review.May 13 2020, 7:10 AM

• Nikerabbit triaged this task as Medium priority.May 13 2020, 7:21 AM

• Nikerabbit updated the task description. (Show Details)

• Nikerabbit edited projects, added Language-Team (Language-2020-Focus-Sprint); removed Language-Team.

• Nikerabbit moved this task from Priority Backlog to Needs QA on the Language-Team (Language-2020-Focus-Sprint) board.

Pginer-WMF moved this task from Needs Triage to Bugs on the ContentTranslation board.May 15 2020, 11:48 AM

• Nikerabbit updated the task description. (Show Details)May 28 2020, 11:51 AM

Is this similar or different case?

[ac0782a6-b6ac-4dd4-9bd1-c434695b13e0] /w/api.php?action=query&format=json&formatversion=2&meta=notifications&notsections=message&notformat=model&notlimit=25&notprop=list%7Ccount%7CseenTime&uselang=sv&notcrosswikisummary=1&notunreadfirst=1&notbundle=1&_=1591453607963   Error from line 61 of /srv/mediawiki/php-1.35.0-wmf.35/extensions/ContentTranslation/includes/DraftNotificationPresentationModel.php: Call to a member function getText() on null

It's not the same. Can you report it separately?

Did a query for "Error from line 165" for the last month and couldn't find any logs.
https://logstash.wikimedia.org/goto/f2ff43c0101ef84cc62e412cf5794c21

In T252094#6221618, @Jpita wrote:

Did a query for "Error from line 165" for the last month and couldn't find any logs.
https://logstash.wikimedia.org/goto/f2ff43c0101ef84cc62e412cf5794c21

Avoid searching by line number as the code has changed in the above patch. For example, if the bug still happened, it would now likely come from line 167.

The significant parts of this one were "ApiQueryContentTranslation.php" or "ApiQueryContentTranslation.php: Call to a member function".

https://logstash.wikimedia.org/goto/ae33d183c6bd1d6cb5523c60a3100769

Here we can see that the error existed in early May (not seeing the old ones can also be an indicator that the query might be too specific), and that there were none after May 13.

Krinkle closed this task as Resolved.Jun 14 2020, 2:02 AM

@Krinkle thanks!

ApiQueryContentTranslation: Call to a member function getName() on nullClosed, ResolvedPublicActions