grouping type should be inferred from Wikidata itself, not hardcoded
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	JeanFred
	May 23 2019, 9:14 AM

Description

Initially, Integraality expected groups and higher-groups to be Q-items, with one exception for country code to be piped into {{Flag}} (controlled by higher-grouping-type

In R2566:8e76a8a85b, I implemented another special type “string”.

This is the wrong approach: the data-type should be inferred from Wikidata itself, the way Listeria does it.

If the datatype is:

Q-item → pipe into {{Q}}
string or number → display as is
image → display as thumb

(That’s all I can think of right now)

Related Objects

Mentioned In: R2566:82de29571a4c: Revamp format_higher_grouping_text logic
T223930: Implement image as special higher grouping type
Mentioned Here: T223930: Implement image as special higher grouping type
R2566:8e76a8a85b81: Add 'string' as valid higher_grouping_type

Event Timeline

JeanFred created this task.May 23 2019, 9:14 AM

Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald TranscriptMay 23 2019, 9:14 AM

JeanFred merged a task: T223930: Implement image as special higher grouping type.May 23 2019, 9:14 AM

JeanFred mentioned this in T223930: Implement image as special higher grouping type.

JeanFred added a subscriber: Daniel_Mietchen.

JeanFred moved this task from Backlog to Enhancements on the Tool-inteGraality board.May 23 2019, 2:14 PM

Mentioned in SAL (#wikimedia-cloud) [2019-10-25T15:02:42Z] <wm-bot> <jeanfred> Deploy latest from Git master: 82de2957 (T224212, T223930)

JeanFred mentioned this in R2566:82de29571a4c: Revamp format_higher_grouping_text logic.Oct 25 2019, 3:03 PM

Closing as Resolved, the grouping-type works as expected.

grouping type should be inferred from Wikidata itself, not hardcodedClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

grouping type should be inferred from Wikidata itself, not hardcoded
Closed, ResolvedPublic
Actions