Change file pages to display content in tabs, with captions and the wikitext block in the first and statements in the second
Closed, ResolvedPublic
Actions

Description

Acceptance criteria:

File pages show the content split into sections for non-JS users
File pages show the content split into tabs for JS users, without a FOUC
First tab, labelled "File information", shows the captions block display/editor and the wikitext block
Second tab, labelled "Structured data", shows the statements block display/editor – https://wikimedia.invisionapp.com/share/NJOIMI9D6SX#/screens/330580747
No H1 heading any more

The file interaction block and the "what is metadata" information panel in the illustration are both out of scope.

Details

	Subject	Repo	Branch	Lines +/-
	Tabify file information and structured data	mediawiki/extensions/WikibaseMediaInfo	master	+369 -132

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Resolved		• Ramsey-WMF	T199352 Deploy Structured Data on Commons with arbitrary Statements
Resolved		Cparle	T204264 "Depicts crawling": Add displaying/editing statements to File page
Open		None	T215643 Consider moving the EXIF data table and file history tables into their own file page tabs
Resolved		• PDrouin-WMF	T216773 Match the spacings and paddings with the design spec
Resolved		Cparle	T215642 Change file pages to display content in tabs, with captions and the wikitext block in the first and statements in the second
Resolved		Jdforrester-WMF	T215645 Factor out the hard-coded magic for knitting together the PHP and JS side of TabLayout as built for Special:Preferences so others can use it
Resolved		Cparle	T212162 Structured data heading is level-1 instead of level-2, because it's a slot and that's how MediaWiki represents them; let's over-ride this

Event Timeline

Jdforrester-WMF triaged this task as High priority.Feb 8 2019, 6:20 PM

Jdforrester-WMF created this task.

Jdforrester-WMF added a parent task: T215643: Consider moving the EXIF data table and file history tables into their own file page tabs.Feb 8 2019, 6:22 PM

• PDrouin-WMF subscribed.Feb 8 2019, 6:35 PM

Jdforrester-WMF updated the task description. (Show Details)Feb 8 2019, 7:14 PM

MarkTraceur edited projects, added Structured Data Engineering (Depicts-Crawling); removed Structured Data Engineering.Feb 19 2019, 8:25 PM

Jdforrester-WMF moved this task from To Do to Blocked on the Structured Data Engineering (Depicts-Crawling) board.Feb 21 2019, 4:26 PM

• Ramsey-WMF moved this task from Blocked to Doing on the Structured Data Engineering (Depicts-Crawling) board.Feb 25 2019, 5:45 PM

Cparle moved this task from Doing to Blocked on the Structured Data Engineering (Depicts-Crawling) board.Feb 26 2019, 5:22 PM

• Phabricator_maintenance added a project: SDC-Statements (Depicts-Crawling).Mar 7 2019, 12:28 AM

greg added a project: Structured-Data-Team-Current-Work.Mar 7 2019, 10:59 PM

MBinder_WMF moved this task from To Do to Blocked on the Structured-Data-Team-Current-Work board.Mar 7 2019, 11:49 PM

• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.Mar 8 2019, 4:53 PM

DonTrung subscribed.Mar 8 2019, 6:19 PM

Yann subscribed.Mar 8 2019, 9:26 PM

Jdforrester-WMF mentioned this in T216773: Match the spacings and paddings with the design spec.Mar 12 2019, 3:40 PM

Jdforrester-WMF added a parent task: T216773: Match the spacings and paddings with the design spec.

Change 493432 had a related patch set uploaded (by Matthias Mullie; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Tabify file information and structured data

https://gerrit.wikimedia.org/r/493432

gerritbot added a project: Patch-For-Review.Mar 14 2019, 10:21 AM

matthiasmullie mentioned this in rEWBI94ad38bd1dce: Tabify file information and structured data.Mar 14 2019, 10:24 AM

Cparle mentioned this in rEWBIe7f8d7368543: Tabify file information and structured data.Mar 14 2019, 10:53 AM

matthiasmullie mentioned this in rEWBI476ba873e5d9: Tabify file information and structured data.Mar 14 2019, 12:46 PM

Cparle mentioned this in rEWBIb75fa097922c: Tabify file information and structured data.Mar 14 2019, 12:51 PM

Cparle mentioned this in rEWBIa8adb7ec01ad: Tabify file information and structured data.Mar 14 2019, 12:57 PM

matthiasmullie mentioned this in rEWBI1d8eddd99d57: Tabify file information and structured data.Mar 14 2019, 1:29 PM

matthiasmullie mentioned this in rEWBI87105ce0ed10: Tabify file information and structured data.

matthiasmullie mentioned this in rEWBId96e1b87f437: Tabify file information and structured data.Mar 14 2019, 2:07 PM

Right now, history/file usage/EXIF metadata placement is outside the tab container, which means it shows regardless of what tab a user is on.

Per convos with @Cparle and @Ramsey-WMF, I think it should be brought inside the tab container under file information -- otherwise it looks like it's showing up twice because it appears under structured data, when it's not structured data.

Once we have more statements launched, there could be a community discussion about additional tabs and what goes where, but for now, it makes sense to keep all information users see now on File Page on the File information tab, and depicts/other statements on the second tab as it helps maintain the status quo.

matthiasmullie mentioned this in rEWBIe05b8578869c: Tabify file information and structured data.Mar 15 2019, 10:34 AM

matthiasmullie mentioned this in rEWBI908e4d093cb0: Tabify file information and structured data.

Cparle mentioned this in rEWBIda6c9930d1be: Tabify file information and structured data.Mar 15 2019, 10:34 AM

matthiasmullie mentioned this in rEWBI296cd25814da: Tabify file information and structured data.Mar 15 2019, 11:49 AM

Cparle mentioned this in rEWBId8acf3af7cd1: Tabify file information and structured data.Mar 15 2019, 12:00 PM

Cparle mentioned this in rEWBI799f113313ed: Tabify file information and structured data.Mar 15 2019, 4:30 PM

Cparle mentioned this in rEWBI76e757e97bed: Tabify file information and structured data.Mar 15 2019, 5:07 PM

• Ramsey-WMF moved this task from Blocked to Doing on the Structured-Data-Team-Current-Work board.Mar 15 2019, 9:26 PM

Change 493432 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Tabify file information and structured data

https://gerrit.wikimedia.org/r/493432

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).Mar 17 2019, 5:02 AM

Cparle moved this task from Doing to Needs QA on the Structured-Data-Team-Current-Work board.Mar 20 2019, 11:03 AM