Page MenuHomePhabricator
Create Task
Maniphest T207662

MT processing error: TypeError: key.trim is not a function
Closed, ResolvedPublic
Actions

Description

Observed in cxserver Production log. Looks like coming from commit e9b63e2.

MT processing error: TypeError: key.trim is not a function
    at match.some (/srv/deployment/cxserver/deploy-cache/revs/b30a323cebea00479b63e6ee07d882f101efe667/src/lib/adaptation/TemplateParameterMapper.js:91:30)
    at Array.some (native)
    at TemplateParameterMapper.getParameterMap (/srv/deployment/cxserver/deploy-cache/revs/b30a323cebea00479b63e6ee07d882f101efe667/src/lib/adaptation/TemplateParameterMapper.js:90:46)
    at TemplateParameterMapper.getAdaptedParameters (/srv/deployment/cxserver/deploy-cache/revs/b30a323cebea00479b63e6ee07d882f101efe667/src/lib/adaptation/TemplateParameterMapper.js:16:29)
    at TemplateTransclusion.<anonymous> (/srv/deployment/cxserver/deploy-cache/revs/b30a323cebea00479b63e6ee07d882f101efe667/src/lib/adaptation/TemplateTransclusion.js:57:50)
    at next (native)
    at resume (/srv/deployment/cxserver/deploy-cache/revs/b30a323cebea00479b63e6ee07d882f101efe667/src/lib/util.js:277:21)
    at resumeNext (/srv/deployment/cxserver/deploy-cache/revs/b30a323cebea00479b63e6ee07d882f101efe667/src/lib/util.js:287:30)

Details

SubjectRepoBranchLines +/-
Update cxserver to 2021-04-07-062518-productionoperations/deployment-chartsmaster+1 -3
Update cxserver to 2021-03-15-131520-productionoperations/deployment-chartsmaster+8 -94
Fix MT error: TypeError: key.trim is not a functionmediawiki/services/cxservermaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

KartikMistry created this task.Oct 22 2018, 2:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 22 2018, 2:33 PM
Nikerabbit added a comment.Oct 23 2018, 8:13 AM

This likely breaks translation of paragraphs containing certain kind of templates. Without content it is hard to say what is the issue.

How frequently are these happening: how many times per day?

Nikerabbit added a project: Regression.Oct 23 2018, 8:13 AM
KartikMistry added a comment.Oct 23 2018, 8:24 AM
In T207662#4688089, @Nikerabbit wrote:

How frequently are these happening: how many times per day?

4 occurrence in last 2 days so far.

• Petar.petkovic moved this task from Backlog to Page contents issues on the CX-cxserver board.Dec 14 2018, 11:44 AM
Arrbee assigned this task to • Jpita.Jul 6 2020, 2:45 PM
Arrbee triaged this task as Low priority.
Arrbee added a project: Language-Team (Language-2020-Focus-Sprint).
Arrbee moved this task from Priority Backlog to Needs QA on the Language-Team (Language-2020-Focus-Sprint) board.
• Jpita closed this task as Resolved.Jul 7 2020, 4:28 AM

image.png (630×2 px, 143 KB)

Nikerabbit reopened this task as Open.Jul 7 2020, 8:46 AM

I double checked with more general query and found that the error has changed slightly:

MT processing error for: en > fr. TypeError: key.trim is not a function
    at match.some (/srv/service/lib/adaptation/TemplateParameterMapper.js:99:32)
    at Array.some (<anonymous>)
    at TemplateParameterMapper.getParameterMap (/srv/service/lib/adaptation/TemplateParameterMapper.js:98:48)
    at TemplateParameterMapper.getAdaptedParameters (/srv/service/lib/adaptation/TemplateParameterMapper.js:17:29)
    at TemplateTransclusion.adapt (/srv/service/lib/adaptation/TemplateTransclusion.js:77:52)

It is infrequent, only 18 instances in last 60 days.

Nikerabbit edited projects, added Wikimedia-production-error; removed Regression.Jul 7 2020, 8:47 AM
• Jpita moved this task from Needs QA to Pending input for QA on the Language-Team (Language-2020-Focus-Sprint) board.Jul 8 2020, 3:57 AM

where should we move this to?

• Rileych moved this task from Pending input for QA to Priority Backlog on the Language-Team (Language-2020-Focus-Sprint) board.Jul 9 2020, 1:05 PM
jeena moved this task from Untriaged to Oct2019/1.35.wmf.1+ on the Wikimedia-production-error board.Jul 15 2020, 6:30 PM
Umherirrender added a project: JavaScript.Jul 17 2020, 8:03 PM
Pginer-WMF edited projects, added Language-Team (Language-2020-July-September); removed Language-Team (Language-2020-Focus-Sprint).Aug 3 2020, 9:29 AM
Pginer-WMF removed a project: Language-Team (Language-2020-July-September).Aug 4 2020, 11:01 AM
Krinkle subscribed.EditedMar 15 2021, 11:07 PM

Still seen consistently several times a week, and for multiple language/wiki combinations, so while rare it's not a single or unlikely isolated issue that repeats itself. The code involved seems to have very specific expectations around an array holding only strings over many layers of abstractions. My guess is that this expectation fails tohold up under certain Template wikitext input that users can create, possibly unintentionally. If so, that would mean there's a bug somewhere in the CX JS code where it fails to normalised or reject part of that input, or maybe one of the callbacks is returning undefined instead of a string.

Some increased logging could help narrow down the cause. RIght now it's pretty slim in terms of detail. E.g. knowing the source page, revision, or template name could help.

msg:
    MT processing error for: es > ca. TypeError: key.trim is not a function
    at match.some (/srv/service/lib/adaptation/TemplateParameterMapper.js:100:11)
    at Array.some (<anonymous>)
    at TemplateParameterMapper.getParameterMap (/srv/service/lib/adaptation/TemplateParameterMapper.js:98:48)
    at TemplateParameterMapper.getAdaptedParameters (/srv/service/lib/adaptation/TemplateParameterMapper.js:17:29)
    at TemplateTransclusion.adapt (/srv/service/lib/adaptation/TemplateTransclusion.js:77:52)

kubernetes.host: kubernetes1001.eqiad.wmnet
santhosh claimed this task.Mar 16 2021, 5:42 AM
santhosh added a subscriber: • Jpita.
gerritbot added a comment.Mar 16 2021, 5:47 AM

Change 672585 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/services/cxserver@master] Fix MT error: TypeError: key.trim is not a function

https://gerrit.wikimedia.org/r/672585

gerritbot added a project: Patch-For-Review.Mar 16 2021, 5:47 AM
santhosh added a project: Language-Team (Language-2021-January-March).Mar 16 2021, 5:47 AM
santhosh moved this task from Quarter Backlog to In Review on the Language-Team (Language-2021-January-March) board.
gerritbot added a comment.Mar 16 2021, 9:13 AM

Change 672585 merged by jenkins-bot:
[mediawiki/services/cxserver@master] Fix MT error: TypeError: key.trim is not a function

https://gerrit.wikimedia.org/r/672585

Maintenance_bot removed a project: Patch-For-Review.Mar 16 2021, 10:10 AM
gerritbot added a comment.Mar 16 2021, 10:58 AM

Change 672386 had a related patch set uploaded (by KartikMistry; owner: KartikMistry):
[operations/deployment-charts@master] WIP: Update cxserver to 2021-03-15-131520-production

https://gerrit.wikimedia.org/r/672386

gerritbot added a project: Patch-For-Review.Mar 16 2021, 10:58 AM
gerritbot added a comment.Mar 22 2021, 4:20 AM

Change 672386 merged by jenkins-bot:
[operations/deployment-charts@master] Update cxserver to 2021-03-15-131520-production

https://gerrit.wikimedia.org/r/672386

Maintenance_bot removed a project: Patch-For-Review.Mar 22 2021, 5:10 AM
Pginer-WMF edited projects, added Language-Team (Language-2021-April-June); removed Language-Team (Language-2021-January-March).Apr 1 2021, 11:20 AM
Pginer-WMF moved this task from Quarter Backlog to In Review on the Language-Team (Language-2021-April-June) board.
gerritbot added a comment.Apr 7 2021, 12:06 PM

Change 677557 had a related patch set uploaded (by KartikMistry; author: KartikMistry):

[operations/deployment-charts@master] Update cxserver to 2021-04-07-062518-production

https://gerrit.wikimedia.org/r/677557

gerritbot added a project: Patch-For-Review.Apr 7 2021, 12:06 PM
gerritbot added a comment.Apr 8 2021, 5:39 AM

Change 677557 merged by jenkins-bot:

[operations/deployment-charts@master] Update cxserver to 2021-04-07-062518-production

https://gerrit.wikimedia.org/r/677557

Stashbot mentioned this in T240525: cxserver: Update to core-js@3.Apr 8 2021, 6:01 AM
Stashbot mentioned this in T278141: cxserver missing important metrics after service-runner 2.8.1 upgrade.
Stashbot mentioned this in T201491: Fix common typos in code.

Mentioned in SAL (#wikimedia-operations) [2021-04-08T06:01:13Z] <kart_> Updated cxserver to 2021-04-07-062518-production (T278141, T263139, T271711, T201491, T240525, T207662)

Stashbot mentioned this in T271711: Update cxserver to service-runner 2.8.1.Apr 8 2021, 6:01 AM
Stashbot mentioned this in T263139: Show section placeholder before "References" and similar sections.
Maintenance_bot removed a project: Patch-For-Review.Apr 8 2021, 6:10 AM
KartikMistry moved this task from In Review to Needs QA on the Language-Team (Language-2021-April-June) board.Apr 8 2021, 8:02 AM
• Jpita moved this task from Needs QA to Done on the Language-Team (Language-2021-April-June) board.Apr 18 2021, 9:43 PM

the last time this error appears was on April 6th
https://logstash.wikimedia.org/goto/5b8961640e2a231669f7ec4f11b98627
moving to done

Krinkle closed this task as Resolved.Apr 18 2021, 9:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits