Page MenuHomePhabricator
Create Task
Maniphest T195382

show Lemma on Special:AllPages
Closed, ResolvedPublic
Actions

Assigned To
Jakob_WMDE
Authored By
Lydia_Pintscher
May 23 2018, 3:00 PM
Tags
Referenced Files
F18742688: Bildschirmfoto vom 2018-06-04 14-59-56.png
Jun 4 2018, 1:02 PM
Subscribers
Aklapper
ArthurPSmith
gerritbot
KaMan
Lea_Lacroix_WMDE
Lydia_Pintscher
Mahir256
View All 10 Subscribers
Tokens
"Like" token, awarded by Liuxinyu970226."Like" token, awarded by Mahir256.

Description

As a user I want to be able to quickly see what is behind a Lexeme ID on Special:AllPages so I can easily find existing Lexemes.

The entry should be "Lehrerin (L123)" instead of "L123" if Lehrerin is the Lemma.

GIVEN There is a Lexeme with a Lemma X
WHEN I am on Special:AllPages
THEN I see the lemma of the lexeme and the ID
AND they link to the lexeme page

Details:
If there are multiple then show them separated by translatable separator (in English forward slash) in the order in which they are in the Lexeme.

Details

SubjectRepoBranchLines +/-
Add correct lang attributes to lemmas in linksmediawiki/extensions/WikibaseLexememaster+112 -15
Prevent lexeme link formatter from breaking for unknown lexemesmediawiki/extensions/WikibaseLexememaster+31 -9
Show lemma on Special:AllPagesmediawiki/extensions/WikibaseLexememaster+242 -0
Introduce EntityLinkFormatterFactory for use with LinkBegin hook.mediawiki/extensions/Wikibasemaster+259 -30
Customize query in gerrit

Related Objects

Event Timeline

Lydia_Pintscher created this task.May 23 2018, 3:00 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptMay 23 2018, 3:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
VIGNERON subscribed.May 23 2018, 3:29 PM

Ideally we should have : label, language code and lexical category. For instance « gwez (br, noun, L62) » for Lexeme:L62 (or any other presentation and order as long as the informations are here).
This is important because the same lemma often exist in multiple languages and even inside one language, the same lemma can have different category. For instance, "best" in English could be an adjective, an adverb, a noun, and a verb, so at least 4 lexemes, if I understand correctly).

But as a first step, lemma would be already great.

ArthurPSmith subscribed.May 23 2018, 3:44 PM

FYI I agree with VIGNERON on what it should look like - but at least something more than the id!

Mahir256 awarded a token.May 24 2018, 12:25 AM
Mahir256 subscribed.May 24 2018, 12:29 AM

The language could be a superscript, as it is when labels for items in Special:Search are presented in a language different from the interface language, and the form could be a subscript. Borrowing Nicolas's example, L62 could be presented as "gwez <sub>noun</sub> <sup>Breton</sup> (L62)".

WMDE-leszek subscribed.May 24 2018, 7:25 AM

@Lydia_Pintscher: to avoid failed expectations, I take there are no expectations/requirements regarding what the "title" attribute of the link would contain?

Lydia_Pintscher triaged this task as High priority.May 24 2018, 8:48 AM
Lydia_Pintscher added a comment.May 24 2018, 9:32 AM

*nod*
Let's later add language and lexical category. However that will be a bit more complicated so let's start with the Lemma at least.

Jakob_WMDE claimed this task.May 24 2018, 11:31 AM
Liuxinyu970226 subscribed.May 24 2018, 10:59 PM
gerritbot subscribed.May 25 2018, 12:58 PM

Change 435163 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] [WIP] Introduce EntityLinkFormatterFactory for use with LinkBegin hook.

https://gerrit.wikimedia.org/r/435163

gerritbot added a project: Patch-For-Review.May 25 2018, 12:58 PM
Jakob_WMDE added a project: Wikidata-Turtles-Sprint #5.May 28 2018, 9:17 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Turtles-Sprint #5 board.
gerritbot added a comment.May 29 2018, 3:32 PM

Change 436041 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Show lemma on Special:AllPages

https://gerrit.wikimedia.org/r/436041

Jakob_WMDE mentioned this in rEWLE8f6970c04c0c: Show lemma on Special:AllPages.May 29 2018, 3:34 PM
Jakob_WMDE mentioned this in rEWLE04a35b762a7a: Show lemma on Special:AllPages.May 29 2018, 4:01 PM
Jakob_WMDE mentioned this in rEWLE993f4b45b57e: Show lemma on Special:AllPages.May 29 2018, 4:21 PM
Lydia_Pintscher mentioned this in T191600: Showing the lemma in recent changes.May 30 2018, 9:42 AM
Jakob_WMDE mentioned this in rEWLEd14e0ff8531c: Show lemma on Special:AllPages.May 30 2018, 9:42 AM
Lydia_Pintscher mentioned this in T191601: Showing the lemma in the watchlist.May 30 2018, 9:42 AM
Jakob_WMDE mentioned this in rEWLEda499f00bd14: Show lemma on Special:AllPages.May 30 2018, 11:29 AM
Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Turtles-Sprint #5 board.May 30 2018, 2:34 PM
Jakob_WMDE mentioned this in rEWLE8df9bb38ef9b: Show lemma on Special:AllPages.May 31 2018, 2:34 PM
WMDE-leszek mentioned this in rEWLE02d43eb57101: Show lemma on Special:AllPages.Jun 1 2018, 7:59 AM
gerritbot added a comment.Jun 1 2018, 8:10 AM

Change 435163 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Introduce EntityLinkFormatterFactory for use with LinkBegin hook.

https://gerrit.wikimedia.org/r/435163

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).Jun 1 2018, 9:00 AM
gerritbot added a comment.Jun 1 2018, 9:35 AM

Change 436041 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Show lemma on Special:AllPages

https://gerrit.wikimedia.org/r/436041

gerritbot added a comment.Jun 1 2018, 2:25 PM

Change 436811 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Prevent lexeme link formatter from breaking for unknown lexemes

https://gerrit.wikimedia.org/r/436811

Jakob_WMDE mentioned this in rEWLEe75acd00bccd: Prevent lexeme link formatter from breaking for unknown lexemes.Jun 1 2018, 2:26 PM
Jakob_WMDE mentioned this in rEWLEf607e38aa5cf: Prevent lexeme link formatter from breaking for unknown lexemes.Jun 1 2018, 2:48 PM
Jakob_WMDE mentioned this in rEWLE3aef0506d1ba: Prevent lexeme link formatter from breaking for unknown lexemes.Jun 1 2018, 2:59 PM
gerritbot added a comment.Jun 4 2018, 11:16 AM

Change 436811 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Prevent lexeme link formatter from breaking for unknown lexemes

https://gerrit.wikimedia.org/r/436811

• Pablo-WMDE subscribed.EditedJun 4 2018, 1:02 PM

The individual lemmas get marked-up in a single span indicated as UI language.
Yes model: additionally wrap each lemma in a span indicating lemma language, the container span can stay as is, as the message formatting them (slash) is in UI language.

Bildschirmfoto vom 2018-06-04 14-59-56.png (392×1 px, 98 KB)

/cc @WMDE-leszek, surfaced here

Jakob_WMDE moved this task from Peer Review to Test (Product Review) on the Wikidata-Turtles-Sprint #5 board.Jun 5 2018, 11:27 AM
Jakob_WMDE moved this task from Test (Product Review) to Peer Review on the Wikidata-Turtles-Sprint #5 board.Jun 5 2018, 1:29 PM
Jakob_WMDE moved this task from Peer Review to Doing on the Wikidata-Turtles-Sprint #5 board.
gerritbot added a comment.Jun 5 2018, 3:56 PM

Change 437498 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Add correct lang attributes to lemmas in links

https://gerrit.wikimedia.org/r/437498

Jakob_WMDE mentioned this in rEWLE56e2f37e584f: Add correct lang attributes to lemmas in links.Jun 5 2018, 3:58 PM
Jakob_WMDE mentioned this in rEWLE23af5a5f1ac2: Add correct lang attributes to lemmas in links.Jun 5 2018, 4:02 PM
Jakob_WMDE mentioned this in rEWLEb7e501ea90c2: Add correct lang attributes to lemmas in links.Jun 5 2018, 4:06 PM
Jakob_WMDE mentioned this in rEWLE17cc25b42b4c: Add correct lang attributes to lemmas in links.Jun 5 2018, 4:12 PM
matej_suchanek mentioned this in T196497: Provide a parser / Lua function to get a link to an entity.Jun 5 2018, 6:53 PM
Jakob_WMDE mentioned this in rEWLE3e6aff7cb15c: Add correct lang attributes to lemmas in links.Jun 6 2018, 9:55 AM
Jakob_WMDE mentioned this in rEWLEa6183f7b60a1: Add correct lang attributes to lemmas in links.Jun 6 2018, 9:59 AM
Jakob_WMDE mentioned this in rEWLE5baf75d20016: Add correct lang attributes to lemmas in links.Jun 6 2018, 10:32 AM
Jakob_WMDE mentioned this in rEWLEfa7e64ed74a4: Add correct lang attributes to lemmas in links.Jun 6 2018, 11:46 AM
Jakob_WMDE mentioned this in rEWLEf2724aaf7a15: Add correct lang attributes to lemmas in links.Jun 6 2018, 11:57 AM
Jakob_WMDE mentioned this in rEWLEfc40c668e928: Add correct lang attributes to lemmas in links.Jun 6 2018, 12:25 PM
• Pablo-WMDE added a project: Wikidata-Editor-Experience-Improvements-Iteration0.Jun 6 2018, 12:43 PM
• Pablo-WMDE moved this task from To Do to Peer Review on the Wikidata-Editor-Experience-Improvements-Iteration0 board.
gerritbot added a comment.Jun 6 2018, 12:54 PM

Change 437498 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add correct lang attributes to lemmas in links

https://gerrit.wikimedia.org/r/437498

Jakob_WMDE moved this task from Peer Review to Test (Product Review) on the Wikidata-Editor-Experience-Improvements-Iteration0 board.Jun 6 2018, 12:56 PM
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)); removed MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).Jun 6 2018, 1:01 PM
Lydia_Pintscher closed this task as Resolved.Jun 6 2018, 2:45 PM
Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Editor-Experience-Improvements-Iteration0 board.
Liuxinyu970226 awarded a token.Jun 6 2018, 2:46 PM
Liuxinyu970226 unsubscribed.
Lea_Lacroix_WMDE subscribed.Jun 7 2018, 8:06 AM

Announced here

• Pablo-WMDE mentioned this in T196612: Arabic lemma with wrong lang, dir in LexemeLinkFormatter.Jun 7 2018, 9:08 AM
• Vvjjkkii renamed this task from show Lemma on Special:AllPages to 1fcaaaaaaa.Jul 1 2018, 1:08 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Jakob_WMDE as the assignee of this task.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii edited subscribers, added: Jakob_WMDE; removed: gerritbot, Aklapper.
CommunityTechBot renamed this task from 1fcaaaaaaa to show Lemma on Special:AllPages.Jul 2 2018, 1:34 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Jakob_WMDE.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot edited subscribers, added: gerritbot, Aklapper; removed: Jakob_WMDE.
KaMan subscribed.Jul 31 2018, 8:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits