Page MenuHomePhabricator
Create Task
Maniphest T190492

Wrong alias shown in watchlist/history when updating an alias
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

When I edit an alias, the message in the edit summary, that appears in the history/watchlist is: "Updated [language] alias", and then the old alias. For more clarity, it should probably show the new alias that has been entered.

Tested here: I changed the French alias from "Bac à Sable (7rkujizi)" to "test" and the message appearing in the edit summary is the previous alias.

Requested by the community here

Details

SubjectRepoBranchLines +/-
wbsetaliases: when changing aliases, include post-edit aliases in the summarymediawiki/extensions/Wikibasemaster+6 -11
Added tests for summary of edits made by wbsetaliases APImediawiki/extensions/Wikibasemaster+86 -0
Make wbsetaliases API use new aliases instead of the old ones in summarymediawiki/extensions/Wikibasemaster+3 -2
Customize query in gerrit

Event Timeline

Lea_Lacroix_WMDE created this task.Mar 23 2018, 7:37 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2018, 7:37 AM
Liuxinyu970226 subscribed.Mar 23 2018, 1:09 PM
• iecetcwcpggwqpgciazwvzpfjpwomjxn subscribed.Mar 25 2018, 8:01 PM
Lydia_Pintscher set the point value for this task to 3.May 2 2018, 2:05 PM
Lydia_Pintscher added a project: Wikidata-Ministry-Of-Magic.
Lucas_Werkmeister_WMDE moved this task from Tasks to User Stories on the Wikidata-Ministry-Of-Magic board.May 2 2018, 2:10 PM
gerritbot subscribed.May 3 2018, 3:27 PM

Change 430609 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Make wbsetaliases API use new aliases instead of the old ones in summary

https://gerrit.wikimedia.org/r/430609

gerritbot added a project: Patch-For-Review.May 3 2018, 3:27 PM
Ladsgroup claimed this task.May 3 2018, 3:27 PM
Ladsgroup moved this task from User Stories to Needs Review on the Wikidata-Ministry-Of-Magic board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptMay 3 2018, 3:27 PM
Lucas_Werkmeister_WMDE moved this task from Needs Review to In Progress on the Wikidata-Ministry-Of-Magic board.May 9 2018, 10:03 AM
gerritbot added a comment.May 9 2018, 11:10 AM

Change 432064 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Added tests for summary of edits made by wbsetaliases API

https://gerrit.wikimedia.org/r/432064

gerritbot added a comment.May 9 2018, 11:10 AM

Change 432065 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] wbsetaliases: when changing aliases, include post-edit aliases in the summary

https://gerrit.wikimedia.org/r/432065

gerritbot added a comment.May 12 2018, 12:38 PM

Change 430609 abandoned by Ladsgroup:
Make wbsetaliases API use new aliases instead of the old ones in summary

https://gerrit.wikimedia.org/r/430609

Ladsgroup reassigned this task from Ladsgroup to WMDE-leszek.May 12 2018, 12:39 PM
Ladsgroup moved this task from In Progress to Test (Product Review) on the Wikidata-Ministry-Of-Magic board.
Ladsgroup subscribed.
gerritbot added a comment.May 12 2018, 1:25 PM

Change 432064 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Added tests for summary of edits made by wbsetaliases API

https://gerrit.wikimedia.org/r/432064

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)).May 12 2018, 2:00 PM
gerritbot added a comment.May 12 2018, 2:31 PM

Change 432065 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] wbsetaliases: when changing aliases, include post-edit aliases in the summary

https://gerrit.wikimedia.org/r/432065

Lydia_Pintscher moved this task from Test (Product Review) to User Stories on the Wikidata-Ministry-Of-Magic board.May 14 2018, 9:20 AM

This still seems to have the wrong behaviour :/
https://test.wikidata.org/w/index.php?title=Q60867&diff=379861&oldid=379860

Lydia_Pintscher closed this task as Resolved.May 14 2018, 9:25 AM
Lydia_Pintscher moved this task from User Stories to Done on the Wikidata-Ministry-Of-Magic board.

Nevermind. Working on https://wikidata.beta.wmflabs.org/w/index.php?title=Q458254&diff=1006082&oldid=1006081 now \o/ Will be rolled out with the next train.

Lea_Lacroix_WMDE moved this task from Done to Needs announcement on the Wikidata-Ministry-Of-Magic board.May 15 2018, 1:17 PM
Lydia_Pintscher moved this task from Needs announcement to Done on the Wikidata-Ministry-Of-Magic board.May 23 2018, 9:52 AM
Liuxinyu970226 unsubscribed.Jun 5 2018, 2:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits