Page MenuHomePhabricator
Create Task
Maniphest T185596

Bring SVGO-based automated optimization to all products
Closed, ResolvedPublic
Actions

Description

We've been overhauling SVG markup in T178867 with both SVGO and manual code optimizations that are accomplished.

Furthermore we've brought SVGO build optimization for continuous improvement to

  • OOUI and
  • Style Guide.

Let's bring it to further active projects:

Details

SubjectRepoBranchLines +/-
Fix: viewBox in cog.svg and sad-face.svgmediawiki/extensions/Popupsmaster+2 -2
build: Bring SVGO optimization to build stepmediawiki/extensions/Popupsmaster+415 -14
build: Extend 'svgmin' options and move to 'minify' taskmediawiki/extensions/Echomaster+9 -11
build: Bring SVGO optimization to build stepmediawiki/extensions/UniversalLanguageSelectormaster+60 -25
build: Amend 'grunt-svgmin' options and re-crush SVGsoojs/uimaster+6 -6
build: Bring SVGO optimization to build stepmediawiki/extensions/CentralNoticemaster+42 -15
build: Extend 'svgmin' options and amendmediawiki/extensions/Kartographermaster+4 -3
build: Extend 'svgmin' options and move to 'minify' taskmediawiki/extensions/TwoColConflictmaster+6 -4
Update VE core submodule to master (1d341ca7d)mediawiki/extensions/VisualEditormaster+26 -6
build: Extend 'svgmin' options and amendVisualEditor/VisualEditormaster+8 -6
build: Bring SVGO optimization to build stepmediawiki/extensions/TwoColConflictmaster+38 -1
build: Bring SVGO optimization to build stepmediawiki/extensions/Echomaster+84 -49
build: Bring SVGO optimization to build stepmediawiki/extensions/GuidedTourmaster+63 -27
build: Bring SVGO optimization to build stepmediawiki/extensions/Citemaster+68 -30
build: Bring SVGO optimization to build stepmediawiki/extensions/Kartographermaster+39 -2
Update VE core submodule to master (c39a4a69b)mediawiki/extensions/VisualEditormaster+1 -1
build: Use SVGO option of 'grunt-image'mediawiki/extensions/VisualEditormaster+34 -16
build: Bring SVGO optimization to 'ci' stepVisualEditor/VisualEditormaster+56 -20
Bring SVGO optimization to build stepmediawiki/extensions/MultimediaViewermaster+168 -138
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot subscribed.Jan 23 2018, 8:18 PM

Change 405935 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/MultimediaViewer@master] Bring SVGO optimization to build step

https://gerrit.wikimedia.org/r/405935

gerritbot added a project: Patch-For-Review.Jan 23 2018, 8:18 PM
gerritbot added a comment.Jan 25 2018, 1:49 AM

Change 405935 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Bring SVGO optimization to build step

https://gerrit.wikimedia.org/r/405935

Volker_E updated the task description. (Show Details)Jan 30 2018, 5:00 PM
gerritbot added a comment.Feb 1 2018, 12:50 AM

Change 407184 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/VisualEditor@master] build: Use SVGO option of 'grunt-image'

https://gerrit.wikimedia.org/r/407184

gerritbot added a comment.Feb 1 2018, 1:17 AM

Change 407189 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[VisualEditor/VisualEditor@master] build: Bring SVGO optimization to build step

https://gerrit.wikimedia.org/r/407189

Volker_E updated the task description. (Show Details)Feb 1 2018, 4:51 AM
Volker_E added a subscriber: Jdforrester-WMF.
gerritbot added a comment.Feb 3 2018, 4:47 AM

Change 407885 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Echo@master] build: Bring SVGO optimization to build step

https://gerrit.wikimedia.org/r/407885

gerritbot added a comment.Feb 7 2018, 8:29 PM

Change 407189 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] build: Bring SVGO optimization to 'ci' step

https://gerrit.wikimedia.org/r/407189

gerritbot added a comment.Feb 8 2018, 5:49 PM

Change 407184 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] build: Use SVGO option of 'grunt-image'

https://gerrit.wikimedia.org/r/407184

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 8 2018, 6:00 PM
Volker_E updated the task description. (Show Details)Feb 8 2018, 6:28 PM
gerritbot added a comment.Feb 10 2018, 7:17 AM

Change 409488 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/GuidedTour@master] build: Bring SVGO optimization to build step

https://gerrit.wikimedia.org/r/409488

Volker_E updated the task description. (Show Details)Feb 10 2018, 7:18 AM
gerritbot added a comment.Feb 11 2018, 2:40 AM

Change 409632 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c39a4a69b)

https://gerrit.wikimedia.org/r/409632

gerritbot added a comment.Feb 12 2018, 5:19 PM

Change 409957 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Cite@master] build: Bring SVGO optimization to build step

https://gerrit.wikimedia.org/r/409957

gerritbot added a comment.Feb 12 2018, 5:39 PM

Change 409632 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c39a4a69b)

https://gerrit.wikimedia.org/r/409632

gerritbot added a comment.Feb 12 2018, 6:03 PM

Change 409976 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/CentralNotice@master] build: Bring SVGO optimization to build step

https://gerrit.wikimedia.org/r/409976

gerritbot added a comment.Feb 12 2018, 6:22 PM

Change 409987 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Kartographer@master] build: Bring SVGO optimization to build step

https://gerrit.wikimedia.org/r/409987

gerritbot added a comment.Feb 12 2018, 6:55 PM

Change 409987 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] build: Bring SVGO optimization to build step

https://gerrit.wikimedia.org/r/409987

gerritbot added a comment.Feb 12 2018, 7:40 PM

Change 410019 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Popups@master] build: Bring SVGO optimization to build step

https://gerrit.wikimedia.org/r/410019

gerritbot added a comment.Feb 12 2018, 7:50 PM

Change 410021 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/TwoColConflict@master] build: Bring SVGO optimization to build step

https://gerrit.wikimedia.org/r/410021

Diffusion mentioned this in rESCC127a5f3c3027: build: Bring SVGO optimization to build step.Feb 12 2018, 7:52 PM
gerritbot added a comment.Feb 12 2018, 8:03 PM

Change 410026 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/UniversalLanguageSelector@master] build: Bring SVGO optimization to build step

https://gerrit.wikimedia.org/r/410026

Volker_E updated the task description. (Show Details)Feb 12 2018, 8:15 PM
Diffusion mentioned this in rESCC053b423c97a2: build: Bring SVGO optimization to build step.Feb 12 2018, 8:21 PM
santhosh subscribed.Feb 13 2018, 6:32 AM

I think this should be a test task that check if the svg is optimized or not as per given configuration and fail the test. Doing the real svg optimization everytime test runs, does not look nice.
I filed this ticket in upstream https://github.com/svg/svgo/issues/905 (Provide a way to test an svg is optimized or not as per given configuration)

Volker_E added a comment.Feb 13 2018, 3:52 PM

@santhosh There's also discussion around T179361: Move MobileFrontend/Minerva's svg_check.sh script into a reusable, separate library, which would target your request on our side.

gerritbot added a comment.Feb 14 2018, 6:47 PM

Change 409957 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] build: Bring SVGO optimization to build step

https://gerrit.wikimedia.org/r/409957

gerritbot added a comment.Feb 14 2018, 6:51 PM

Change 409488 merged by jenkins-bot:
[mediawiki/extensions/GuidedTour@master] build: Bring SVGO optimization to build step

https://gerrit.wikimedia.org/r/409488

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)); removed MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 14 2018, 7:00 PM
gerritbot added a comment.Feb 22 2018, 8:41 PM

Change 407885 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] build: Bring SVGO optimization to build step

https://gerrit.wikimedia.org/r/407885

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)); removed MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)).Feb 22 2018, 9:01 PM
Volker_E updated the task description. (Show Details)Feb 23 2018, 8:40 PM
WMDE-Fisch mentioned this in rESCCad00476f7273: build: Bring SVGO optimization to build step.Feb 28 2018, 12:56 PM
gerritbot added a comment.Feb 28 2018, 12:59 PM

Change 410021 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] build: Bring SVGO optimization to build step

https://gerrit.wikimedia.org/r/410021

Volker_E updated the task description. (Show Details)Feb 28 2018, 3:11 PM
ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)); removed MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)).Mar 6 2018, 10:01 AM
Volker_E mentioned this in T194188: Add #SVG tag to Phabricator.May 8 2018, 9:07 PM
Volker_E updated the task description. (Show Details)May 13 2018, 10:42 PM
gerritbot added a comment.May 14 2018, 5:32 AM

Change 432940 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/TwoColConflict@master] build: Extend 'svgmin' options and move to 'minify' task

https://gerrit.wikimedia.org/r/432940

Diffusion mentioned this in rESCC2413e8bc3d24: build: Extend 'svgmin' options and move to 'minify' task.May 14 2018, 5:33 AM
gerritbot added a comment.May 15 2018, 7:26 AM

Change 433123 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Kartographer@master] build: Extend 'svgmin' options and amend

https://gerrit.wikimedia.org/r/433123

gerritbot added a comment.May 15 2018, 7:36 AM

Change 433124 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Echo@master] build: Extend 'svgmin' options and move to 'minify' task

https://gerrit.wikimedia.org/r/433124

gerritbot added a comment.May 16 2018, 11:21 PM

Change 433496 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] build: Amend 'grunt-svgmin' options and re-crush SVGs

https://gerrit.wikimedia.org/r/433496

gerritbot added a comment.May 16 2018, 11:58 PM

Change 433497 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[VisualEditor/VisualEditor@master] build: Extend 'svgmin' options and amend

https://gerrit.wikimedia.org/r/433497

gerritbot added a comment.May 17 2018, 11:16 AM

Change 433497 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] build: Extend 'svgmin' options and amend

https://gerrit.wikimedia.org/r/433497

gerritbot added a comment.May 17 2018, 11:22 AM

Change 433123 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] build: Extend 'svgmin' options and amend

https://gerrit.wikimedia.org/r/433123

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)).May 17 2018, 12:00 PM
gerritbot added a comment.May 18 2018, 11:57 AM

Change 433553 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a0dcb393b)

https://gerrit.wikimedia.org/r/433553

gerritbot added a comment.May 18 2018, 3:37 PM

Change 433553 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1d341ca7d)

https://gerrit.wikimedia.org/r/433553

gerritbot added a comment.May 18 2018, 10:42 PM

Change 432940 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] build: Extend 'svgmin' options and move to 'minify' task

https://gerrit.wikimedia.org/r/432940

gerritbot added a comment.May 19 2018, 10:57 AM

Change 409976 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] build: Bring SVGO optimization to build step

https://gerrit.wikimedia.org/r/409976

Volker_E updated the task description. (Show Details)May 19 2018, 11:09 AM
Jdforrester-WMF updated the task description. (Show Details)May 19 2018, 11:12 AM
Volker_E updated the task description. (Show Details)May 19 2018, 1:08 PM
gerritbot added a comment.May 20 2018, 7:47 AM

Change 433496 merged by jenkins-bot:
[oojs/ui@master] build: Amend 'grunt-svgmin' options and re-crush SVGs

https://gerrit.wikimedia.org/r/433496

gerritbot added a comment.May 20 2018, 8:55 AM

Change 410026 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] build: Bring SVGO optimization to build step

https://gerrit.wikimedia.org/r/410026

Volker_E updated the task description. (Show Details)May 20 2018, 9:44 AM
gerritbot added a comment.May 30 2018, 3:24 PM

Change 433124 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] build: Extend 'svgmin' options and move to 'minify' task

https://gerrit.wikimedia.org/r/433124

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)); removed MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)).May 30 2018, 5:01 PM
Jdlrobson added a project: Web-Team-Backlog.Aug 2 2018, 6:35 AM
Jdlrobson moved this task from Incoming to Upcoming on the Web-Team-Backlog board.
ovasileva lowered the priority of this task from Medium to Low.Aug 7 2018, 4:47 PM
ovasileva added a project: Readers-Web-Kanbanana-Board-Old.
ovasileva subscribed.

marking as low priority for code review to distinguish from higher priority tasks

ovasileva moved this task from To Do to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Aug 7 2018, 4:48 PM
gerritbot added a comment.Aug 8 2018, 11:03 AM

Change 410019 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] build: Bring SVGO optimization to build step

https://gerrit.wikimedia.org/r/410019

Jdrewniak updated the task description. (Show Details)Aug 8 2018, 11:25 AM
Jdrewniak moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)); removed MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).Aug 8 2018, 12:00 PM
gerritbot added a comment.Aug 8 2018, 1:43 PM

Change 451322 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/Popups@master] Fix: capitalization of viewBox in cog.svg

https://gerrit.wikimedia.org/r/451322

gerritbot added a comment.Aug 8 2018, 2:38 PM

Change 451322 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Fix: viewBox in cog.svg and sad-face.svg

https://gerrit.wikimedia.org/r/451322

Volker_E closed this task as Resolved.Aug 8 2018, 3:39 PM

Hooray!

Volker_E raised the priority of this task from Low to Medium.Aug 8 2018, 3:40 PM
Volker_E removed a project: Patch-For-Review.
Volker_E moved this task from Inbox to Done on the Front-end-Standards-Group board.
Volker_E removed a subscriber: gerritbot.
Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 14 2018, 8:55 PM
MBinder_WMF moved this task from Upcoming to Readers-Web-Kanbanana-Board-2018-19-Q1 on the Web-Team-Backlog board.Aug 23 2018, 12:00 AM
MBinder_WMF edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1); removed Web-Team-Backlog.
Volker_E mentioned this in T215485: Bring SVGO to MonoBook.Feb 7 2019, 6:35 AM
brennen mentioned this in T199004: RFC: Add a frontend build step to skins/extensions to our deploy process.Jan 7 2020, 7:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits