Support “constraint scope” parameter (days: 3)
Closed, ResolvedPublic
Actions

Description

The constraint scope (P4680 on Wikidata) specifies whether a constraint should be checked on the main snak, on qualifiers, and/or on references of a statement. DelegatingConstraintChecker should inspect this parameter and decide whether or not to check the constraint; if it’s not checked, report a new status instead, which would replace the current “not main snak” status. (I’m not yet sure what it should be called – “not in scope”?)

Details

Subject	Repo	Branch	Lines +/-
Remove unnecessary code from checkers	mediawiki/extensions/WikibaseQualityConstraints	master	+0 -32
Add scope support to DelegatingConstraintChecker	mediawiki/extensions/WikibaseQualityConstraints	master	+233 -0
Add scope helpers to test traits	mediawiki/extensions/WikibaseQualityConstraints	master	+51 -0
Declare ConstraintChecker’s supported and default context types	mediawiki/extensions/WikibaseQualityConstraints	master	+506 -0
Rename status not-main-snak to not-in-scope	mediawiki/extensions/WikibaseQualityConstraints	master	+8 -9

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Lucas_Werkmeister_WMDE	T173695 Enable constraint checks by default for users
Resolved	Lucas_Werkmeister_WMDE	T168532 Check constraints on qualifiers and references
Resolved	Lucas_Werkmeister_WMDE	T178295 Don’t always check “type” constraint on qualifiers
Resolved	Lucas_Werkmeister_WMDE	T183542 Support “constraint scope” parameter (days: 3)
Resolved	Lucas_Werkmeister_WMDE	T184202 Parse constraint scope parameter

Event Timeline

Lucas_Werkmeister_WMDE triaged this task as Medium priority.Dec 22 2017, 11:17 AM

Lucas_Werkmeister_WMDE created this task.

Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint-2018-01-03.Jan 2 2018, 2:25 PM

Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Jan 2 2018, 2:51 PM

Lucas_Werkmeister_WMDE claimed this task.Jan 4 2018, 7:01 PM

For constraints that very clearly only make sense in certain scopes (like “used as qualifier” or “mandatory qualifiers”), we should probably report any other scopes as errors.

What should we do for constraints that currently aren’t supported in all scopes, but which might be supported there in the future (like “conflicts with” – see subtasks of T168532: Check constraints on qualifiers and references for more)? STATUS_TODO sounds appropriate, I guess… if it’s acceptable that this is, for all users who don’t check the special page, a silent skipping of the constraint. But that might also turn out to be confusing :/

Change 402881 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Rename status not-main-snak to not-in-scope

https://gerrit.wikimedia.org/r/402881

Change 402882 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add ConstraintChecker::getSupportedContextTypes()

https://gerrit.wikimedia.org/r/402882

Change 402883 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add scope helpers to test traits

https://gerrit.wikimedia.org/r/402883

Change 402884 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add scope support to DelegatingConstraintChecker

https://gerrit.wikimedia.org/r/402884

Change 402885 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove unnecessary code from checkers

https://gerrit.wikimedia.org/r/402885

Lucas_Werkmeister_WMDE moved this task from Backlog to Review on the Wikidata-Sprint-2018-01-03 board.Jan 8 2018, 6:35 PM

• Jonas updated the task description. (Show Details)Jan 9 2018, 10:58 AM

WMDE-leszek renamed this task from Support “constraint scope” parameter to Support “constraint scope” parameter (days: 3).Jan 11 2018, 9:35 AM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jan 11 2018, 12:23 PM

• Jonas updated the task description. (Show Details)Jan 12 2018, 1:22 PM

• Jonas moved this task from Review to Done on the Wikidata-Sprint-2018-01-03 board.

Change 402881 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Rename status not-main-snak to not-in-scope

https://gerrit.wikimedia.org/r/402881

Change 402882 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Declare ConstraintChecker’s supported and default context types

https://gerrit.wikimedia.org/r/402882

Change 402883 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add scope helpers to test traits

https://gerrit.wikimedia.org/r/402883

Change 402884 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add scope support to DelegatingConstraintChecker

https://gerrit.wikimedia.org/r/402884

Change 402885 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove unnecessary code from checkers

https://gerrit.wikimedia.org/r/402885

Lucas_Werkmeister_WMDE closed this task as Resolved.Jan 12 2018, 1:37 PM

Lucas_Werkmeister_WMDE closed subtask T184202: Parse constraint scope parameter as Resolved.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)).Jan 13 2018, 8:01 PM