Remove cached constraint check results on purge
Closed, ResolvedPublic
Actions

Description

Subscribe to the ArticlePurge hook to wipe the cached constraint check results for that entity.

Patch-For-Review (includes two minor not-really-related refactorings which the later commits are based on):

unrelated refactoring 1
unrelated refactoring 2
[ResultsCache refactoring](https://gerrit.wikimedia.org/r/399850)
[ArticlePurge hook](https://gerrit.wikimedia.org/r/399851)

Details

	Subject	Repo	Branch	Lines +/-
	Delete cached check results on article purge	mediawiki/extensions/WikibaseQualityConstraints	master	+16 -1
	Extract ResultsCache from CachingResultsBuilder	mediawiki/extensions/WikibaseQualityConstraints	master	+168 -41

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Lucas_Werkmeister_WMDE	T173695 Enable constraint checks by default for users
Open	None	T103228 Improve performance of constraint check
Resolved	Lydia_Pintscher	T179839 Cache constraint check results
Resolved	Lydia_Pintscher	T179849 Cache all constraint check results per-entity
Resolved	Lucas_Werkmeister_WMDE	T181060 Cache constraint check results per-entity in ObjectCache (L) (days: 2)
Resolved	Lucas_Werkmeister_WMDE	T182107 Remove cached constraint check results on purge

Event Timeline

Lucas_Werkmeister_WMDE created this task.Dec 5 2017, 3:24 PM

Lucas_Werkmeister_WMDE added a project: Wikidata-Former-Sprint-Board.Dec 5 2017, 3:40 PM

Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Dec 18 2017, 2:51 PM

Lydia_Pintscher removed a project: Wikidata-Former-Sprint-Board.

Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint-2017-12-20.Dec 22 2017, 4:55 PM

Lucas_Werkmeister_WMDE moved this task from Backlog to In Progress on the Wikidata-Sprint-2017-12-20 board.

Change 399850 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Extract ResultsCache from CachingResultsBuilder

https://gerrit.wikimedia.org/r/399850

Change 399851 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Delete cached check results on article purge

https://gerrit.wikimedia.org/r/399851

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 22 2017, 5:36 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)

Lucas_Werkmeister_WMDE moved this task from In Progress to Review on the Wikidata-Sprint-2017-12-20 board.

Lucas_Werkmeister_WMDE updated the task description. (Show Details)

Lucas_Werkmeister_WMDE claimed this task.Dec 22 2017, 5:41 PM

WMDE-leszek moved this task from Review to Done on the Wikidata-Sprint-2017-12-20 board.Dec 27 2017, 9:58 AM

WMDE-leszek moved this task from Done to Review on the Wikidata-Sprint-2017-12-20 board.

Change 399850 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Extract ResultsCache from CachingResultsBuilder

https://gerrit.wikimedia.org/r/399850

Change 399851 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Delete cached check results on article purge

https://gerrit.wikimedia.org/r/399851