Section link/anchor included in Notifications doesn't work due to ".C2.A0" instead of "_"
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Jc86035
	Nov 16 2017, 1:37 PM

Description

For the section "Using Wikimedia maps instead of geohack ?", the notifications panel links to #Using_Wikimedia_maps_instead_of_geohack.C2.A0.3F (which does not work) when it should actually link to #Using_Wikimedia_maps_instead_of_geohack_.3F.

Details

	Subject	Repo	Branch	Lines +/-
	PresentationModelSectionTrait: Use section anchor generation from code	mediawiki/extensions/Echo	master	+1 -2

Customize query in gerrit

Related Objects

Mentioned Here: rECHO6eea6d93a137: Used parsed section titles for anchors
rMW129067c907ea: Remove nbsp and similar characters from section IDs

Event Timeline

Jc86035 created this task.Nov 16 2017, 1:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 16 2017, 1:37 PM

Jc86035 added a project: Notifications.Nov 16 2017, 1:40 PM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptNov 16 2017, 1:40 PM

TheDJ subscribed.Nov 16 2017, 2:37 PM

Aklapper renamed this task from Notifications – section link doesn't work to Section link/anchor included in Notifications doesn't work due to ".C2.A0" instead of "_".Nov 16 2017, 2:38 PM

Quiddity removed a subscriber: Notifications.Nov 16 2017, 5:16 PM

Looks like we are not correctly normalizing whitespace here? .C2.A0 is the encoding for a non-breaking space, but the other code seems to normalize that to a space. Ideally we'd use the same code for generating section anchors that's used everywhere else, but I'm not sure if that's exposed.

This seems to be a regression kind of caused by rMW129067c907ea: Remove nbsp and similar characters from section IDs, in the sense that that commit changes the way the parser builds section IDs and we are mimicking but not using that in Echo (not sure why).

Turns out it's my fault: rECHO6eea6d93a137: Used parsed section titles for anchors

Change 392992 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/Echo@master] PresentationModelSectionTrait: Use section anchor generation from code

https://gerrit.wikimedia.org/r/392992

gerritbot added a project: Patch-For-Review.Nov 22 2017, 11:19 PM

• jmatazzoni moved this task from Untriaged to Near-Term Interest on the Collaboration-Team-Triage board.Nov 28 2017, 6:23 PM

SBisson edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.Jan 4 2018, 4:52 PM

SBisson moved this task from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Change 392992 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] PresentationModelSectionTrait: Use section anchor generation from code

https://gerrit.wikimedia.org/r/392992

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 4 2018, 5:00 PM