CodeMirror loses changes on browser history moves
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Fomafix
	Sep 11 2017, 5:32 AM

Description

Steps to reproduce:

Load a random page.
Click on edit.
Disable CodeMirror.
Make a first change on the text.
Enable CodeMirror.
Make a second change on the text.
Click on browser history back.
Confirm the confirmation message.
Click on browser history forward.

Current result:
The text with the first changes is restored.

Expected result:
The text with the second changes should restored.

Details

	Subject	Repo	Branch	Lines +/-
	Execute codeMirror.save() on beforeunload	mediawiki/extensions/CodeMirror	master	+7 -0

Customize query in gerrit

Event Timeline

Fomafix created this task.Sep 11 2017, 5:32 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 11 2017, 5:32 AM

Change 377197 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/extensions/CodeMirror@master] ExecutecodeMirror.toTextArea() on beforeunload

https://gerrit.wikimedia.org/r/377197

gerritbot added a project: Patch-For-Review.Sep 11 2017, 5:34 AM

Raymond subscribed.Sep 11 2017, 5:49 AM

MGChecker subscribed.Sep 11 2017, 6:45 AM

Fomafix renamed this task from CodeMirror looses changes on browser history moves to CodeMirror loses changes on browser history moves.Sep 11 2017, 12:16 PM

TheDJ awarded a token.Oct 12 2017, 12:03 PM

Niharika triaged this task as Medium priority.Nov 7 2017, 11:34 PM

Restricted Application added a project: Community-Tech. · View Herald TranscriptNov 7 2017, 11:34 PM

Change 377197 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Execute codeMirror.save() on beforeunload

https://gerrit.wikimedia.org/r/377197

kaldari closed this task as Resolved.Nov 8 2017, 12:22 AM

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)).Nov 8 2017, 1:00 AM

Fomafix removed a project: Patch-For-Review.Nov 8 2017, 8:11 AM

MGChecker awarded a token.Nov 22 2017, 9:06 PM

MusikAnimal moved this task from New & TBD Tickets to Archive on the Community-Tech board.Nov 29 2017, 12:30 AM

Niharika moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.Jan 4 2018, 6:08 AM