Page MenuHomePhabricator
Create Task
Maniphest T125437

[Regression] Continuously getting an error about editing a old revision of the page with VE
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

I dont have exact steps to reproduce this but I am recently facing this a lot. Almost everytime I save an edit and reopen the page it tells me that I am trying to edit an old revision

Although I see a pattern here, not sure if thats reliable way to reproduce it but for everytime I save the page after adding an image or table and then reopen again to edit , it complains about that

Screen Shot 2016-02-01 at 9.36.02 PM.png (548×1 px, 152 KB)

Details

SubjectRepoBranchLines +/-
In the event of a document reload due to RB vs. API rev ID conflict, always re-set requestedRevIdmediawiki/extensions/VisualEditormaster+1 -3
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Feb 1 2016, 8:47 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 1 2016, 8:47 PM
Jdforrester-WMF subscribed.Feb 9 2016, 8:22 PM

Any update on reproduction steps here?

Ryasmeen added a comment.Feb 29 2016, 10:11 PM

Yes got the Steps to reproduce:

  1. Open a page
  2. Add a focusable node such as cite note/image/link or add a numbered list
  3. Keep the focusable node highlighted/selcted

4.Click on Save page
5.Quickly click on Edit again to reopen the page (As soon as you see "Your edit was saved")

It complains that "You are editing a old revision of the page"

• Whatamidoing-WMF subscribed.Mar 10 2016, 3:25 AM

I'm seeing this today in Firefox 44. Rummana's steps to reproduce sound very plausible to me.

Ryasmeen added a comment.Mar 10 2016, 8:42 PM

Getting this on en.wiki too now.

Jdforrester-WMF triaged this task as High priority.Mar 10 2016, 11:44 PM
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF set Security to None.
Jdforrester-WMF merged a task: T129038: VisualEditor uses an oldid of the page when reediting it.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF added subscribers: GorillaWarfare, Pipetricker, • Elitre and 3 others.
greg subscribed.Mar 10 2016, 11:46 PM

on mw.org (wmf.16 right now) for me it's simply:

  • Go to a page at rev0
  • Edit a page in VE, save it (rev1)
  • Keep that tab open, look at the page and see something else to edit
  • Click Edit again and VE loads the previous revision (rev0)
gerritbot subscribed.Mar 12 2016, 4:48 AM

Change 276933 had a related patch set uploaded (by Alex Monk):
In the event of a document reload due to RB vs. API rev ID conflict, always re-set requestedRevId

https://gerrit.wikimedia.org/r/276933

gerritbot added a project: Patch-For-Review.Mar 12 2016, 4:48 AM
• AlexMonk-WMF claimed this task.Mar 12 2016, 4:49 AM
gerritbot added a comment.Mar 17 2016, 3:39 PM

Change 276933 merged by jenkins-bot:
In the event of a document reload due to RB vs. API rev ID conflict, always re-set requestedRevId

https://gerrit.wikimedia.org/r/276933

Jdforrester-WMF closed this task as Resolved.Mar 17 2016, 4:25 PM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2016-03-22_(1.27.0-wmf.18)); removed Patch-For-Review.
Trizek-WMF added a project: User-notice.Mar 23 2016, 10:01 AM
Trizek-WMF moved this task from To Triage to Announce in next Tech/News on the User-notice board.
Quiddity removed a project: User-notice.Mar 24 2016, 11:05 PM
Pipetricker unsubscribed.Jul 8 2018, 8:22 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 8 2018, 8:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits