Page MenuHomePhabricator
Create Task
Maniphest T107440

Stacktraces missing from exception.log on fluorine
Closed, ResolvedPublic
Actions

Description

2015-07-30 08:24:21 mw1053 wikidatawiki exception ERROR: [0e4f9934] /wiki/Special:WhatLinksHere/Wikidata:Tools   Flow\Exception\CatchableFatalErrorException from line 35 of /srv/mediawiki/php-1.26wmf16/extensions/Flow/includes/Model/WikiReference.php: Argument 6 passed to Flow\Model\WikiReference::__construct() must be an instance of Title, null given {"exception":"[object] (Flow\\Exception\\CatchableFatalErrorException(code: 0): Argument 6 passed to Flow\\Model\\WikiReference::__construct() must be an instance of Title, null given at /srv/mediawiki/php-1.26wmf16/extensions/Flow/includes/Model/WikiReference.php:35)"}

This seems to be a problem caused by https://gerrit.wikimedia.org/r/#/c/213348/

Details

SubjectRepoBranchLines +/-
Enhance debug log output for stacktracesmediawiki/coremaster+143 -43
HHVM: enable user handler for fatalsmediawiki/vagrantmaster+2 -0
logging: Enable stacktrace printingoperations/mediawiki-configmaster+2 -1
Monolog: Add Formatter that uses MWExceptionHandler::getRedactedTraceAsStringmediawiki/corewmf/1.26wmf16+157 -1
Monolog: Add Formatter that uses MWExceptionHandler::getRedactedTraceAsStringmediawiki/coremaster+157 -1
ObjectFactory: add support for setter injectionmediawiki/coremaster+63 -11
ObjectFactory: add support for setter injectionmediawiki/corewmf/1.26wmf16+63 -11
Customize query in gerrit

Related Objects

Event Timeline

bd808 created this task.Jul 30 2015, 4:41 PM
bd808 claimed this task.
bd808 raised the priority of this task from to High.
bd808 updated the task description. (Show Details)
bd808 added a project: MediaWiki-Debug-Logger.
bd808 added subscribers: bd808, Legoktm.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2015, 4:41 PM
bd808 added a comment.Jul 30 2015, 4:45 PM

herp derp. We don't use LegacyLogger in WMF production. I need to update the WMF config to configure Monolog\Formatter\LineFormatter to print stack traces.

gerritbot subscribed.Jul 30 2015, 5:26 PM

Change 228020 had a related patch set uploaded (by BryanDavis):
ObjectFactory: add support for setter injection

https://gerrit.wikimedia.org/r/228020

gerritbot added a project: Patch-For-Review.Jul 30 2015, 5:26 PM
gerritbot added a comment.Jul 30 2015, 5:32 PM

Change 228022 had a related patch set uploaded (by Legoktm):
ObjectFactory: add support for setter injection

https://gerrit.wikimedia.org/r/228022

gerritbot added a comment.Jul 30 2015, 5:34 PM

Change 228023 had a related patch set uploaded (by BryanDavis):
logging: Enable stacktrace printing

https://gerrit.wikimedia.org/r/228023

gerritbot added a comment.Jul 30 2015, 5:40 PM

Change 228020 merged by jenkins-bot:
ObjectFactory: add support for setter injection

https://gerrit.wikimedia.org/r/228020

gerritbot added a comment.Jul 30 2015, 5:42 PM

Change 228022 abandoned by Legoktm:
ObjectFactory: add support for setter injection

https://gerrit.wikimedia.org/r/228022

• Forrestbot added projects: MW-1.26-release, WMF-deploy-2015-08-04_(1.26wmf17).Jul 30 2015, 6:00 PM
gerritbot added a comment.Jul 30 2015, 7:06 PM

Change 228053 had a related patch set uploaded (by BryanDavis):
Monolog: Add Formatter that uses MWExceptionHandler::getRedactedTraceAsString

https://gerrit.wikimedia.org/r/228053

bd808 mentioned this in rMWe53600c4b647: ObjectFactory: add support for setter injection.Jul 30 2015, 10:15 PM
gerritbot added a comment.Jul 31 2015, 7:52 PM

Change 228053 merged by jenkins-bot:
Monolog: Add Formatter that uses MWExceptionHandler::getRedactedTraceAsString

https://gerrit.wikimedia.org/r/228053

bd808 mentioned this in rMW27dcc9f05182: Monolog: Add Formatter that uses MWExceptionHandler::getRedactedTraceAsString.Jul 31 2015, 7:52 PM
gerritbot added a comment.Aug 3 2015, 4:39 PM

Change 228850 had a related patch set uploaded (by Legoktm):
Monolog: Add Formatter that uses MWExceptionHandler::getRedactedTraceAsString

https://gerrit.wikimedia.org/r/228850

gerritbot added a comment.Aug 3 2015, 4:52 PM

Change 228850 merged by jenkins-bot:
Monolog: Add Formatter that uses MWExceptionHandler::getRedactedTraceAsString

https://gerrit.wikimedia.org/r/228850

Legoktm mentioned this in rMW22ca12f576fd: Monolog: Add Formatter that uses MWExceptionHandler::getRedactedTraceAsString.Aug 3 2015, 4:52 PM
• Forrestbot added a project: WMF-deploy-2015-07-28_(1.26wmf16).Aug 3 2015, 5:00 PM
gerritbot added a comment.Aug 3 2015, 5:02 PM

Change 228023 merged by jenkins-bot:
logging: Enable stacktrace printing

https://gerrit.wikimedia.org/r/228023

Legoktm mentioned this in rOMWC0dad04de83fa: logging: Enable stacktrace printing.Aug 3 2015, 5:02 PM
gerritbot added a comment.Aug 25 2015, 5:55 PM

Change 233758 had a related patch set uploaded (by BryanDavis):
HHVM: enable user handler for fatals

https://gerrit.wikimedia.org/r/233758

gerritbot added a comment.Aug 25 2015, 6:03 PM

Change 233758 merged by jenkins-bot:
HHVM: enable user handler for fatals

https://gerrit.wikimedia.org/r/233758

bd808 mentioned this in rMWVA2c74d4f77447: HHVM: enable user handler for fatals.Aug 25 2015, 6:08 PM
gerritbot added a comment.Aug 25 2015, 11:56 PM

Change 233590 had a related patch set uploaded (by BryanDavis):
Enhance debug log output for stacktraces

https://gerrit.wikimedia.org/r/233590

gerritbot added a comment.Sep 8 2015, 8:55 AM

Change 233590 merged by jenkins-bot:
Enhance debug log output for stacktraces

https://gerrit.wikimedia.org/r/233590

Tgr mentioned this in rMWba1835f159b2: Enhance debug log output for stacktraces.Sep 8 2015, 8:55 AM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-08_(1.26wmf22).Sep 8 2015, 9:00 AM
Krinkle subscribed.Sep 27 2015, 6:26 PM

Status?

bd808 closed this task as Resolved.Oct 7 2015, 10:24 PM

I just checked exception.log on fluorine and it looks like all of the logged exceptions now have stacktrace information associated with them.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits