Page MenuHomePhabricator
Create Task
Maniphest T103796

Unable to create item when other users are flooding
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

When a user is creating a lot of items at one time (flooding), it's not possible for other users to create just one item. The special page will give a confusing error (page already exists). According to @hoo, https://gerrit.wikimedia.org/r/#/c/220551/ will fix this.

Details

SubjectRepoBranchLines +/-
Use FOR UPDATE when selecting ids in SqlIdGeneratormediawiki/extensions/Wikibasewmf/1.26wmf9+3 -1
Use FOR UPDATE when selecting ids in SqlIdGeneratormediawiki/extensions/Wikibasemaster+3 -1
Customize query in gerrit

Related Objects

Event Timeline

Sjoerddebruin created this task.Jun 25 2015, 7:19 AM
Sjoerddebruin raised the priority of this task from to High.
Sjoerddebruin updated the task description. (Show Details)
Sjoerddebruin added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.
Sjoerddebruin added subscribers: Sjoerddebruin, hoo.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 25 2015, 7:19 AM
gerritbot subscribed.Jun 25 2015, 9:25 AM

Change 220551 had a related patch set uploaded (by Hoo man):
Use FOR UPDATE when selecting ids in SqlIdGenerator

https://gerrit.wikimedia.org/r/220551

gerritbot added a project: Patch-For-Review.Jun 25 2015, 9:25 AM
Lydia_Pintscher assigned this task to hoo.Jun 25 2015, 9:33 AM
Lydia_Pintscher added a project: Wikidata-Sprint-2015-06-16.
Lydia_Pintscher set Security to None.
Lydia_Pintscher edited a custom field.
Lydia_Pintscher moved this task from Backlog to Review on the Wikidata-Sprint-2015-06-16 board.
Lydia_Pintscher subscribed.
Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.Jun 25 2015, 10:04 AM
gerritbot added a comment.Jun 25 2015, 11:12 AM

Change 220551 merged by jenkins-bot:
Use FOR UPDATE when selecting ids in SqlIdGenerator

https://gerrit.wikimedia.org/r/220551

Diffusion mentioned this in rMEXTa39344a56703: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Jun 25 2015, 11:12 AM
hoo mentioned this in rEWBA2a0ac44f2e5f: Use FOR UPDATE when selecting ids in SqlIdGenerator.Jun 25 2015, 11:12 AM
hoo closed this task as Resolved.Jun 25 2015, 11:19 AM

Fixed on master, will probably backport this later today.

hoo removed a project: Patch-For-Review.Jun 25 2015, 11:19 AM
hoo moved this task from Review to Done on the Wikidata-Sprint-2015-06-16 board.
Addshore subscribed.Jun 25 2015, 11:26 AM
gerritbot added a comment.Jun 25 2015, 5:12 PM

Change 220824 had a related patch set uploaded (by Hoo man):
Use FOR UPDATE when selecting ids in SqlIdGenerator

https://gerrit.wikimedia.org/r/220824

gerritbot added a project: Patch-For-Review.Jun 25 2015, 5:12 PM
gerritbot added a comment.Jun 25 2015, 7:31 PM

Change 220824 merged by jenkins-bot:
Use FOR UPDATE when selecting ids in SqlIdGenerator

https://gerrit.wikimedia.org/r/220824

hoo mentioned this in rEWBAbacf6c07b3df: Use FOR UPDATE when selecting ids in SqlIdGenerator.Jun 25 2015, 7:32 PM
Ricordisamoa removed a project: Patch-For-Review.Jun 28 2015, 6:50 PM
Ricordisamoa subscribed.
Bugreporter merged a task: T52940: action=wbeditentity for creation fails randomly with error edit-already-exists.Jun 29 2015, 6:12 AM
Bugreporter added subscribers: Bugreporter, liangent, • Wikidata-bugs and 2 others.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits