Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Disable binary downloads #14034

Closed
wants to merge 1 commit into from
Closed

Conversation

mikayla-maki
Copy link
Contributor

@mikayla-maki mikayla-maki commented Jul 9, 2024

fixes #12589 #12354

follow up to #12703

TODO:

  • Implement a setting for globally enabling / disabling binary downloads
    • Node
    • Supermaven & Copilot
    • Built in and extension LSP binaries
  • Report appropriate errors to the user when downloads are blocked this way
  • Add this setting to the welcome page, so users have a chance to disable it before continuing.

Release Notes:

  • TODO

Co-Authored-By: Mikayla <[email protected]>
Co-Authored-By: Marshall <[email protected]>
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jul 9, 2024
@mikayla-maki mikayla-maki changed the title Disable binary downloads WIP: Disable binary downloads Jul 9, 2024
@darix
Copy link

darix commented Jul 9, 2024

please document how distribution packagers can tell zed where to find the distro versions of the binaries/extensions that you want to use. so we can cover the needed dependencies with packaging.

@WeetHet
Copy link
Contributor

WeetHet commented Jul 10, 2024

I think it would be actually nicer to show a notification when trying to download a binary, so the user can agree or disagree in that moment

@imbev
Copy link

imbev commented Jul 10, 2024

please document how distribution packagers can tell zed where to find the distro versions of the binaries/extensions that you want to use. so we can cover the needed dependencies with packaging.

The Flatpak package would be a good place to demonstrate this

@mikayla-maki
Copy link
Contributor Author

I think it would be actually nicer to show a notification when trying to download a binary, so the user can agree or disagree in that moment

This will be rolled into an additional and separate change, when we finish our extension system.

@Xinayder
Copy link

Xinayder commented Jul 11, 2024

Is there any particular reason why this setting is opt-out and not opt-in? It's interesting to see it being handled this way. Plus, looking at the current state, it seems like the user won't be able to choose whether to download missing binary packages or not, i.e., if you opt-out for automatic binary downloads you'll have to install them manually.

Wouldn't a system like VS Code's be better in this case? Either block all downloads, or allow the user to choose if they want to download required binary packages for extensions when they first open a project (and have a third option to just install them automatically)?

@mikayla-maki
Copy link
Contributor Author

mikayla-maki commented Jul 23, 2024

For future reference, this PR has not been abandoned. I got Covid shortly after the Linux launch, and haven't been able to write code for a while. This should be finished in the next few weeks, as I recover. We'll be incorporating the feedback here and in other places when we restart this work.

@zed-industries zed-industries locked as off-topic and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zed downloads NodeJS binary and npm packages from Internet without user’s consent
8 participants