Skip to content

Commit

Permalink
Allow requestFullscreen() to be called from an orientation change event
Browse files Browse the repository at this point in the history
Note that this flow of changes, requesting fullscreen from the orientation change event, can result in a "bad frame", an inbetween state that's not necessarily desired. Implementers found this acceptable.

Fixes #34.
  • Loading branch information
mounirlamouri authored and annevk committed Jul 21, 2016
1 parent 9592913 commit e5e96a9
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 7 deletions.
17 changes: 13 additions & 4 deletions Overview.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

<hgroup>
<h1 class="p-name">Fullscreen API</h1>
<h2 class="no-num no-toc">Living Standard — Last Updated 20 July 2016</h2>
<h2 class="no-num no-toc">Living Standard — Last Updated 21 July 2016</h2>
</hgroup>

<dl>
Expand Down Expand Up @@ -195,6 +195,15 @@ <h2 id="model"><span class="secno">3 </span>Model</h2>

<p><dfn id="fullscreen-is-supported">Fullscreen is supported</dfn> if there is no previously-established user
preference, security risk, or platform limitation.

<p>An algorithm is <dfn id="allowed-to-request-fullscreen">allowed to request fullscreen</dfn> if one of the following is true:

<ul>
<li><p>The algorithm is <a class="external" data-anolis-spec="html" href="https://html.spec.whatwg.org/multipage/interaction.html#triggered-by-user-activation">triggered by user activation</a>.

<li><p>The algorithm is
<a class="external" data-anolis-spec="screen-orientation" href="https://w3c.github.io/screen-orientation/#dfn-triggered-by-a-user-generated-orientation-change">triggered by a user generated orientation change</a>.
</ul>
<!-- cross-process -->


Expand Down Expand Up @@ -281,10 +290,9 @@ <h2 id="api"><span class="secno">4 </span>API</h2>
<li><p>The <a href="#fullscreen-element-ready-check">fullscreen element ready check</a> for <var title="">pending</var>
returns false.

<li><p>This algorithm is not
<a class="external" data-anolis-spec="html" href="https://html.spec.whatwg.org/multipage/browsers.html#allowed-to-show-a-popup">allowed to show a popup</a>.

<li><p><a href="#fullscreen-is-supported" title="Fullscreen is supported">Fullscreen is <em>not</em> supported</a>.

<li><p>This algorithm is not <a href="#allowed-to-request-fullscreen">allowed to request fullscreen</a>.
</ul>

<li><p>Return <var>promise</var>, and run the remaining steps
Expand Down Expand Up @@ -750,6 +758,7 @@ <h2 class="no-num" id="acknowledgments">Acknowledgments</h2>
Josh Soref,
Matt Falkenhagen,
Mihai Balan,
Mounir Lamouri,
Øyvind Stenhaug,
Pat Ladd,
Philip Jägenstedt,
Expand Down
15 changes: 12 additions & 3 deletions Overview.src.html
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,15 @@ <h2>Model</h2>

<p><dfn>Fullscreen is supported</dfn> if there is no previously-established user
preference, security risk, or platform limitation.

<p>An algorithm is <dfn>allowed to request fullscreen</dfn> if one of the following is true:

<ul>
<li><p>The algorithm is <span data-anolis-spec=html>triggered by user activation</span>.

<li><p>The algorithm is
<span data-anolis-spec=screen-orientation>triggered by a user generated orientation change</span>.
</ul>
<!-- cross-process -->


Expand Down Expand Up @@ -266,10 +275,9 @@ <h2>API</h2>
<li><p>The <span>fullscreen element ready check</span> for <var title>pending</var>
returns false.

<li><p>This algorithm is not
<span data-anolis-spec=html>allowed to show a popup</span>.

<li><p><span title="Fullscreen is supported">Fullscreen is <em>not</em> supported</span>.

<li><p>This algorithm is not <span>allowed to request fullscreen</span>.
</ul>

<li><p>Return <var>promise</var>, and run the remaining steps
Expand Down Expand Up @@ -714,6 +722,7 @@ <h2 class=no-num>Acknowledgments</h2>
Josh Soref,
Matt Falkenhagen,
Mihai Balan,
Mounir Lamouri,
Øyvind Stenhaug,
Pat Ladd,
Philip Jägenstedt,
Expand Down

0 comments on commit e5e96a9

Please sign in to comment.