Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drafting the patches to HTML #106

Closed
jakearchibald opened this issue Aug 6, 2015 · 8 comments
Closed

Drafting the patches to HTML #106

jakearchibald opened this issue Aug 6, 2015 · 8 comments

Comments

@jakearchibald
Copy link
Collaborator

Given the recent confusion on navigation, now sounds like the right time to draft up a table, or patches for fetches.

Happy to do the work here, but @wanderview, you said you had a list of things that fetch to use as a starting point?

@jakearchibald
Copy link
Collaborator Author

Notes:

  • I'm mapping "synchronous" to the blocking flag in the current html fetch algorithm, which may not be correct

<a ping>

Appacache Manifest check

Appcache resource fetch

CSP violation report

Navigation

Also applies to downloading, view-source.

EventSource

  • Current 'fetch' point: https://html.spec.whatwg.org/#eventsourceinit 7
  • client: from current environment settings object
  • synchronous flag: set (although not specified)
  • skip-service-worker flag: unset
  • mode: cors
  • credentials mode: same-origin, or include if withCredentials used in constructor
  • cache mode: no-store (not sure)
  • redirect mode: follow

<audio> and <video>

  • Current 'fetch' point: https://html.spec.whatwg.org/#concept-media-load-resource 4.remote.2
  • client: from current environment settings object
  • synchronous flag: set
  • skip-service-worker flag: unset
  • mode: no-cors, unless element has crossorigin attr, in which case cors
  • credentials mode: same-origin, unless crossorigin=use-credentials, in which case include
  • cache mode: default
  • redirect mode: follow

This request fails on "error code" responses.

<script>

  • Current 'fetch' point: https://html.spec.whatwg.org/#prepare-a-script 14.5
  • client: from current environment settings object
  • synchronous flag: set
  • skip-service-worker flag: unset
  • mode: no-cors, unless element has crossorigin attr, in which case cors
  • credentials mode: same-origin, unless crossorigin=use-credentials, in which case include
  • cache mode: default
  • redirect mode: follow

This request fails 404 and probably other error-code responses (although only 404 is specified).

<track>

  • Current 'fetch' point: https://html.spec.whatwg.org/#start-the-track-processing-model 10
  • client: from current environment settings object
  • synchronous flag: set
  • skip-service-worker flag: unset
  • mode: no-cors, unless parent media element has crossorigin attr, in which case cors
  • credentials mode: same-origin, unless parent media element has crossorigin=use-credentials, in which case include
  • cache mode: default
  • redirect mode: follow

This request fails on "error code" responses.

More to come…

@horo-t
Copy link

horo-t commented Aug 31, 2015

How about Worker and SharedWorker?
https://html.spec.whatwg.org/#run-a-worker

@annevk
Copy link
Member

annevk commented Sep 3, 2015

I filed whatwg/html#95 on HTML. I hope to work on this soonish, but it seems some more groundwork in Fetch is required first.

@annevk
Copy link
Member

annevk commented Sep 16, 2015

whatwg/html#144 is a rewrite of the text in the HTML Standard. It also addresses workers. Review would be appreciated.

@annevk
Copy link
Member

annevk commented Sep 22, 2015

Note that #126 will change what we do for navigation requests @dstockwell.

I think this should be closed since it's no longer relevant. @jakearchibald?

@dstoc
Copy link

dstoc commented Sep 22, 2015

It's amusing that github wants to give me credit for all blink commits, but that was actually @horo-t

@annevk
Copy link
Member

annevk commented Sep 22, 2015

Ah, @horo-t should probably add "[email protected]" to his GitHub email addresses to rectify that.

@jakearchibald
Copy link
Collaborator Author

Happy to close this

MXEBot pushed a commit to mirror/chromium that referenced this issue Jan 16, 2016
Current:
 mode: "no-cors"
 credentials: "same-origin"
 redirect: "follow"

With this patch:
 mode: "same-origin"
 credentials: "include"
 redirect: "manual"

Spec Issue: whatwg/fetch#106
BUG=522873

Review URL: https://codereview.chromium.org/1320023005

git-svn-id: svn://svn.chromium.org/blink/trunk@202013 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants