Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow offset-position-v as a one component position #809

Closed
nigelmegitt opened this issue Jun 1, 2018 · 1 comment
Closed

Disallow offset-position-v as a one component position #809

nigelmegitt opened this issue Jun 1, 2018 · 1 comment

Comments

@nigelmegitt
Copy link
Contributor

See also #711 and #769.

Currently two options are available for one component <position> values:

<position>
  : offset-position-h                             // single component value
  | offset-position-v                             // single component value

...

offset-position-h
  : position-keyword-h
  | <length>

offset-position-v
  : position-keyword-v
  | <length>

...

position-keyword-h
  : "center"
  | edge-keyword-h

position-keyword-v
  : "center"
  | edge-keyword-v

edge-keyword-h
  : "left"
  | "right"

edge-keyword-v
  : "top"
  | "bottom"

And the table explaining the equivalents of the one component values maps:

  • center -> center center
  • <length> -> <length> center

Both of those mappings indicates that a valid value for an offset-position-v of center or <length> will be interpreted as an offset-position-h. So in those cases the spec is actively misleading in suggesting that a vertical offset value can be used on its own.

The only one component values that are unambiguously vertical positions are top and bottom. Rather than handling those two specific values (which I guess would be rarely used because mostly authors leave a gap at the top or the bottom of the root container region), for simplicity I propose that we remove offset-position-v from the permitted set of one component values.

@skynavga
Copy link
Collaborator

skynavga commented Jun 2, 2018

Rather than dropping single value top and bottom, I suggest we replace offset-position-v with
edge-keyword-v in this context, which will make this an editorial change only.

skynavga added a commit that referenced this issue Jun 2, 2018
@skynavga skynavga removed their assignment Jun 7, 2018
@skynavga skynavga added pr merged and removed pr open labels Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants