Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hasEnrolledInstrument() from version 1.0 #930

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Remove hasEnrolledInstrument() from version 1.0 #930

merged 1 commit into from
Oct 5, 2020

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Sep 15, 2020 •
edited by pr-preview bot
Loading

closes #926

The following tasks have been completed:

  • Confirmed there are no ReSpec errors/warnings.
  • [Modified Web platform tests] - tests in payment-request for hasEnrolledInstrument are all tentative.
  • Modified MDN Docs (link)
  • Has undergone security/privacy review (link)

Implementation commitment:

  • Safari - Not implemented.
  • Chrome
  • Firefox - Not implemented.

Optional, impact on Payment Handler spec?
None

Preview | Diff

@ianbjacobs ianbjacobs changed the title Remove hasEnrolledInstrument() Remove hasEnrolledInstrument() from version 1.0 Sep 21, 2020
danyao
danyao reviewed Sep 21, 2020
View reviewed changes
index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
@ianbjacobs ianbjacobs added a11y-tracker Group bringing to attention of a11y, or tracked by the a11y Group but not needing response. i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response. privacy-tracker Group bringing to attention of Privacy, or tracked by the Privacy Group but not needing response. security-tracker Group bringing to attention of security, or tracked by the security Group but not needing response. tag-tracker Group bringing to attention of the TAG, or tracked by the TAG but not needing response. labels Sep 21, 2020
This was referenced Sep 24, 2020
Closed
Closed
danyao
danyao reviewed Sep 28, 2020
View reviewed changes
index.html Outdated Show resolved Hide resolved
This was referenced Sep 28, 2020
Open
Closed
Open
@michael-n-cooper
Copy link
Member

No comments from APA.

@marcoscaceres
Copy link
Member Author

marcoscaceres commented Oct 5, 2020 •
edited
Loading

@danyao, should be good to go - Just need a ✅ from you or @ianbjacobs to merge.

The diff has also been fixed up - there was a stray <section> that would making the changes look bigger than they actually were. My bad!

danyao
danyao approved these changes Oct 5, 2020
View reviewed changes
Copy link
Collaborator

@danyao danyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcoscaceres marcoscaceres merged commit f697360 into gh-pages Oct 5, 2020
@marcoscaceres marcoscaceres deleted the hasEnrolledInstrument branch October 5, 2020 13:07
marcoscaceres added a commit that referenced this pull request Oct 7, 2020
@marcoscaceres
Add hasEnrolledInstrument() again
bf05cc9 
Revert "Remove hasEnrolledInstrument() (#930)"

This reverts commit f697360.
@marcoscaceres marcoscaceres mentioned this pull request Oct 7, 2020
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyao danyao danyao approved these changes

Assignees
No one assigned
Labels
a11y-tracker Group bringing to attention of a11y, or tracked by the a11y Group but not needing response. i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response. privacy-tracker Group bringing to attention of Privacy, or tracked by the Privacy Group but not needing response. security-tracker Group bringing to attention of security, or tracked by the security Group but not needing response. tag-tracker Group bringing to attention of the TAG, or tracked by the TAG but not needing response.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark hasEnrolledInstrument() at risk?
4 participants
@marcoscaceres @michael-n-cooper @danyao @ianbjacobs