Deprecate allowpaymentrequest attribute #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good (but I am not an implementer). |
You are an honorary implementer 😂 |
|
I'm going to migrate the WPTests to use |
|
Updated tests at web-platform-tests/wpt#25560 |
annevk
pushed a commit
to whatwg/html
that referenced
this pull request
Sep 16, 2020
danyao
requested changes
Sep 16, 2020
stephenmcgruer
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 19, 2020
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 23, 2020
…low=payment, a=testonly Automatic update from web-platform-tests Replace allowpaymentrequest attr with allow=payment (#25560) Tests for w3c/payment-request#928 -- wpt-commits: aa0d5711933473ebd2c10d169edb259f08d1136b wpt-pr: 25560
sidvishnoi
pushed a commit
to sidvishnoi/gecko-webmonetization
that referenced
this pull request
Sep 24, 2020
…low=payment, a=testonly Automatic update from web-platform-tests Replace allowpaymentrequest attr with allow=payment (#25560) Tests for w3c/payment-request#928 -- wpt-commits: aa0d5711933473ebd2c10d169edb259f08d1136b wpt-pr: 25560
mfreed7
pushed a commit
to mfreed7/html
that referenced
this pull request
Sep 25, 2020
mfreed7
pushed a commit
to mfreed7/html
that referenced
this pull request
Sep 25, 2020
mfreed7
pushed a commit
to mfreed7/html
that referenced
this pull request
Sep 25, 2020
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Sep 28, 2020
…low=payment, a=testonly Automatic update from web-platform-tests Replace allowpaymentrequest attr with allow=payment (#25560) Tests for w3c/payment-request#928 -- wpt-commits: aa0d5711933473ebd2c10d169edb259f08d1136b wpt-pr: 25560 UltraBlame original commit: 4afcc2d6ffce639a37e26154f4441750d65cb678
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Sep 28, 2020
…low=payment, a=testonly Automatic update from web-platform-tests Replace allowpaymentrequest attr with allow=payment (#25560) Tests for w3c/payment-request#928 -- wpt-commits: aa0d5711933473ebd2c10d169edb259f08d1136b wpt-pr: 25560 UltraBlame original commit: 4afcc2d6ffce639a37e26154f4441750d65cb678
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Sep 28, 2020
…low=payment, a=testonly Automatic update from web-platform-tests Replace allowpaymentrequest attr with allow=payment (#25560) Tests for w3c/payment-request#928 -- wpt-commits: aa0d5711933473ebd2c10d169edb259f08d1136b wpt-pr: 25560 UltraBlame original commit: 4afcc2d6ffce639a37e26154f4441750d65cb678
sideshowbarker
added a commit
to w3c/browser-compat-data
that referenced
this pull request
Oct 12, 2020
This change marks the allowPaymentRequest property of the HTMLIFrameElement interface standard_track:false and deprecated:true. The allowPaymentRequest property was removed from the Payment Request spec: * w3c/payment-request#928 * w3c/payment-request@a4f35e3 https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement/allowPaymentRequest already updated.
ddbeck
pushed a commit
to mdn/browser-compat-data
that referenced
this pull request
Oct 15, 2020
This change marks the allowPaymentRequest property of the HTMLIFrameElement interface standard_track:false and deprecated:true. The allowPaymentRequest property was removed from the Payment Request spec: * w3c/payment-request#928 * w3c/payment-request@a4f35e3 https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement/allowPaymentRequest already updated.
|
@stephenmcgruer, seems Chrome night not have gotten updated to match? (the allowpaymentrequest attribute was removed from HTML a few years ago) https://bugs.chromium.org/p/chromium/issues/detail?id=1127988 |
|
Hey Marcos - yes, we tried to remove allowpaymentrequest previously, but found that usage was too high for a trivial removal. (This is the UseCounter). I admit we then put it aside and failed to come back to it :(, but the next steps for us are to dig into cases where the metric triggers to see if we can identify ways to drive it down. This is tracked in https://crbug.com/1127988 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #925
The following tasks have been completed:
Implementation commitment:
Optional, impact on Payment Handler spec?
None.
Waiting on:
whatwg/html#5915
w3c/webappsec-permissions-policy#402
Preview | Diff