Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recommendation to localize sheet based on body element #896

Merged
merged 2 commits into from
Feb 12, 2020

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Jan 24, 2020

closes #895

The following tasks have been completed:

  • Confirmed there are no ReSpec errors/warnings.

Optional, impact on Payment Handler spec?

None.


Preview | Diff

@marcoscaceres
Copy link
Member Author

@janiceshiu, when you can, could you check this to see if it makes sense (and for typos/grammar)? Thanks! 🙏

Copy link
Contributor

@janiceshiu janiceshiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be lovely to get some things clarified. also suggested some rewordings to make the text clearer ^^

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@marcoscaceres
Copy link
Member Author

@ianbjacobs, over to you for a final read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the user interface's language should not be derived from the body element
3 participants