Check doc fully active during response.complete() #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
approved these changes
Jul 9, 2018
index.html
Outdated
| </li> | ||
| </ol> | ||
| </li> | ||
| <li>Otherwise, close down any remaining user interface. The <a>user |
There was a problem hiding this comment.
Maybe all three of these steps should be under "otherwise"? Doesn't actually have normative impact, but seems cleaner.
797538b
to
3a59c2f
Compare
3a59c2f
to
5230551
Compare
|
Tested as part of web-platform-tests/wpt#11101 which is still in review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #731
The following tasks have been completed:
Preview | Diff