Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] CSSMathClamp’s min and max props conflict with CSSNumericValue’s methods #855

Closed
miyaokamarina opened this issue Jan 31, 2019 · 3 comments

Comments

@miyaokamarina
Copy link

CSSMathClamp’s min and max attributes are incompatible with CSSNumericValue’s methods min and max.

This design violates the Liskov substitution principle. Also current version of the interface cannot be properly typed with TypeScript and Flow.

Possible compatible names for these attributes are lower and upper.

@tabatkins
Copy link
Member

Ah, indeed, that's a silly mistake on my part. It doesnt' just violate Liskov, it violates WebIDL!

@jodinathan
Copy link

is this going to be fixed?
shouldn't have min and max as operation and attribute =/

@tabatkins
Copy link
Member

Thanks for the ping! Fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants