Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a new MediaGallery type #2139

Closed
vholland opened this issue Feb 7, 2019 · 6 comments
Closed

Create a new MediaGallery type #2139

vholland opened this issue Feb 7, 2019 · 6 comments
Assignees
@vholland

Comments

@vholland
Copy link
Contributor

vholland commented Feb 7, 2019

Schema.org has http://schema.org/ImageGallery, but increasingly pages are collections of mixed-media. It would be nice to have http://schema.org/MediaGallery for this use case. ImageGallery could then be made a subtype of MediaGallery.
@vholland vholland self-assigned this Feb 7, 2019
@danbri
Copy link
Contributor

danbri commented Feb 20, 2019

We should do this!

Can we say anything about how MediaGallery and MediaObject relate? A mixed-media e.g. JSON-LD example would be great.

@danbri
Copy link
Contributor

danbri commented Feb 20, 2019

Would ImageGallery be subtype of MediaGallery?

@gmackenz
Copy link
Contributor

gmackenz commented Feb 20, 2019 •
edited
Loading

Yes, a subtype (see vhollands post above)

@danbri
Copy link
Contributor

danbri commented Feb 20, 2019

Ah I missed that sentence, thanks @gmackenz!

@gmackenz gmackenz mentioned this issue Oct 21, 2019
Merged
@gmackenz
Copy link
Contributor

gmackenz commented Oct 21, 2019 •
edited
Loading

I'm almost certain I did this wrong @danbri @vholland , where should have the commits been be set to push to? Certainly not schemaorg:master... Been too long since I've edited in Schema.Org (or used GitHub).

@gmackenz gmackenz mentioned this issue Dec 21, 2019
Closed
16 tasks
danbri pushed a commit that referenced this issue Jan 2, 2020
@gmackenz @danbri
MediaGallery (#2371)
3173b12 
* Add new MediaGallery type

From proposal #2139 

Creating a new parent type, MediaGallery for the subtypes of ImageGallery and VideoGallery, to allow for a mixed-media collection page type.

* Subtypes for MediaGallery

Making IMageGallery and VideoGallery subtypes of MediaGallery

* Fixing mistaken entry from earlier commit
@vholland
Copy link
Contributor Author

Included in schema.org 6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vholland vholland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danbri @gmackenz @vholland