Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds device type for iPhone X #5683

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Adds device type for iPhone X #5683

merged 1 commit into from
Nov 28, 2017

Conversation

mneudert
Copy link
Member

No description provided.

@mneudert
Copy link
Member Author

Probably needs an additional run of the fixture sorter as the device should now migrate from unknown.yml to phablet.yml. Depending on the general size classification it could of course also be defined as a smartphone...

@mneudert mneudert force-pushed the iphone-x-device-type branch from f156458 to b31b50b Compare November 18, 2017 16:44
@coveralls
Copy link

coveralls commented Nov 18, 2017

Coverage Status

Coverage remained the same at 97.949% when pulling b31b50b on iphone-x-device-type into 12adf85 on master.

@matomo-org matomo-org deleted a comment from coveralls Nov 19, 2017
@sanchezzzhak
Copy link
Collaborator

sanchezzzhak commented Nov 20, 2017

what user-agent when the browser?
change RegExp- this will work only for FB APP (

Mozilla/5.0 (iPhone; CPU iPhone OS 11_1 like Mac OS X) AppleWebKit/604.3.5 (KHTML, like Gecko) Mobile/15B86 [FBAN/FBIOS;FBAV/144.0.0.55.89;FBBV/74129168;FBDV/iPhone10,3;FBMD/iPhone;FBSN/iOS;FBSV/11.1;FBSS/3;FBCR/AT&T;FBID/phone;FBLC/en_US;FBOP/5;FBRV/74129168]

RTFM MDN
User-Agent: Mozilla/<version> (<system-information>) <platform> (<platform-details>) <extensions>

iPhone OS 11 = Iphone X 70%

IOS 11 support models
iPhone 7, iPhone 7 Plus, iPhone 6s, iPhone 6s Plus, iPhone 6, iPhone 6 Plus, iPhone SE, iPhone 5s, iPad

iPad (9,7), iPad Pro (9,7), iPad Pro (12,9), 2017 iPad Pro (), 2017 iPad Pro (10,5), iPad mini 4, iPad mini 3
iPad mini 2, iPad Air 2, iPad Air, iPod touch, iPod touch 6G

devilish apple((

@sgiehl sgiehl merged commit a4841f5 into master Nov 28, 2017
@mneudert mneudert deleted the iphone-x-device-type branch November 28, 2017 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants