-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: RingsPy: A Python package for Voronoi mesh generation of cellular solids with radial growth pattern #4945
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
|
Wordcount for |
@niallmadden, @yg42, @mahtab-vafaee thanks for agreeing to review this work for JOSS!!!!!!!!! This is where the review takes place which you may now commence. You can comment |
Review checklist for @yg42Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Dear all, thanks for agreeing to review my paper! May I request, to review version v0.3.4 (latest version) of RingsPy? In that version, I attached a few new functionalities including saving/reading generated Voronoi cell nuclei, etc. I appreciate that in advance! (@Kevin-Mattheus-Moerman what else should I do in order to update the software version in the reviewing process?) |
@editorialbot set v0.3.4 as version |
Done! version is now v0.3.4 |
@kingyin3613 I've changed the version tag and since you've alerted the reviewers we should be all set. Let me know if the tag chances again during this review. |
Thanks! |
Review checklist for @mahtab-vafaeeConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@niallmadden, @yg42, @mahtab-vafaee thanks again for agreeing to review this submission for JOSS. Could you provide an update on how you are getting on, or if you have not started yet, when you think you'll pick this up? thanks |
@kevin, I'll start working on it next week. I'll create an issue if anything come up. Thanks. |
@Kevin-Mattheus-Moerman I've set some time aside for it next week too. |
Review checklist for @niallmaddenConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
This does not work for me: "pip install" without error, but tests fail - No module named 'RingsPy' |
@editorialbot remove @yg42 as reviewer |
@yg42 removed from the reviewers list! |
@niallmadden @mahtab-vafaee thanks again for your help here. Can you provide an update on review progress? Thanks. |
@Kevin-Mattheus-Moerman I had a problem with the installation. It's now working and I'm running/checking the codes. |
Same here, and informed the authors. kingyin3613/ringspy#1 Will finish the review Tuesday. |
@kingyin3613 Thanks for the update. |
@editorialbot generate pdf |
@niallmadden @mahtab-vafaee thanks for the constructive and timely reviews, as well as the final recommendation for acceptance! and @Kevin-Mattheus-Moerman thanks for helping out here with everything! |
@editorialbot check references |
|
@kingyin3613 now that both reviewers are happy we'll process this work for acceptance in JOSS. Below are some steps that require your attention.
After you've completed the above ☝️, Please work on the following:
|
Thanks @Kevin-Mattheus-Moerman! I have corrected the nation name in the paper and the software has been archived. The archive DOI is: |
@editorialbot set 10.5281/zenodo.7703344 as archive |
Done! Archive is now 10.5281/zenodo.7703344 |
@editorialbot set v1.0.2 as version |
Done! version is now v1.0.2 |
@editorialbot generate pdf |
@editorialbot recommend-accept |
|
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4020, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@kingyin3613 congratulations on this publication in JOSS! 🥳 A special thanks goes to the reviewers @niallmadden and @mahtab-vafaee !!!! 🎉 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @kingyin3613 (Hao Yin)
Repository: https://github.com/kingyin3613/RingsPy
Branch with paper.md (empty if default branch):
Version: v1.0.2
Editor: @Kevin-Mattheus-Moerman
Reviewers: @niallmadden, @mahtab-vafaee
Archive: 10.5281/zenodo.7703344
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@niallmadden & @yg42 & @mahtab-vafaee, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @Kevin-Mattheus-Moerman know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @yg42
📝 Checklist for @mahtab-vafaee
📝 Checklist for @niallmadden
The text was updated successfully, but these errors were encountered: