Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/pm-17-source-unit-test #32

Merged
merged 4 commits into from
Jan 12, 2022
Merged

Conversation

joshxfi
Copy link
Member

@joshxfi joshxfi commented Jan 12, 2022

@joshxfi joshxfi added the feature New feature label Jan 12, 2022
@github-actions
Copy link

github-actions bot commented Jan 12, 2022

size-limit report 📦

Path Size
dist/paymongo.js.cjs.production.min.js 10.48 KB (0%)
dist/paymongo.js.esm.js 10.76 KB (0%)

Copy link
Member

@princejoogie princejoogie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

can you also add a comment in readme in the type

type: "card", // card | paymaya

Comment on lines 3 to 4
const successUrl = "http://localhost:3000/gcash/success";
const failedUrl = "http://localhost:3000/gcash/failed";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change urls to https://example.com/

@joshxfi
Copy link
Member Author

joshxfi commented Jan 12, 2022

@princejoogie pushed requested changes

@princejoogie princejoogie merged commit d71ef8f into dev Jan 12, 2022
@princejoogie princejoogie deleted the feat/pm-17-source-unit-test branch January 12, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants