Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement errata v4 for OCPP 1.6 #57

Closed
darander opened this issue Dec 4, 2019 · 0 comments · Fixed by #58
Closed

Implement errata v4 for OCPP 1.6 #57

darander opened this issue Dec 4, 2019 · 0 comments · Fixed by #58
Assignees
@darander
Labels
enhancement New feature or request

Comments

@darander
Copy link
Contributor

darander commented Dec 4, 2019

In the OCPP 1.6 schemas for MeterValues.req, OCA misspelled Celsius as Celcius.

In the OCPP 1.6 erratas, the recommended action to handle this is:

  • For ChargingStations: send Celsius (ie the correct spelling), Celcius is also allowed.
  • For CentralSystems: accept both Celsius and Celcius.

There are new schema files available from OCA.
darander added a commit to darander/ocpp that referenced this issue Dec 4, 2019
@darander
Updating to the new versions OCPP1.6 schemas
eb52d18 
OCA has released new versions of the OCPP1.6 schemas together
with erratas.

This is the latest version.

Fixes mobilityhouse#57 (adding Celsius with correct spelling) and more.

Signed-off-by: Anders Darander <[email protected]>
@darander darander mentioned this issue Dec 4, 2019
Merged
@OrangeTux OrangeTux added the enhancement New feature or request label Dec 4, 2019
darander added a commit to darander/ocpp that referenced this issue Dec 5, 2019
@darander
Updating to the new versions OCPP1.6 schemas
da5b29e 
OCA has released new versions of the OCPP1.6 schemas together
with erratas.

This is the latest version.

Fixes mobilityhouse#57 (adding Celsius with correct spelling) and more.

Signed-off-by: Anders Darander <[email protected]>
@OrangeTux OrangeTux changed the title Both Celcius and Celsius should be accepted by the validation Implement errata v4 for OCPP 1.6 Dec 5, 2019
darander added a commit to darander/ocpp that referenced this issue Dec 5, 2019
@darander
Updating to the new versions OCPP1.6 schemas
24852ee 
OCA has released new versions of the OCPP1.6 schemas together
with erratas.

This is the latest version published by OCA on 2019-12-05.
The only modifications from above are:
* Removal of id-fields (not handled by jsonschemas)
* Adding Celsius to the enum in StopTransaction.json.
  This was missed in the schema updates, but is according
  to the errata.

Fixes mobilityhouse#57 (adding Celsius with correct spelling) and more.

Signed-off-by: Anders Darander <[email protected]>
@OrangeTux OrangeTux mentioned this issue Dec 5, 2019
Closed
darander added a commit to darander/ocpp that referenced this issue Dec 6, 2019
@darander
tests/test_messages: make test work with new schemas
da53b04 
test_get_schema_with_valid_name failed with the new schema files, as
additionalProperties were added to more places.

Fix that for mobilityhouse#57.

Signed-off-by: Anders Darander <[email protected]>
OrangeTux pushed a commit that referenced this issue Dec 6, 2019
@darander @OrangeTux
Implement errata v4 for OCPP 1.6
c280a64 
The OCA has released new versions of the OCPP1.6 schemas together
with erratas.

This is the latest version published by OCA on 2019-12-05.

The schemas have manually modified. The following changes have been made:

* Removal of $id fields (not handled by jsonschemas, see commit 079d6a3)
* Adding Celsius to the enum in StopTransaction.json.
  This was missed in the schema updates, but is according
  to the errata.

Fixes #57 

Signed-off-by: Anders Darander <[email protected]>
ajmirsky pushed a commit to ajmirsky/ocpp that referenced this issue Nov 26, 2024
@darander @OrangeTux
Implement errata v4 for OCPP 1.6
23efa42 
The OCA has released new versions of the OCPP1.6 schemas together
with erratas.

This is the latest version published by OCA on 2019-12-05.

The schemas have manually modified. The following changes have been made:

* Removal of $id fields (not handled by jsonschemas, see commit de93ffe)
* Adding Celsius to the enum in StopTransaction.json.
  This was missed in the schema updates, but is according
  to the errata.

Fixes mobilityhouse#57 

Signed-off-by: Anders Darander <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darander darander

Labels
enhancement New feature or request
Milestone
No milestone
4 participants
@darander @OrangeTux @tropxy @laysauchoa