Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the Call.unique_id to the on and after routing handlers. #544

Closed
wafa-yah opened this issue Dec 14, 2023 · 1 comment
Closed

Pass the Call.unique_id to the on and after routing handlers. #544

wafa-yah opened this issue Dec 14, 2023 · 1 comment
Assignees
@wafa-yah
Labels
enhancement New feature or request

Comments

@wafa-yah
Copy link
Contributor

At the level of ChargePoint.handle_call, currently the library only passes the message payload to the _on_action, and _after_action handlers.
For some features like logging the messages being treated by those handlers, it would be nice to pass the Call.unique_id as well.

This will be a breaking change though as all the handlers defined by the library clients should always define call_unique_id in the kwargs, hence the label For inclusion in release 1.0.0
@wafa-yah wafa-yah self-assigned this Dec 14, 2023
@wafa-yah wafa-yah mentioned this issue Dec 14, 2023
Merged
Jared-Newell-Mobility pushed a commit that referenced this issue Jan 17, 2024
@wafa-yah
Add call unique id to handler kwargs (#545)
f32a86d 
Issue Link: #544

The `call_unique_id` is passed to the `on` and `after` handlers only if it is explicitly set in the handler signature.
@Jared-Newell-Mobility
Copy link
Contributor

PR #545 merged into master so will now close

Merged
Jared-Newell-Mobility added a commit that referenced this issue Jan 17, 2024
@Jared-Newell-Mobility
Bump 0.26.0 (#572)
9f1ab29 
- [#544](#544) Pass
`Call.unique_id` to the `on` and `after` routing handlers.
- [#559](#559) Update
project dependencies as of 22-12-2023
- [#447](#447) Make
formatting of enums in py3.11 consistent with earlier Python versions
- [#421](#421) Type of
v16.datatypes.SampledValue.context is incorrect
RoaringDev1203 added a commit to RoaringDev1203/Cratus-OCPP that referenced this issue Aug 27, 2024
@RoaringDev1203
Add call unique id to handler kwargs (#545)
61a2bdb 
Issue Link: mobilityhouse/ocpp#544

The `call_unique_id` is passed to the `on` and `after` handlers only if it is explicitly set in the handler signature.
RoaringDev1203 added a commit to RoaringDev1203/Cratus-OCPP that referenced this issue Aug 27, 2024
@RoaringDev1203
Bump 0.26.0 (#572)
82a0dd0 
- [#544](mobilityhouse/ocpp#544) Pass
`Call.unique_id` to the `on` and `after` routing handlers.
- [#559](mobilityhouse/ocpp#559) Update
project dependencies as of 22-12-2023
- [#447](mobilityhouse/ocpp#447) Make
formatting of enums in py3.11 consistent with earlier Python versions
- [#421](mobilityhouse/ocpp#421) Type of
v16.datatypes.SampledValue.context is incorrect
ajmirsky pushed a commit to ajmirsky/ocpp that referenced this issue Nov 26, 2024
@wafa-yah
Add call unique id to handler kwargs (mobilityhouse#545)
db405d7 
Issue Link: mobilityhouse#544

The `call_unique_id` is passed to the `on` and `after` handlers only if it is explicitly set in the handler signature.
ajmirsky pushed a commit to ajmirsky/ocpp that referenced this issue Nov 26, 2024
@Jared-Newell-Mobility
Bump 0.26.0 (mobilityhouse#572)
f2d93f3 
- [mobilityhouse#544](mobilityhouse#544) Pass
`Call.unique_id` to the `on` and `after` routing handlers.
- [mobilityhouse#559](mobilityhouse#559) Update
project dependencies as of 22-12-2023
- [mobilityhouse#447](mobilityhouse#447) Make
formatting of enums in py3.11 consistent with earlier Python versions
- [mobilityhouse#421](mobilityhouse#421) Type of
v16.datatypes.SampledValue.context is incorrect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wafa-yah wafa-yah

Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jared-Newell-Mobility @wafa-yah