TextSection Color Design Guidance Update Color Contrast #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niels9001
approved these changes
Jun 17, 2024
|
/azp run |
karkarl
added a commit
that referenced
this pull request
Jul 15, 2024
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> Update text color for the tertiary and disabled brush colours to satisfy colour contrast for accessibility: ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> Fixes internal bug: [Bug 51099086](https://dev.azure.com/microsoft/OS/_workitems/edit/51099086): [WinUI 3 Gallery: Design Guidance: Color]: Color contrast ratio for "Text / Disabled" text is 2.77:1 which is less than 4.5:1. ## Screenshots **Before:**  **After:**  ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change)
karkarl
added a commit
that referenced
this pull request
Jul 15, 2024
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> Update text color for the tertiary and disabled brush colours to satisfy colour contrast for accessibility: ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> Fixes internal bug: [Bug 51099086](https://dev.azure.com/microsoft/OS/_workitems/edit/51099086): [WinUI 3 Gallery: Design Guidance: Color]: Color contrast ratio for "Text / Disabled" text is 2.77:1 which is less than 4.5:1. ## Screenshots **Before:**  **After:**  ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update text color for the tertiary and disabled brush colours to satisfy colour contrast for accessibility:
Motivation and Context
Fixes internal bug:
Bug 51099086: [WinUI 3 Gallery: Design Guidance: Color]: Color contrast ratio for "Text / Disabled" text is 2.77:1 which is less than 4.5:1.
Screenshots
Before:
After:
Types of changes