Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: IntuneWindowsAutopilotDeploymentProfile - Initial release #3043

Merged
merged 6 commits into from
Mar 27, 2023
Merged

PR: IntuneWindowsAutopilotDeploymentProfile - Initial release #3043

merged 6 commits into from
Mar 27, 2023

Conversation

William-Francillette
Copy link
Contributor

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

  • IntuneWindowsAutopilotDeploymentProfileAzureADJoined
    • Initial release
      FIXES #2605
  • IntuneWindowsAutopilotDeploymentProfileAzureADHybridJoined
    • Initial release
      FIXES #2605

ykuijs
ykuijs requested changes Mar 18, 2023
View reviewed changes
Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review with some of the comments discussed via email.

Haven't checked everything yet.

...ureADHybridJoined/MSFT_IntuneWindowsAutopilotDeploymentProfileAzureADHybridJoined.schema.mof Show resolved Hide resolved
...65DSC/DSCResources/MSFT_IntuneWindowsAutopilotDeploymentProfileAzureADHybridJoined/readme.md Outdated Show resolved Hide resolved
...C/DSCResources/MSFT_IntuneWindowsAutopilotDeploymentProfileAzureADHybridJoined/settings.json Outdated Show resolved Hide resolved
...entProfileAzureADJoined/MSFT_IntuneWindowsAutopilotDeploymentProfileAzureADJoined.schema.mof Show resolved Hide resolved
...osoft365DSC/DSCResources/MSFT_IntuneWindowsAutopilotDeploymentProfileAzureADJoined/readme.md Outdated Show resolved Hide resolved
...eploymentProfileAzureADJoined/MSFT_IntuneWindowsAutopilotDeploymentProfileAzureADJoined.psm1 Outdated Show resolved Hide resolved
...eploymentProfileAzureADJoined/MSFT_IntuneWindowsAutopilotDeploymentProfileAzureADJoined.psm1 Outdated Show resolved Hide resolved
...eploymentProfileAzureADJoined/MSFT_IntuneWindowsAutopilotDeploymentProfileAzureADJoined.psm1 Outdated Show resolved Hide resolved
...eploymentProfileAzureADJoined/MSFT_IntuneWindowsAutopilotDeploymentProfileAzureADJoined.psm1 Outdated Show resolved Hide resolved
...eploymentProfileAzureADJoined/MSFT_IntuneWindowsAutopilotDeploymentProfileAzureADJoined.psm1 Outdated Show resolved Hide resolved
@William-Francillette
Copy link
Contributor Author

@ykuijs I have modified the DRG and regenerated the code

Can you check it again and let me know if I missed anything please ?
When this PR is ok I'll regenerate IntuneDeviceConfigurationHealthMonitoringConfigurationPolicyWindows10

Changelog:

  • IntuneWindowsAutopilotDeploymentProfileAzureADJoined
    • Initial release
      FIXES #2605
  • IntuneWindowsAutopilotDeploymentProfileAzureADHybridJoined
    • Initial release
      FIXES #2605
  • DRG
    • Various fixes
      Cleanup generated code
      Fix AdditionalProperties complex constructor
      Fix Read privileges in settings file

ykuijs
ykuijs requested changes Mar 27, 2023
View reviewed changes
Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent, just a small comment on the changelog entries

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@William-Francillette
Copy link
Contributor Author

William-Francillette commented Mar 27, 2023 •
edited
Loading

@ykuijs I've just fixed the changelog

ykuijs
ykuijs approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykuijs ykuijs merged commit 97baceb into microsoft:Dev Mar 27, 2023
@William-Francillette William-Francillette deleted the IntuneAutopilotDeploymentProfile branch July 8, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykuijs ykuijs ykuijs approved these changes

@NikCharlebois NikCharlebois Awaiting requested review from NikCharlebois NikCharlebois is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IntuneDeviceManagementWindowAutopilotDeploymentProfile: New resource proposal
2 participants
@William-Francillette @ykuijs