Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group members for dynamic group/large groups #2190

Closed
anpiskai opened this issue Aug 16, 2022 · 3 comments · Fixed by #2275 or #2285
Closed

Group members for dynamic group/large groups #2190

anpiskai opened this issue Aug 16, 2022 · 3 comments · Fixed by #2275 or #2285
Labels
Bug Something isn't working Entra ID

Comments

@anpiskai
Copy link

My customer has several very big dynamic groups that they have created using M365 DSC. Prior to the recent changes in then 7/20 build, everything worked fine, however with the change to add in support for group members, there are new permission errors that show up. It looks as though membership is attempting to be reapplied, however since my groups are dynamic, group membership should not be applied explicitly (rather via rule). Additionally, this change has greatly increased the run-time from a few seconds for the resource to several minutes per group.

I'd recommend some kind of flag for when groups/licenses should be handled by DSC to allow for opting out of processing for those groups.

@andikrueger
Copy link
Collaborator

Did you remove these parameters from your resource configuration? They are not mandatory and as long as you do not need these properties managed by M365DSC, I would leave them out.

@anpiskai
Copy link
Author

Yep, those parameters are not present in the resource, but there must be some error in the logic where its absence is treated as a present empty array.
image

@andikrueger andikrueger added Bug Something isn't working and removed Pending Information labels Aug 17, 2022
@andikrueger
Copy link
Collaborator

Thanks for confirming. This need to be investigated.

Runtime is increasing due to the get method exporting all members… this is kind of the expected behaviour. Changing the settings without this parameters being present is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Entra ID
Projects
None yet
2 participants