Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AADConditionalAccessPolicy: Success but ExcludeUsers not getting updated #2079

Closed
grabery opened this issue Jul 7, 2022 · 2 comments · Fixed by #2090
Closed

AADConditionalAccessPolicy: Success but ExcludeUsers not getting updated #2079

grabery opened this issue Jul 7, 2022 · 2 comments · Fixed by #2090
Labels

Comments

@grabery
Copy link

grabery commented Jul 7, 2022

Details of the scenario you tried and the problem that is occurring

My DSC deployment is working just fine. But when I edit the "ExcludeUsers" of AADConditionalAccessPolicy Resource (remove value), it doesn't actually update on the policy and the user is still excluded. I get no error, the whole DSC-Configuration is running just fine (verbose) and does complete the "set" procedure. In the Azure Portal, I can see that "Modified Date" of the ConditionalAccessPolicy changed to the corresponding time, but the configuration did actually not change according to the new DSC-Configuration file, as described.

Btw. a colleague of mine noticed similar issues on SPO related settings.

Verbose logs showing the problem

none

Suggested solution to the issue

M365DSC should either log an error, or actually change the configuration as it is supposed to do :-)

The DSC configuration that is used to reproduce the issue (as detailed as possible)

# insert configuration here

The operating system the target node is running

Version of the DSC module that was used ('dev' if using current dev branch)

1.22.601.1

@andikrueger andikrueger added Bug Something isn't working Entra ID labels Jul 8, 2022
@NikCharlebois
Copy link
Collaborator

Just want to make sure we understand the scenario. For example, you have a CAP with 2 excluded users, then you remove one of the 2 users from the config, and apply it. This user is never removed from the ExcludedUsers? We are not able to repro on our end for whatever reason. Thanks

@NikCharlebois
Copy link
Collaborator

I believe your issue may be linked to #2058 where there was an issue removing the last item from included or excluded properties.

NikCharlebois added a commit to NikCharlebois/Microsoft365DSC that referenced this issue Jul 12, 2022
NikCharlebois added a commit to NikCharlebois/Microsoft365DSC that referenced this issue Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants