fix: [UIE-8163] - DBaaS V2 Landing Page platform fix #11030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage Report: ✅ |
cpathipa
reviewed
Oct 1, 2024
|
|
||
| const createClusterButton = container.querySelector('button'); | ||
| const headers = within(table).getAllByRole('columnheader'); | ||
| expect(headers.some((header) => header.textContent === 'Plan')).toBe(true); |
There was a problem hiding this comment.
Can we use getByText: Instead of manually iterating through the headers to check for the 'Plan' text,
example : expect(screen.getByText('Plan')).toBeInTheDocument();
There was a problem hiding this comment.
We can resolve outside a hotfix
| @@ -38,11 +38,31 @@ export const useIsDatabasesEnabled = () => { | |||
| account.capabilities.includes('Managed Databases Beta') && | |||
| flags.dbaasV2?.enabled; | |||
|
|
|||
| const isV2ExistingBetaUser = | |||
There was a problem hiding this comment.
We could use the isFeatureEnabledV2 hook here.
There was a problem hiding this comment.
We can refactor outside of a hotfix
abailly-akamai
approved these changes
Oct 1, 2024
cpathipa
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Bug Fix: Landing Page V2 issue for New Beta Users
Changes 🔄
Adjust the UI to send the correct platform field based on the user's account
Target release date 🗓️
10/01/24
Preview 📷
How to test 🧪
Prerequisites
Beta Flag must be enabled, and the user must have the "Managed Databases Beta" account capability.
Verification steps
(How to verify changes)
Go to the Landing Page.
The appropriate Landing Page is displayed based on the User's account type.
As an Author I have considered 🤔
Check all that apply
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/Improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support