Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-8614] - Update Image Upload dropzone copy as part of Image Service Gen2 #10986

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Sep 23, 2024

Description 📝

Makes some minor copy updates and UI tweaks on the Image Upload page based on UX's request 🎨

Preview 📷

Before After
Screenshot 2024-09-23 at 12 07 49 PM Screenshot 2024-09-23 at 12 06 57 PM

How to test 🧪

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai self-assigned this Sep 23, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner September 23, 2024 16:21
@bnussman-akamai bnussman-akamai requested review from carrillo-erik and cpathipa and removed request for a team September 23, 2024 16:21
Copy link

github-actions bot commented Sep 23, 2024

Coverage Report:
Base Coverage: 87.13%
Current Coverage: 87.13%

Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming on the copy updates.
No regressions found around image uplaod.

@carrillo-erik
Copy link
Contributor

Since this PR is dealing with copy updates, I feel that the price shown below the header should be updated to reflect the pricing format ($#.##) found in our Plans tables. Everything else looks good.

Screenshot 2024-09-24 at 7 42 47 AM

Screenshot 2024-09-24 at 7 48 48 AM

@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Sep 24, 2024
@bnussman-akamai
Copy link
Member Author

Good call @carrillo-erik

The technical writer and UX were cool with that change. Done in 1f92539

@bnussman-akamai bnussman-akamai merged commit 2a7be74 into linode:develop Sep 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Image Service Gen2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants