Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upcoming: [M3-8604] – Update URL for Volume Encryption guide #10973

Merged
merged 2 commits into from
Sep 20, 2024
Merged

upcoming: [M3-8604] – Update URL for Volume Encryption guide #10973

merged 2 commits into from
Sep 20, 2024

Conversation

dwiley-akamai
Copy link
Contributor

@dwiley-akamai dwiley-akamai commented Sep 19, 2024 •
edited
Loading

Description 📝

Update URL for Volume Encryption guide

Target release date 🗓️

9/30/24

How to test 🧪

Prerequisites

Point at the dev environment with the blockstorage-encryption tag on your account

Verification steps

The guide is linked to on the Volume Create page and in the Linode Details > Storage tab > Create and Attach Volume drawer. The "Learn more" text should link to the set URL.

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@dwiley-akamai dwiley-akamai added the Block Storage Encryption (BSE) Relating to Block Storage (Volumes) encryption label Sep 19, 2024
@dwiley-akamai dwiley-akamai self-assigned this Sep 19, 2024
@dwiley-akamai dwiley-akamai requested a review from a team as a code owner September 19, 2024 18:01
@dwiley-akamai dwiley-akamai requested review from hana-akamai and abailly-akamai and removed request for a team September 19, 2024 18:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

Coverage Report: ✅
Base Coverage: 86.94%
Current Coverage: 86.94%

abailly-akamai
abailly-akamai approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for using the new URL for our docs!

We gotta change all those indeed ✅

@hana-akamai hana-akamai added the Approved Multiple approvals and ready to merge! label Sep 20, 2024
@dwiley-akamai dwiley-akamai changed the title upcoming: [M3-8604] – Update URL for Volume Encryption upcoming: [M3-8604] – Update URL for Volume Encryption guide Sep 20, 2024
@dwiley-akamai dwiley-akamai merged commit 0a954bb into linode:develop Sep 20, 2024
18 of 20 checks passed
@dwiley-akamai dwiley-akamai deleted the M3-8604-update-volume-encryption-url branch September 20, 2024 18:22
This was referenced Sep 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abailly-akamai abailly-akamai abailly-akamai approved these changes

@hana-akamai hana-akamai hana-akamai approved these changes

Assignees

@dwiley-akamai dwiley-akamai

Labels
Approved Multiple approvals and ready to merge! Block Storage Encryption (BSE) Relating to Block Storage (Volumes) encryption
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dwiley-akamai @hana-akamai @abailly-akamai @DevDW