-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-8563 & M3-8566] – Fix BSE capability for linodes & prevent unnecessary API request on Volume Create page #10920
fix: [M3-8563 & M3-8566] – Fix BSE capability for linodes & prevent unnecessary API request on Volume Create page #10920
Conversation
…torage Encryption'
…hen user hasn't selected a Linode
…ge Encryption` instead of `blockstorage_encryption`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Should we update the capabilities
type to be more strict than just string
?
capabilities?: string[]; // @TODO BSE: Remove optionality once BSE is fully rolled out |
Coverage Report: ✅ |
…erty of Linode interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 Extra requests are gone.
Unrelated to this PR, while testing, I did notice a console state error that's happening once a Linode is selected and the config loads - but only initially. This probably existed before BSE changes and can be its own ticket, but mentioning here in case you had any recent context.
Screen.Recording.2024-09-11.at.9.26.27.AM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed extra requests to -1 are gone!
Maybe it has something to do with the replacement of |
…nnecessary API request on Volume Create page (linode#10920)
Description 📝
blockstorage_encryption
-->Block Storage Encryption
enabled
condition passed touseLinodeQuery()
on Volume Create page so it is true only iflinode_id !== null
Target release date 🗓️
9/16/24
Preview 📷
How to test 🧪
Prerequisites
Point at the dev environment with the
blockstorage-encryption
tag on your accountVerification steps
On the Volume Create page, you should no longer see requests to
linode/instances/-1
before selecting a linode.As an Author I have considered 🤔