feat: [M3-8172] - Add CopyableTextField story and clean up components #10912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
approved these changes
Sep 11, 2024
mjac0bs
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Looks like this PR fixed a styling bug in prod here where the Download button is hover state colored (blue) when the dialog was opened. 👍🏼
| Prod | This Branch |
|---|---|
|
Coverage Report: ✅ |
This was referenced Sep 13, 2024
nikhagra-akamai
pushed a commit
to nikhagra-akamai/manager
that referenced
this pull request
Sep 23, 2024
…linode#10912) ## Description 📝 Add CopyableTextField story and merge `CopyableAndDownloadableTextField` component into `CopyableTextField` ## How to test 🧪 ### Verification steps (How to verify changes) - Run storybook locally and verify changes - There should be no regressions in the app where `CopyableTextField` is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add CopyableTextField story and merge
CopyableAndDownloadableTextFieldcomponent intoCopyableTextFieldPreview 📷
Screen.Recording.2024-09-09.at.4.16.48.PM.mov
How to test 🧪
Verification steps
(How to verify changes)
CopyableTextFieldis usedAs an Author I have considered 🤔
Check all that apply