feat: [UIE-8006] - DBaaS 2.0 Create

[corya-akamai]

Description 📝

DBaaS 2.0 enhancements to create page

Changes 🔄

• New 2 node option for dedicated CPUs
• Expose handleTabChange in PanelsPanel to show/hide 2 node option

Target release date 🗓️

9/10/24

How to test 🧪

Prerequisites

• "Managed Databases V2" capability
• dbaasV2 flag enabled

Verification steps

• 2 node option will appear on create page

As an Author I have considered 🤔

Check all that apply

• 👀 Doing a self review
• ❔ Our contribution guidelines
• 🤏 Splitting feature into small PRs
• ➕ Adding a changeset
• 🧪 Providing/Improving test coverage
• 🔐 Removing all sensitive information from the code and PR description
• 🚩 Using a feature flag to protect the release
• 👣 Providing comprehensive reproduction steps
• 📑 Providing or updating our documentation
• 🕛 Scheduling a pair reviewing session
• 📱 Providing mobile support
• ♿ Providing accessibility support

[abailly-akamai]

@corya-akamai thx for the contribution! How does one get the "Managed Databases V2" capability?

[github-actions]

Coverage Report: ✅
Base Coverage: 86.21%
Current Coverage: 86.27%

[corya-akamai]

@corya-akamai thx for the contribution! How does one get the "Managed Databases V2" capability?
@abailly-akamai,
dchavan can give you access, or adding it to the Legacy mock data accountFactory capabilities

[abailly-akamai]

Looks good and works as described.

create-database e2e failing is suspicious approving confirming this test.

Let a couple other comments for consideration

[mjac0bs]

Hey @corya-akamai - Alban is right that the Cypress failure for create-database.spec.ts does seem related here. That test fails locally for me consistently for all 3 test cases at the point where it's trying to await the mocked createDatabase request. I don't know what the issue is here right off - I confirmed can still create a database in the UI by clicking the button. And although we're not checking for 2 Nodes as a option, 1 Node and 3 Nodes are still present and selectable in the test. (Maybe @AzureLatte or @jdamore-linode can spot what I'm overlooking.)

Other than that, this PR looked good - I had some minor comments on test clean up, thank you for the coverage.

[corya-akamai]

Hey @corya-akamai - Alban is right that the Cypress failure for create-database.spec.ts does seem related here. That test fails locally for me consistently for all 3 test cases at the point where it's trying to await the mocked createDatabase request. I don't know what the issue is here right off - I confirmed can still create a database in the UI by clicking the button. And although we're not checking for 2 Nodes as a option, 1 Node and 3 Nodes are still present and selectable in the test. (Maybe @AzureLatte or @jdamore-linode can spot what I'm overlooking.)

Other than that, this PR looked good - I had some minor comments on test clean up, thank you for the coverage.

@mjac0bs,

The error was due to shared mock data https://github.com/linode/manager/pull/10872/files#r1744096806. The create-database.spec is now passing. I noticed the resize-database.spec is failing, but that seems to be failing back to v1.21.0 when it was added https://github.com/linode/manager/pull/10461/files. Maybe @sujai-git or stayal can fix. I tried

beforeEach(() => {
    mockAppendFeatureFlags({
      databaseResize: makeFeatureFlagData(true),
    });
    mockGetFeatureFlagClientstream();
});

but that didn't seem to resolve the issue.

[mjac0bs]

@corya-akamai Good find and fix on the Capability - that makes sense.

I went back and looked at the CI e2e run and noticed it's resize-linode.spec.ts, not to be confused with resize-database.spec.ts, that is failing (as well as longview.spec.ts). I wouldn't expect the changes in this PR to have any impact on those tests, nor have I seen them fail consistently in CI recently, so I think those failures were just flukes.

Just for confirmation's sake, all of the following passed for me locally. Unit tests are fine as well; the code coverage action was just skipped.

(I'm going to go ahead and merge this now.)