feat: [UIE-8002] - DBaaS 2.0 Landing Page #10823

mpolotsk-akamai · 2024-08-23T15:43:10Z

Description 📝

DBaaS 2.0 Landing Page and Empty Landing Page

Changes 🔄

Added Tabs to the Landing Page: Two tabs for Beta customers, labeled "Legacy Databases" and "New Databases."
Added Logo(including dark theme): Displayed on the Empty Landing Page, in the "New Databases" tab, and in the "New Databases" single table view.
Single Table Landing Page: Added for Beta customers without "Legacy Databases" but with "New Databases," and for new customers with only "New Databases."
New "Plan" Column: Added to the "New Databases" table.
Added Info Banner: Included on the landing page.

Target release date 🗓️

9/9/24

Preview 📷

Include a screenshot or screen recording of the change

💡 Use <video src="" /> tag when including recordings in table.

Before	After

How to test 🧪

Note:
To test all beta features, beta must be enabled, and the user must have the "Managed Databases Beta" account capability.

Prerequisites

(How to setup test environment)
Enable DatabaseV2Beta flag

Verification steps

(How to verify changes)

Navigate to the Databases section.
For new customers (with no legacy or new databases), the Landing Page will display an Empty Landing Page with a Logo.
For customers with Legacy Databases, the Landing Page will show tabs for "Legacy Databases" and "New Databases," along with an info banner.
When "New Databases" tab is selected, the page will display a table with an additional "Plan" column and a logo below the table. The "Configuration" column will be renamed to "Nodes." The table will be empty if no new databases are present.
For customers without Legacy Databases but with New Databases, the Landing Page will show a single table with a "Plan" column and the "Configuration" column renamed to "Nodes," an info banner, and a Logo below the table.
If the DatabaseV2Beta flag is disabled, the Landing Page will display a single table with no changes.

As an Author I have considered 🤔

Check all that apply

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLogo.tsx

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLandingEmptyStateData.tsx

mjac0bs · 2024-08-23T17:58:23Z

@mpolotsk-akamai I just merged in #10786 so we'll want to rebase this PR on develop.

mpolotsk-akamai · 2024-08-26T11:55:17Z

@mpolotsk-akamai I just merged in #10786 so we'll want to rebase this PR on develop.

@mjac0bs , thanks, I've rebased the PR

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLanding.tsx

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLanding.test.tsx

github-actions · 2024-08-26T19:41:53Z

Coverage Report: ✅
Base Coverage: 86.63%
Current Coverage: 86.63%

packages/api-v4/src/databases/types.ts

packages/manager/src/factories/databases.ts

packages/manager/src/features/Support/SupportTickets/SupportTicketProductSelectionFields.tsx

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLandingTable.tsx

packages/manager/src/components/EmptyLandingPageResources/ResourcesLinksTypes.ts

packages/manager/.changeset/pr-10823-added-1724427890426.md

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLanding.test.tsx

packages/manager/src/features/GlobalNotifications/DatabaseClusterInfoBanner.tsx

mjac0bs

Thanks for addressing feedback, @mpolotsk-akamai - I just left a couple of minor notes on my final pass through.

CI was struggling to run the full e2e suite but I'll make sure DBaaS is all passing before this gets merged.

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLogo.tsx

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLanding.tsx

packages/manager/src/features/Databases/DatabaseLanding/DatabaseRow.tsx

mjac0bs · 2024-08-30T16:37:43Z

@mpolotsk-akamai Just noticed that typecheck is was failing - using the optional chaining operator to access databases?.data should fix that where there are errors.

bnussman-akamai

This is shaping up nicely! Will continue to review, but left a few more small comments in the meantime

packages/manager/src/features/Databases/DatabaseLanding/DatabaseRow.tsx

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLandingTable.tsx

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLanding.tsx

… for DBaaS V2

bnussman-akamai

I'm seeing extra spacing here compared to production that we should fix

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLanding.tsx

jdamore-linode

Just want to call out the failing Cypress tests in create-database.spec.ts so we don't accidentally merge this before they're fixed.

It looks like the tests are failing because no regions are appearing in the region select drop-down -- that's probably caused by something not being mocked

mpolotsk-akamai · 2024-09-12T15:22:29Z

Just want to call out the failing Cypress tests in create-database.spec.ts so we don't accidentally merge this before they're fixed.

It looks like the tests are failing because no regions are appearing in the region select drop-down -- that's probably caused by something not being mocked

@jdamore-linode, I've fixed the issue.

jdamore-linode · 2024-09-12T15:23:39Z

Nice! Thanks @mpolotsk-akamai!

jdamore-linode

Thanks again @mpolotsk-akamai!

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLanding.tsx

mjac0bs

Thanks @mpolotsk-akamai and @corya-akamai - looking good now. I'll merge this as soon as CI finishes.

* feat: [UIE-8054] - DBaaS enhancements 1 * UIE-8002 feat(DBaaS): New/Existing Customer Landing Page * UIE-8002 feat(DBaaS): Landing Page with feature flag * Added changeset: Add Landing Page for V2 * Added changeset: Add Landing Page and update Empty-State Landing page for DBaaS V2 * feat: [UIE-8002] - Review fix: refactoring and variable renaming * feat: [UIE-8002] - Review fix: change capability for region select --------- Co-authored-by: Conal Ryan <[email protected]>

mpolotsk-akamai requested a review from a team as a code owner August 23, 2024 15:43

mpolotsk-akamai requested review from mjac0bs and harsh-akamai and removed request for a team August 23, 2024 15:43

jaalah-akamai reviewed Aug 23, 2024

View reviewed changes

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLogo.tsx Outdated Show resolved Hide resolved

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLandingEmptyStateData.tsx Outdated Show resolved Hide resolved

mjac0bs assigned mpolotsk-akamai Aug 23, 2024

mjac0bs added the DBaaS Relates to Database as a Service label Aug 23, 2024

mpolotsk-akamai force-pushed the feature/UIE-8002-New-Customer-Flow-Landing-Page branch 2 times, most recently from a837c8e to ea91214 Compare August 26, 2024 11:45

mpolotsk-akamai requested a review from jaalah-akamai August 26, 2024 11:48

bnussman-akamai requested changes Aug 26, 2024

View reviewed changes

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLanding.tsx Outdated Show resolved Hide resolved

harsh-akamai reviewed Aug 26, 2024

View reviewed changes

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLanding.test.tsx Outdated Show resolved Hide resolved

corya-akamai reviewed Aug 27, 2024

View reviewed changes

packages/api-v4/src/databases/types.ts Outdated Show resolved Hide resolved

corya-akamai reviewed Aug 27, 2024

View reviewed changes

packages/manager/src/factories/databases.ts Outdated Show resolved Hide resolved

mpolotsk-akamai force-pushed the feature/UIE-8002-New-Customer-Flow-Landing-Page branch 3 times, most recently from 8fee671 to a77a2ec Compare August 28, 2024 16:42

mjac0bs reviewed Aug 28, 2024

View reviewed changes

mpolotsk-akamai force-pushed the feature/UIE-8002-New-Customer-Flow-Landing-Page branch from a77a2ec to f615f52 Compare August 28, 2024 17:50

mpolotsk-akamai requested a review from mjac0bs August 28, 2024 17:56

mpolotsk-akamai force-pushed the feature/UIE-8002-New-Customer-Flow-Landing-Page branch from 4952395 to 6962afe Compare August 29, 2024 16:17

mjac0bs approved these changes Aug 30, 2024

View reviewed changes

mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Aug 30, 2024

bnussman-akamai reviewed Sep 4, 2024

View reviewed changes

bnussman-akamai self-requested a review September 4, 2024 14:42

mpolotsk-akamai force-pushed the feature/UIE-8002-New-Customer-Flow-Landing-Page branch from 6962afe to 910e0df Compare September 5, 2024 08:26

mpolotsk-akamai force-pushed the feature/UIE-8002-New-Customer-Flow-Landing-Page branch from 910e0df to 87ba377 Compare September 5, 2024 10:28

corya-akamai and others added 5 commits September 6, 2024 11:48

feat: [UIE-8054] - DBaaS enhancements 1

cf6a86f

UIE-8002 feat(DBaaS): New/Existing Customer Landing Page

bf19e69

UIE-8002 feat(DBaaS): Landing Page with feature flag

c123751

Added changeset: Add Landing Page for V2

2568ebd

Added changeset: Add Landing Page and update Empty-State Landing page…

6f2fd14

… for DBaaS V2

bnussman-akamai reviewed Sep 6, 2024

View reviewed changes

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLanding.tsx Show resolved Hide resolved

mpolotsk-akamai force-pushed the feature/UIE-8002-New-Customer-Flow-Landing-Page branch from 87ba377 to c703764 Compare September 9, 2024 12:04

bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Sep 9, 2024

bnussman-akamai approved these changes Sep 9, 2024

View reviewed changes

mpolotsk-akamai force-pushed the feature/UIE-8002-New-Customer-Flow-Landing-Page branch from c703764 to bac6623 Compare September 9, 2024 13:59

feat: [UIE-8002] - Review fix: refactoring and variable renaming

92369fb

mpolotsk-akamai force-pushed the feature/UIE-8002-New-Customer-Flow-Landing-Page branch from bac6623 to 92369fb Compare September 11, 2024 11:44

jdamore-linode requested changes Sep 11, 2024

View reviewed changes

mpolotsk-akamai force-pushed the feature/UIE-8002-New-Customer-Flow-Landing-Page branch from ee35a62 to f4683a8 Compare September 12, 2024 14:15

jdamore-linode self-requested a review September 12, 2024 15:23

jdamore-linode approved these changes Sep 12, 2024

View reviewed changes

mjac0bs requested changes Sep 12, 2024

View reviewed changes

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLanding.tsx Outdated Show resolved Hide resolved

feat: [UIE-8002] - Review fix: change capability for region select

c3460e7

mpolotsk-akamai force-pushed the feature/UIE-8002-New-Customer-Flow-Landing-Page branch from f4683a8 to c3460e7 Compare September 13, 2024 16:27

mjac0bs approved these changes Sep 13, 2024

View reviewed changes

mjac0bs merged commit f0d9765 into linode:develop Sep 13, 2024
19 checks passed

This was referenced Sep 25, 2024

Release v1.129.0 - release → staging #11006

Merged

Release v1.129.0 - staging → master #11013

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [UIE-8002] - DBaaS 2.0 Landing Page #10823

feat: [UIE-8002] - DBaaS 2.0 Landing Page #10823

mpolotsk-akamai commented Aug 23, 2024 •

edited

Loading

mjac0bs commented Aug 23, 2024

mpolotsk-akamai commented Aug 26, 2024

github-actions bot commented Aug 26, 2024 •

edited

Loading

mjac0bs left a comment

mjac0bs commented Aug 30, 2024

bnussman-akamai left a comment

bnussman-akamai left a comment

jdamore-linode left a comment

mpolotsk-akamai commented Sep 12, 2024

jdamore-linode commented Sep 12, 2024

jdamore-linode left a comment

mjac0bs left a comment

feat: [UIE-8002] - DBaaS 2.0 Landing Page #10823

feat: [UIE-8002] - DBaaS 2.0 Landing Page #10823

Conversation

mpolotsk-akamai commented Aug 23, 2024 • edited Loading

Description 📝

Changes 🔄

Target release date 🗓️

Preview 📷

Prerequisites

Verification steps

As an Author I have considered 🤔

mjac0bs commented Aug 23, 2024

mpolotsk-akamai commented Aug 26, 2024

github-actions bot commented Aug 26, 2024 • edited Loading

mjac0bs left a comment

Choose a reason for hiding this comment

mjac0bs commented Aug 30, 2024

bnussman-akamai left a comment

Choose a reason for hiding this comment

bnussman-akamai left a comment

Choose a reason for hiding this comment

jdamore-linode left a comment

Choose a reason for hiding this comment

mpolotsk-akamai commented Sep 12, 2024

jdamore-linode commented Sep 12, 2024

jdamore-linode left a comment

Choose a reason for hiding this comment

mjac0bs left a comment

Choose a reason for hiding this comment

mpolotsk-akamai commented Aug 23, 2024 •

edited

Loading

github-actions bot commented Aug 26, 2024 •

edited

Loading