-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-8098] - Refactor StackScript create test to be resilient to Image deprecations #10788
Conversation
Coverage Report: ✅ |
…Image deprecations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not totally certain what's happening here, because this test seems to be failing due to a regions-related issue. I get consistent failures on the first test case locally. If I skip that first test case and only run the second (the only one this PR touches), that did pass. Another case of M3-8471? cc @jdamore-linode
When I checked CI, I see that the first and third runners had failing tests. The test failure on the third runner is expected and fixed recently in #10811. I can't see the failures on the first runner due to some CI UI glitch, but by searching for this PR number (10788
) in our notifications Slack channel, it looks like this spec is failing there too.
It sounds like maybe yes and no... when I run the test locally I don't have any issue with Cypress finding the region by its ID, but I do still get failures pretty often but not consistently (seems kinda 50/50). But the fact that it's failing consistently for you makes it sound like you could be experiencing the ID issue -- were you running Cloud with In my case, the issue seems to be caused by these two factors:
Either way, I'll have a ticket and PR open later this afternoon, and will circle back and review @AzureLatte's improvements to this other test too! We can disregard this failure for the sake of PR review since we are seeing this happen in CI where Azure's changes aren't present. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since test failures (which are addressed in follow-up PRs) are unrelated to these changes, which look good and pass consistently.
Thank you all for the review! |
Description 📝
Update StackScript create test to be more resilient to the changes that Images may be deprecated on the backend by using real Image data retrieved directly from the API.
Changes 🔄
How to test 🧪
As an Author I have considered 🤔
Check all that apply